Title: [154666] trunk/Source/WebCore
- Revision
- 154666
- Author
- calva...@igalia.com
- Date
- 2013-08-27 00:26:28 -0700 (Tue, 27 Aug 2013)
Log Message
[GTK] Volume slider shows incorrect track when muted
https://bugs.webkit.org/show_bug.cgi?id=120253
Reviewed by Philippe Normand.
When painting the volume bar, consider that it could be muted even
then volume is different than zero.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
painted volume as 0 when media is muted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154665 => 154666)
--- trunk/Source/WebCore/ChangeLog 2013-08-27 07:19:07 UTC (rev 154665)
+++ trunk/Source/WebCore/ChangeLog 2013-08-27 07:26:28 UTC (rev 154666)
@@ -1,3 +1,17 @@
+2013-08-27 Xabier Rodriguez Calvar <calva...@igalia.com>
+
+ [GTK] Volume slider shows incorrect track when muted
+ https://bugs.webkit.org/show_bug.cgi?id=120253
+
+ Reviewed by Philippe Normand.
+
+ When painting the volume bar, consider that it could be muted even
+ then volume is different than zero.
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
+ painted volume as 0 when media is muted.
+
2013-08-26 Sam Weinig <s...@webkit.org>
EditorInternalCommand should use Frame& where possible
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp (154665 => 154666)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2013-08-27 07:19:07 UTC (rev 154665)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2013-08-27 07:26:28 UTC (rev 154666)
@@ -604,7 +604,7 @@
if (!mediaElement)
return true;
- float volume = mediaElement->volume();
+ float volume = mediaElement->muted() ? 0.0f : mediaElement->volume();
if (!volume)
return true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
