Title: [154685] trunk/Source/WebCore
- Revision
- 154685
- Author
- [email protected]
- Date
- 2013-08-27 08:06:04 -0700 (Tue, 27 Aug 2013)
Log Message
HTMLAppletElement: Use child iterator to walk <param> children.
<https://webkit.org/b/120361>
Reviewed by Antti Koivisto.
Take Antti's fancy new child iterator for a quick spin.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154684 => 154685)
--- trunk/Source/WebCore/ChangeLog 2013-08-27 15:04:22 UTC (rev 154684)
+++ trunk/Source/WebCore/ChangeLog 2013-08-27 15:06:04 UTC (rev 154685)
@@ -1,3 +1,15 @@
+2013-08-27 Andreas Kling <[email protected]>
+
+ HTMLAppletElement: Use child iterator to walk <param> children.
+ <https://webkit.org/b/120361>
+
+ Reviewed by Antti Koivisto.
+
+ Take Antti's fancy new child iterator for a quick spin.
+
+ * html/HTMLAppletElement.cpp:
+ (WebCore::HTMLAppletElement::updateWidget):
+
2013-08-27 Andre Moreira Magalhaes <[email protected]>
[gstreamer] Make sure gstreamer source element is thread-safe
Modified: trunk/Source/WebCore/html/HTMLAppletElement.cpp (154684 => 154685)
--- trunk/Source/WebCore/html/HTMLAppletElement.cpp 2013-08-27 15:04:22 UTC (rev 154684)
+++ trunk/Source/WebCore/html/HTMLAppletElement.cpp 2013-08-27 15:06:04 UTC (rev 154685)
@@ -24,7 +24,7 @@
#include "config.h"
#include "HTMLAppletElement.h"
-#include "Attribute.h"
+#include "ChildIterator.h"
#include "Frame.h"
#include "FrameLoader.h"
#include "HTMLDocument.h"
@@ -147,11 +147,8 @@
paramValues.append(mayScript.string());
}
- for (Node* child = firstChild(); child; child = child->nextSibling()) {
- if (!child->hasTagName(paramTag))
- continue;
-
- HTMLParamElement* param = static_cast<HTMLParamElement*>(child);
+ auto paramChildren = childrenOfType<HTMLParamElement>(this);
+ for (auto param = paramChildren.begin(), end = paramChildren.end(); param != end; ++param) {
if (param->name().isEmpty())
continue;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
