Title: [154721] trunk/Source/WebCore
Revision
154721
Author
[email protected]
Date
2013-08-27 21:00:51 -0700 (Tue, 27 Aug 2013)

Log Message

Adding  "explicit" keyword in  forms related classes constructor
https://bugs.webkit.org/show_bug.cgi?id=120366

Patch by Santosh Mahto <[email protected]> on 2013-08-27
Reviewed by Darin Adler.

Adding "explicit" keyword in constructors.

* html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType):
* html/BaseCheckableInputType.h:
(WebCore::BaseCheckableInputType::BaseCheckableInputType):
* html/BaseChooserOnlyDateAndTimeInputType.h:
(WebCore::BaseChooserOnlyDateAndTimeInputType::BaseChooserOnlyDateAndTimeInputType):
* html/BaseClickableWithKeyInputType.h:
(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):
* html/BaseTextInputType.h:
(WebCore::BaseTextInputType::BaseTextInputType):
* html/ColorInputType.h:
(WebCore::ColorInputType::ColorInputType):
* html/DateInputType.h:
* html/DateTimeInputType.h:
(WebCore::DateTimeInputType::DateTimeInputType):
* html/DateTimeLocalInputType.h:
(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
* html/EmailInputType.h:
(WebCore::EmailInputType::EmailInputType):
* html/FileInputType.h:
* html/HiddenInputType.h:
(WebCore::HiddenInputType::HiddenInputType):
* html/ImageData.h:
* html/ImageInputType.h:
* html/InputType.h:
(WebCore::InputType::InputType):
* html/MediaController.h:
* html/MonthInputType.h:
(WebCore::MonthInputType::MonthInputType):
* html/RadioInputType.h:
(WebCore::RadioInputType::RadioInputType):
* html/RangeInputType.h:
* html/ResetInputType.h:
(WebCore::ResetInputType::ResetInputType):
* html/SearchInputType.h:
* html/SubmitInputType.h:
(WebCore::SubmitInputType::SubmitInputType):
* html/TelephoneInputType.h:
(WebCore::TelephoneInputType::TelephoneInputType):
* html/TextFieldInputType.h:
* html/TextInputType.h:
(WebCore::TextInputType::TextInputType):
* html/TimeInputType.h:
* html/URLInputType.h:
(WebCore::URLInputType::URLInputType):
* html/ValidationMessage.h:
* html/WeekInputType.h:
(WebCore::WeekInputType::WeekInputType):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (154720 => 154721)


--- trunk/Source/WebCore/ChangeLog	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 04:00:51 UTC (rev 154721)
@@ -1,3 +1,61 @@
+2013-08-27  Santosh Mahto  <[email protected]>
+
+        Adding  "explicit" keyword in  forms related classes constructor
+        https://bugs.webkit.org/show_bug.cgi?id=120366
+
+        Reviewed by Darin Adler.
+
+        Adding "explicit" keyword in constructors.
+
+        * html/BaseButtonInputType.h:
+        (WebCore::BaseButtonInputType::BaseButtonInputType):
+        * html/BaseCheckableInputType.h:
+        (WebCore::BaseCheckableInputType::BaseCheckableInputType):
+        * html/BaseChooserOnlyDateAndTimeInputType.h:
+        (WebCore::BaseChooserOnlyDateAndTimeInputType::BaseChooserOnlyDateAndTimeInputType):
+        * html/BaseClickableWithKeyInputType.h:
+        (WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):
+        * html/BaseTextInputType.h:
+        (WebCore::BaseTextInputType::BaseTextInputType):
+        * html/ColorInputType.h:
+        (WebCore::ColorInputType::ColorInputType):
+        * html/DateInputType.h:
+        * html/DateTimeInputType.h:
+        (WebCore::DateTimeInputType::DateTimeInputType):
+        * html/DateTimeLocalInputType.h:
+        (WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
+        * html/EmailInputType.h:
+        (WebCore::EmailInputType::EmailInputType):
+        * html/FileInputType.h:
+        * html/HiddenInputType.h:
+        (WebCore::HiddenInputType::HiddenInputType):
+        * html/ImageData.h:
+        * html/ImageInputType.h:
+        * html/InputType.h:
+        (WebCore::InputType::InputType):
+        * html/MediaController.h:
+        * html/MonthInputType.h:
+        (WebCore::MonthInputType::MonthInputType):
+        * html/RadioInputType.h:
+        (WebCore::RadioInputType::RadioInputType):
+        * html/RangeInputType.h:
+        * html/ResetInputType.h:
+        (WebCore::ResetInputType::ResetInputType):
+        * html/SearchInputType.h:
+        * html/SubmitInputType.h:
+        (WebCore::SubmitInputType::SubmitInputType):
+        * html/TelephoneInputType.h:
+        (WebCore::TelephoneInputType::TelephoneInputType):
+        * html/TextFieldInputType.h:
+        * html/TextInputType.h:
+        (WebCore::TextInputType::TextInputType):
+        * html/TimeInputType.h:
+        * html/URLInputType.h:
+        (WebCore::URLInputType::URLInputType):
+        * html/ValidationMessage.h:
+        * html/WeekInputType.h:
+        (WebCore::WeekInputType::WeekInputType):
+
 2013-08-27  Benjamin Poulain  <[email protected]>
 
         Fix the indentation of SpaceSplitString

Modified: trunk/Source/WebCore/html/BaseButtonInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/BaseButtonInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/BaseButtonInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -38,7 +38,7 @@
 // Base of button, file, image, reset, and submit types.
 class BaseButtonInputType : public BaseClickableWithKeyInputType {
 protected:
-    BaseButtonInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }
+    explicit BaseButtonInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }
 
 private:
     virtual bool shouldSaveAndRestoreFormControlState() const OVERRIDE;

Modified: trunk/Source/WebCore/html/BaseCheckableInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/BaseCheckableInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/BaseCheckableInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -38,7 +38,7 @@
 // Base of checkbox and radio types.
 class BaseCheckableInputType : public InputType {
 protected:
-    BaseCheckableInputType(HTMLInputElement* element) : InputType(element) { }
+    explicit BaseCheckableInputType(HTMLInputElement* element) : InputType(element) { }
     virtual void handleKeydownEvent(KeyboardEvent*);
 
 private:

Modified: trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -36,7 +36,7 @@
 
 class BaseChooserOnlyDateAndTimeInputType : public BaseDateAndTimeInputType, public DateTimeChooserClient {
 protected:
-    BaseChooserOnlyDateAndTimeInputType(HTMLInputElement* element) : BaseDateAndTimeInputType(element) { }
+    explicit BaseChooserOnlyDateAndTimeInputType(HTMLInputElement* element) : BaseDateAndTimeInputType(element) { }
     virtual ~BaseChooserOnlyDateAndTimeInputType();
 
 private:

Modified: trunk/Source/WebCore/html/BaseClickableWithKeyInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/BaseClickableWithKeyInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/BaseClickableWithKeyInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -44,7 +44,7 @@
     static void accessKeyAction(HTMLInputElement*, bool sendMouseEvents);
     
 protected:
-    BaseClickableWithKeyInputType(HTMLInputElement* element) : InputType(element) { }
+    explicit BaseClickableWithKeyInputType(HTMLInputElement* element) : InputType(element) { }
 
 private:
     virtual void handleKeydownEvent(KeyboardEvent*) OVERRIDE;

Modified: trunk/Source/WebCore/html/BaseTextInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/BaseTextInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/BaseTextInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -39,7 +39,7 @@
 // They support maxlength, selection functions, and so on.
 class BaseTextInputType : public TextFieldInputType {
 protected:
-    BaseTextInputType(HTMLInputElement* element) : TextFieldInputType(element) { }
+    explicit BaseTextInputType(HTMLInputElement* element) : TextFieldInputType(element) { }
 
 private:
     virtual bool isTextType() const OVERRIDE;

Modified: trunk/Source/WebCore/html/ColorInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/ColorInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/ColorInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -51,7 +51,7 @@
     virtual Vector<Color> suggestions() const OVERRIDE;
 
 private:
-    ColorInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }
+    explicit ColorInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual bool isColorControl() const OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;

Modified: trunk/Source/WebCore/html/DateInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/DateInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/DateInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -41,7 +41,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    DateInputType(HTMLInputElement*);
+    explicit DateInputType(HTMLInputElement*);
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual DateComponents::Type dateType() const OVERRIDE;

Modified: trunk/Source/WebCore/html/DateTimeInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/DateTimeInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/DateTimeInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -42,7 +42,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    DateTimeInputType(HTMLInputElement* element) : BaseDateTimeInputType(element) { }
+    explicit DateTimeInputType(HTMLInputElement* element) : BaseDateTimeInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual DateComponents::Type dateType() const OVERRIDE;

Modified: trunk/Source/WebCore/html/DateTimeLocalInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/DateTimeLocalInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/DateTimeLocalInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -41,7 +41,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    DateTimeLocalInputType(HTMLInputElement* element) : BaseDateTimeLocalInputType(element) { }
+    explicit DateTimeLocalInputType(HTMLInputElement* element) : BaseDateTimeLocalInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual DateComponents::Type dateType() const OVERRIDE;

Modified: trunk/Source/WebCore/html/EmailInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/EmailInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/EmailInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -40,7 +40,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    EmailInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
+    explicit EmailInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual bool typeMismatchFor(const String&) const OVERRIDE;

Modified: trunk/Source/WebCore/html/FileInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/FileInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/FileInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -50,7 +50,7 @@
     static Vector<FileChooserFileInfo> filesFromFormControlState(const FormControlState&);
 
 private:
-    FileInputType(HTMLInputElement*);
+    explicit FileInputType(HTMLInputElement*);
 
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual FormControlState saveFormControlState() const OVERRIDE;

Modified: trunk/Source/WebCore/html/HiddenInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/HiddenInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/HiddenInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -40,7 +40,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    HiddenInputType(HTMLInputElement* element) : InputType(element) { }
+    explicit HiddenInputType(HTMLInputElement* element) : InputType(element) { }
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual FormControlState saveFormControlState() const OVERRIDE;
     virtual void restoreFormControlState(const FormControlState&) OVERRIDE;

Modified: trunk/Source/WebCore/html/ImageData.h (154720 => 154721)


--- trunk/Source/WebCore/html/ImageData.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/ImageData.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -47,7 +47,7 @@
     Uint8ClampedArray* data() const { return m_data.get(); }
 
 private:
-    ImageData(const IntSize&);
+    explicit ImageData(const IntSize&);
     ImageData(const IntSize&, PassRefPtr<Uint8ClampedArray>);
 
     IntSize m_size;

Modified: trunk/Source/WebCore/html/ImageInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/ImageInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/ImageInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -43,7 +43,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    ImageInputType(HTMLInputElement*);
+    explicit ImageInputType(HTMLInputElement*);
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual bool isFormDataAppendable() const OVERRIDE;
     virtual bool appendFormData(FormDataList&, bool) const OVERRIDE;

Modified: trunk/Source/WebCore/html/InputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/InputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/InputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -312,7 +312,7 @@
     void dispatchSimulatedClickIfActive(KeyboardEvent*) const;
 
 protected:
-    InputType(HTMLInputElement* element) : m_element(element) { }
+    explicit InputType(HTMLInputElement* element) : m_element(element) { }
     HTMLInputElement* element() const { return m_element; }
     Chrome* chrome() const;
     Decimal parseToNumberOrNaN(const String&) const;

Modified: trunk/Source/WebCore/html/MediaController.h (154720 => 154721)


--- trunk/Source/WebCore/html/MediaController.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/MediaController.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -114,7 +114,7 @@
     using RefCounted<MediaController>::deref;
 
 private:
-    MediaController(ScriptExecutionContext*);
+    explicit MediaController(ScriptExecutionContext*);
     void reportControllerState();
     void updateReadyState();
     void updatePlaybackState();

Modified: trunk/Source/WebCore/html/MonthInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/MonthInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/MonthInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -41,7 +41,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    MonthInputType(HTMLInputElement* element) : BaseMonthInputType(element) { }
+    explicit MonthInputType(HTMLInputElement* element) : BaseMonthInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual DateComponents::Type dateType() const OVERRIDE;

Modified: trunk/Source/WebCore/html/RadioInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/RadioInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/RadioInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -40,7 +40,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    RadioInputType(HTMLInputElement* element) : BaseCheckableInputType(element) { }
+    explicit RadioInputType(HTMLInputElement* element) : BaseCheckableInputType(element) { }
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual bool valueMissing(const String&) const OVERRIDE;
     virtual String valueMissingText() const OVERRIDE;

Modified: trunk/Source/WebCore/html/RangeInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/RangeInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/RangeInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -42,7 +42,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    RangeInputType(HTMLInputElement*);
+    explicit RangeInputType(HTMLInputElement*);
     virtual void attach() OVERRIDE;
     virtual bool isRangeControl() const OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;

Modified: trunk/Source/WebCore/html/ResetInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/ResetInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/ResetInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -40,7 +40,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    ResetInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }
+    explicit ResetInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual bool supportsValidation() const OVERRIDE;
     virtual void handleDOMActivateEvent(Event*) OVERRIDE;

Modified: trunk/Source/WebCore/html/SearchInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/SearchInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/SearchInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -46,7 +46,7 @@
     void stopSearchEventTimer();
 
 private:
-    SearchInputType(HTMLInputElement*);
+    explicit SearchInputType(HTMLInputElement*);
     virtual void attach() OVERRIDE;
     virtual void addSearchResult() OVERRIDE;
     virtual RenderObject* createRenderer(RenderArena*, RenderStyle*) const OVERRIDE;

Modified: trunk/Source/WebCore/html/SubmitInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/SubmitInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/SubmitInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -40,7 +40,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    SubmitInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }
+    explicit SubmitInputType(HTMLInputElement* element) : BaseButtonInputType(element) { }
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual bool appendFormData(FormDataList&, bool) const OVERRIDE;
     virtual bool supportsRequired() const OVERRIDE;

Modified: trunk/Source/WebCore/html/TelephoneInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/TelephoneInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/TelephoneInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -40,7 +40,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    TelephoneInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
+    explicit TelephoneInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual bool shouldRespectSpeechAttribute() OVERRIDE;

Modified: trunk/Source/WebCore/html/TextFieldInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/TextFieldInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/TextFieldInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -42,7 +42,7 @@
 // It supports not only the types for BaseTextInputType but also type=number.
 class TextFieldInputType : public InputType, protected SpinButtonElement::SpinButtonOwner {
 protected:
-    TextFieldInputType(HTMLInputElement*);
+    explicit TextFieldInputType(HTMLInputElement*);
     virtual ~TextFieldInputType();
     virtual bool canSetSuggestedValue() OVERRIDE;
     virtual void handleKeydownEvent(KeyboardEvent*) OVERRIDE;

Modified: trunk/Source/WebCore/html/TextInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/TextInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/TextInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -40,7 +40,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    TextInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
+    explicit TextInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual bool shouldRespectSpeechAttribute() OVERRIDE;

Modified: trunk/Source/WebCore/html/TimeInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/TimeInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/TimeInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -41,7 +41,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    TimeInputType(HTMLInputElement*);
+    explicit TimeInputType(HTMLInputElement*);
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual DateComponents::Type dateType() const OVERRIDE;

Modified: trunk/Source/WebCore/html/URLInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/URLInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/URLInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -40,7 +40,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    URLInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
+    explicit URLInputType(HTMLInputElement* element) : BaseTextInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual bool typeMismatchFor(const String&) const OVERRIDE;

Modified: trunk/Source/WebCore/html/ValidationMessage.h (154720 => 154721)


--- trunk/Source/WebCore/html/ValidationMessage.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/ValidationMessage.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -57,7 +57,7 @@
     bool shadowTreeContains(const Node*) const;
 
 private:
-    ValidationMessage(HTMLFormControlElement*);
+    explicit ValidationMessage(HTMLFormControlElement*);
     ValidationMessageClient* validationMessageClient() const;
     void setMessage(const String&);
     void setMessageDOMAndStartTimer(Timer<ValidationMessage>* = 0);

Modified: trunk/Source/WebCore/html/WeekInputType.h (154720 => 154721)


--- trunk/Source/WebCore/html/WeekInputType.h	2013-08-28 03:43:56 UTC (rev 154720)
+++ trunk/Source/WebCore/html/WeekInputType.h	2013-08-28 04:00:51 UTC (rev 154721)
@@ -41,7 +41,7 @@
     static PassOwnPtr<InputType> create(HTMLInputElement*);
 
 private:
-    WeekInputType(HTMLInputElement* element) : BaseWeekInputType(element) { }
+    explicit WeekInputType(HTMLInputElement* element) : BaseWeekInputType(element) { }
     virtual void attach() OVERRIDE;
     virtual const AtomicString& formControlType() const OVERRIDE;
     virtual DateComponents::Type dateType() const OVERRIDE;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to