Title: [154733] trunk/Tools
Revision
154733
Author
[email protected]
Date
2013-08-28 05:13:05 -0700 (Wed, 28 Aug 2013)

Log Message

[Qt][Wk2] Many tests are flaky on Qt 5.1
https://bugs.webkit.org/show_bug.cgi?id=118232

Reviewed by Jocelyn Turcotte.

We need to set renderToOffscreenBuffer since we won't otherwise get
the paint calls necessary to synchronize UI- and Web-Process. It was
only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
which is no longer supported or needed.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (154732 => 154733)


--- trunk/Tools/ChangeLog	2013-08-28 10:30:07 UTC (rev 154732)
+++ trunk/Tools/ChangeLog	2013-08-28 12:13:05 UTC (rev 154733)
@@ -1,3 +1,18 @@
+2013-08-28  Allan Sandfeld Jensen  <[email protected]>
+
+        [Qt][Wk2] Many tests are flaky on Qt 5.1
+        https://bugs.webkit.org/show_bug.cgi?id=118232
+
+        Reviewed by Jocelyn Turcotte.
+
+        We need to set renderToOffscreenBuffer since we won't otherwise get
+        the paint calls necessary to synchronize UI- and Web-Process. It was
+        only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
+        which is no longer supported or needed.
+
+        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+        (WTR::WrapperWindow::handleStatusChanged):
+
 2013-08-27  Alexey Proskuryakov  <[email protected]>
 
         [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION

Modified: trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp (154732 => 154733)


--- trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp	2013-08-28 10:30:07 UTC (rev 154732)
+++ trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp	2013-08-28 12:13:05 UTC (rev 154733)
@@ -70,6 +70,8 @@
             create();
 #if QT_VERSION < QT_VERSION_CHECK(5, 1, 0)
             QQuickWindowPrivate::get(this)->setRenderWithoutShowing(true);
+#else
+            m_view->experimental()->setRenderToOffscreenBuffer(true);
 #endif
         } else
             m_view->experimental()->setRenderToOffscreenBuffer(true);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to