Title: [154802] trunk/Source/WebCore
Revision
154802
Author
[email protected]
Date
2013-08-28 19:33:42 -0700 (Wed, 28 Aug 2013)

Log Message

AX: WebProcess at com.apple.WebCore: WebCore::AXObjectCache::rootObject + 27
https://bugs.webkit.org/show_bug.cgi?id=120434

Reviewed by Darin Adler.

Crash logs indicate that there's a null pointer access in rootObject. That seems like it could only
happen in Document was null.

Unfortunately, there are no reproducible steps and no other information to construct a test case.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rootObject):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (154801 => 154802)


--- trunk/Source/WebCore/ChangeLog	2013-08-29 01:35:21 UTC (rev 154801)
+++ trunk/Source/WebCore/ChangeLog	2013-08-29 02:33:42 UTC (rev 154802)
@@ -1,3 +1,18 @@
+2013-08-28  Chris Fleizach  <[email protected]>
+
+        AX: WebProcess at com.apple.WebCore: WebCore::AXObjectCache::rootObject + 27
+        https://bugs.webkit.org/show_bug.cgi?id=120434
+
+        Reviewed by Darin Adler.
+
+        Crash logs indicate that there's a null pointer access in rootObject. That seems like it could only
+        happen in Document was null. 
+
+        Unfortunately, there are no reproducible steps and no other information to construct a test case.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::rootObject):
+
 2013-08-28  Ryosuke Niwa  <[email protected]>
 
         The code to look for an ancestor form element is duplicated in three different places

Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (154801 => 154802)


--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2013-08-29 01:35:21 UTC (rev 154801)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2013-08-29 02:33:42 UTC (rev 154802)
@@ -421,6 +421,9 @@
 {
     if (!gAccessibilityEnabled)
         return 0;
+
+    if (!m_document)
+        return 0;
     
     return getOrCreate(m_document->view());
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to