Title: [154905] trunk/Source/WebCore
- Revision
- 154905
- Author
- [email protected]
- Date
- 2013-08-30 12:21:31 -0700 (Fri, 30 Aug 2013)
Log Message
Make sure remove CachedResourceClient when destructing IconLoader
https://bugs.webkit.org/show_bug.cgi?id=120541
Patch by Leo Yang <[email protected]> on 2013-08-30
Reviewed by Darin Adler.
It's a good practice to call CachedResource::removeClient(client)
when the client is being destructed. We need to do this for InconLoader
to prevent m_resource from keeping dangling client in case m_resource
is referenced by someone else in the future.
Found by code inspection. Just a defensive enhancement no new tests.
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::~IconLoader):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154904 => 154905)
--- trunk/Source/WebCore/ChangeLog 2013-08-30 18:58:54 UTC (rev 154904)
+++ trunk/Source/WebCore/ChangeLog 2013-08-30 19:21:31 UTC (rev 154905)
@@ -1,3 +1,20 @@
+2013-08-30 Leo Yang <[email protected]>
+
+ Make sure remove CachedResourceClient when destructing IconLoader
+ https://bugs.webkit.org/show_bug.cgi?id=120541
+
+ Reviewed by Darin Adler.
+
+ It's a good practice to call CachedResource::removeClient(client)
+ when the client is being destructed. We need to do this for InconLoader
+ to prevent m_resource from keeping dangling client in case m_resource
+ is referenced by someone else in the future.
+
+ Found by code inspection. Just a defensive enhancement no new tests.
+
+ * loader/icon/IconLoader.cpp:
+ (WebCore::IconLoader::~IconLoader):
+
2013-08-30 Hans Muller <[email protected]>
[CSS Shapes] Redefine the ShapeIntervals class as a template
Modified: trunk/Source/WebCore/loader/icon/IconLoader.cpp (154904 => 154905)
--- trunk/Source/WebCore/loader/icon/IconLoader.cpp 2013-08-30 18:58:54 UTC (rev 154904)
+++ trunk/Source/WebCore/loader/icon/IconLoader.cpp 2013-08-30 19:21:31 UTC (rev 154905)
@@ -55,6 +55,7 @@
IconLoader::~IconLoader()
{
+ stopLoading();
}
void IconLoader::startLoading()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
