Title: [154915] trunk/Source/WebCore
- Revision
- 154915
- Author
- [email protected]
- Date
- 2013-08-30 15:51:41 -0700 (Fri, 30 Aug 2013)
Log Message
[Windows] Update to incorporate additional suggestions
https://bugs.webkit.org/show_bug.cgi?id=120448
Reviewed by Darin Adler
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Add
notes as to why AVFoundationCF needs this extra method call.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Use OVERRIDE
* rendering/RenderVideo.cpp: Replace ternary operator with logical &&.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154914 => 154915)
--- trunk/Source/WebCore/ChangeLog 2013-08-30 22:37:51 UTC (rev 154914)
+++ trunk/Source/WebCore/ChangeLog 2013-08-30 22:51:41 UTC (rev 154915)
@@ -1,5 +1,17 @@
2013-08-30 Brent Fulgham <[email protected]>
+ [Windows] Update to incorporate additional suggestions
+ https://bugs.webkit.org/show_bug.cgi?id=120448
+
+ Reviewed by Darin Adler
+
+ * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Add
+ notes as to why AVFoundationCF needs this extra method call.
+ * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Use OVERRIDE
+ * rendering/RenderVideo.cpp: Replace ternary operator with logical &&.
+
+2013-08-30 Brent Fulgham <[email protected]>
+
[Windows] Vide element in page always uses non-hw accelerated mode.
https://bugs.webkit.org/show_bug.cgi?id=120448
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (154914 => 154915)
--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2013-08-30 22:37:51 UTC (rev 154914)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2013-08-30 22:51:41 UTC (rev 154915)
@@ -960,6 +960,17 @@
setNaturalSize(IntSize(naturalSize));
}
+bool MediaPlayerPrivateAVFoundationCF::requiresImmediateCompositing() const
+{
+ // The AVFoundationCF player needs to have the root compositor available at construction time
+ // so it can attach to the rendering device. Otherwise it falls back to CPU-only mode.
+ //
+ // It would be nice if AVCFPlayer had some way to switch to hardware-accelerated mode
+ // when asked, then we could follow AVFoundation's model and switch to compositing
+ // mode when beginning to play media.
+ return true;
+}
+
#if !HAVE(AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT)
void MediaPlayerPrivateAVFoundationCF::processLegacyClosedCaptionsTracks()
{
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h (154914 => 154915)
--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h 2013-08-30 22:37:51 UTC (rev 154914)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h 2013-08-30 22:51:41 UTC (rev 154915)
@@ -85,7 +85,7 @@
virtual float platformMaxTimeLoaded() const;
virtual void beginLoadingMetadata();
virtual void sizeChanged();
- virtual bool requiresImmediateCompositing() const { return true; }
+ virtual bool requiresImmediateCompositing() const OVERRIDE;
virtual bool hasAvailableVideoFrame() const;
Modified: trunk/Source/WebCore/rendering/RenderVideo.cpp (154914 => 154915)
--- trunk/Source/WebCore/rendering/RenderVideo.cpp 2013-08-30 22:37:51 UTC (rev 154914)
+++ trunk/Source/WebCore/rendering/RenderVideo.cpp 2013-08-30 22:51:41 UTC (rev 154915)
@@ -283,8 +283,8 @@
bool RenderVideo::requiresImmediateCompositing() const
{
- MediaPlayer* p = mediaElement()->player();
- return p ? p->requiresImmediateCompositing() : false;
+ MediaPlayer* player = mediaElement()->player();
+ return player && player->requiresImmediateCompositing();
}
#if ENABLE(FULLSCREEN_API)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
