Title: [154932] trunk
- Revision
- 154932
- Author
- [email protected]
- Date
- 2013-08-31 14:05:58 -0700 (Sat, 31 Aug 2013)
Log Message
XMLSerializer-attribute-namespace-prefix-conflicts can't produce reliable results
https://bugs.webkit.org/show_bug.cgi?id=120490
Reviewed by Ryosuke Niwa.
Source/WebCore:
Retain the key of the namespaces map by using AtomicString as key instead of AtomicStringImpl*.
* editing/MarkupAccumulator.h:
LayoutTests:
Unskip these previously failing tests.
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154931 => 154932)
--- trunk/LayoutTests/ChangeLog 2013-08-31 18:34:23 UTC (rev 154931)
+++ trunk/LayoutTests/ChangeLog 2013-08-31 21:05:58 UTC (rev 154932)
@@ -1,3 +1,14 @@
+2013-08-31 Rob Buis <[email protected]>
+
+ XMLSerializer-attribute-namespace-prefix-conflicts can't produce reliable results
+ https://bugs.webkit.org/show_bug.cgi?id=120490
+
+ Reviewed by Ryosuke Niwa.
+
+ Unskip these previously failing tests.
+
+ * TestExpectations:
+
2013-08-30 Simon Fraser <[email protected]>
Fix the Mac results.
Modified: trunk/LayoutTests/TestExpectations (154931 => 154932)
--- trunk/LayoutTests/TestExpectations 2013-08-31 18:34:23 UTC (rev 154931)
+++ trunk/LayoutTests/TestExpectations 2013-08-31 21:05:58 UTC (rev 154932)
@@ -38,8 +38,3 @@
# This test will run slowly in debug mode, but is plenty fast in release.
[ Debug ] fast/js/regress/emscripten-memops.html [ Skip ]
-[ Debug ] webkit.org/b/120490 fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html [ Skip ]
-[ Debug ] webkit.org/b/120490 fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html [ Skip ]
-[ Debug ] webkit.org/b/120490 fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html [ Skip ]
-[ Debug ] webkit.org/b/120490 svg/custom/xlink-prefix-generation-in-attributes.html [ Skip ]
-
Modified: trunk/Source/WebCore/ChangeLog (154931 => 154932)
--- trunk/Source/WebCore/ChangeLog 2013-08-31 18:34:23 UTC (rev 154931)
+++ trunk/Source/WebCore/ChangeLog 2013-08-31 21:05:58 UTC (rev 154932)
@@ -1,3 +1,14 @@
+2013-08-31 Rob Buis <[email protected]>
+
+ XMLSerializer-attribute-namespace-prefix-conflicts can't produce reliable results
+ https://bugs.webkit.org/show_bug.cgi?id=120490
+
+ Reviewed by Ryosuke Niwa.
+
+ Retain the key of the namespaces map by using AtomicString as key instead of AtomicStringImpl*.
+
+ * editing/MarkupAccumulator.h:
+
2013-08-31 Andreas Kling <[email protected]>
InlineBox::renderer() and pals should return references.
Modified: trunk/Source/WebCore/editing/MarkupAccumulator.h (154931 => 154932)
--- trunk/Source/WebCore/editing/MarkupAccumulator.h 2013-08-31 18:34:23 UTC (rev 154931)
+++ trunk/Source/WebCore/editing/MarkupAccumulator.h 2013-08-31 21:05:58 UTC (rev 154932)
@@ -39,7 +39,7 @@
class Node;
class Range;
-typedef HashMap<AtomicStringImpl*, AtomicStringImpl*> Namespaces;
+typedef HashMap<AtomicString, AtomicStringImpl*> Namespaces;
enum EntityMask {
EntityAmp = 0x0001,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
