Title: [155000] trunk/Tools
- Revision
- 155000
- Author
- [email protected]
- Date
- 2013-09-03 14:47:45 -0700 (Tue, 03 Sep 2013)
Log Message
[Mac] WebKitTestRunner still beeps sometimes
https://bugs.webkit.org/show_bug.cgi?id=120652
Reviewed by Tim Horton.
In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
UI process (notably, AppKit beeps when handling a key equivalent returns NO).
* WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
Use the same SPI that we use in DRT and in WebProcess to disable beeping.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (154999 => 155000)
--- trunk/Tools/ChangeLog 2013-09-03 21:36:32 UTC (rev 154999)
+++ trunk/Tools/ChangeLog 2013-09-03 21:47:45 UTC (rev 155000)
@@ -1,3 +1,16 @@
+2013-09-03 Alexey Proskuryakov <[email protected]>
+
+ [Mac] WebKitTestRunner still beeps sometimes
+ https://bugs.webkit.org/show_bug.cgi?id=120652
+
+ Reviewed by Tim Horton.
+
+ In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
+ UI process (notably, AppKit beeps when handling a key equivalent returns NO).
+
+ * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
+ Use the same SPI that we use in DRT and in WebProcess to disable beeping.
+
2013-09-03 Krzysztof Czech <[email protected]>
[AX][ATK] Added support for sort and help attributes
Modified: trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm (154999 => 155000)
--- trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm 2013-09-03 21:36:32 UTC (rev 154999)
+++ trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm 2013-09-03 21:47:45 UTC (rev 155000)
@@ -32,6 +32,10 @@
#import <WebKit2/WKStringCF.h>
#import <mach-o/dyld.h>
+@interface NSSound (Details)
++ (void)_setAlertType:(NSUInteger)alertType;
+@end
+
namespace WTR {
void TestController::notifyDone()
@@ -42,6 +46,8 @@
{
poseAsClass("WebKitTestRunnerPasteboard", "NSPasteboard");
poseAsClass("WebKitTestRunnerEvent", "NSEvent");
+
+ [NSSound _setAlertType:0];
}
void TestController::platformDestroy()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
