Title: [155095] trunk/Source/WebCore
Revision
155095
Author
[email protected]
Date
2013-09-04 23:29:50 -0700 (Wed, 04 Sep 2013)

Log Message

Remove deprecated markersForNode(Node* node).
https://bugs.webkit.org/show_bug.cgi?id=120679

Reviewed by Ryosuke Niwa.

DocumentMarkerController::markersForNode(Node* node) has been marked as
deprecated in favor of markersFor(Node*, MarkerTypes = AllMarkers()).

No new tests, no behavior change.

* dom/DocumentMarkerController.cpp:
* dom/DocumentMarkerController.h:
Remove never used markersForNode(Node*).

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (155094 => 155095)


--- trunk/Source/WebCore/ChangeLog	2013-09-05 06:20:09 UTC (rev 155094)
+++ trunk/Source/WebCore/ChangeLog	2013-09-05 06:29:50 UTC (rev 155095)
@@ -1,3 +1,19 @@
+2013-09-04  Grzegorz Czajkowski  <[email protected]>
+
+        Remove deprecated markersForNode(Node* node).
+        https://bugs.webkit.org/show_bug.cgi?id=120679
+
+        Reviewed by Ryosuke Niwa.
+
+        DocumentMarkerController::markersForNode(Node* node) has been marked as
+        deprecated in favor of markersFor(Node*, MarkerTypes = AllMarkers()).
+
+        No new tests, no behavior change.
+
+        * dom/DocumentMarkerController.cpp:
+        * dom/DocumentMarkerController.h:
+        Remove never used markersForNode(Node*).
+
 2013-09-04  Andreas Kling  <[email protected]>
 
         CachedPage construction should begin with a Page&.

Modified: trunk/Source/WebCore/dom/DocumentMarkerController.cpp (155094 => 155095)


--- trunk/Source/WebCore/dom/DocumentMarkerController.cpp	2013-09-05 06:20:09 UTC (rev 155094)
+++ trunk/Source/WebCore/dom/DocumentMarkerController.cpp	2013-09-05 06:29:50 UTC (rev 155095)
@@ -334,20 +334,6 @@
     return result;
 }
 
-// FIXME: Should be removed after all relevant patches are landed
-Vector<DocumentMarker> DocumentMarkerController::markersForNode(Node* node)
-{
-    Vector<DocumentMarker> result;
-    MarkerList* list = m_markers.get(node);
-    if (!list)
-        return result;
-
-    for (size_t i = 0; i < list->size(); ++i)
-        result.append(list->at(i));
-
-    return result;
-}
-
 Vector<DocumentMarker*> DocumentMarkerController::markersInRange(Range* range, DocumentMarker::MarkerTypes markerTypes)
 {
     if (!possiblyHasMarkers(markerTypes))

Modified: trunk/Source/WebCore/dom/DocumentMarkerController.h (155094 => 155095)


--- trunk/Source/WebCore/dom/DocumentMarkerController.h	2013-09-05 06:20:09 UTC (rev 155094)
+++ trunk/Source/WebCore/dom/DocumentMarkerController.h	2013-09-05 06:29:50 UTC (rev 155095)
@@ -80,7 +80,6 @@
     DocumentMarker* markerContainingPoint(const LayoutPoint&, DocumentMarker::MarkerType);
     Vector<DocumentMarker*> markersFor(Node*, DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
     Vector<DocumentMarker*> markersInRange(Range*, DocumentMarker::MarkerTypes);
-    Vector<DocumentMarker> markersForNode(Node*);
     Vector<IntRect> renderedRectsForMarkers(DocumentMarker::MarkerType);
     void clearDescriptionOnMarkersIntersectingRange(Range*, DocumentMarker::MarkerTypes);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to