Title: [155101] trunk/Tools
- Revision
- 155101
- Author
- [email protected]
- Date
- 2013-09-05 00:18:58 -0700 (Thu, 05 Sep 2013)
Log Message
Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
* Scripts/run-_javascript_core-tests:
(readAllLines):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (155100 => 155101)
--- trunk/Tools/ChangeLog 2013-09-05 06:50:05 UTC (rev 155100)
+++ trunk/Tools/ChangeLog 2013-09-05 07:18:58 UTC (rev 155101)
@@ -1,3 +1,10 @@
+2013-09-05 Filip Pizlo <[email protected]>
+
+ Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
+
+ * Scripts/run-_javascript_core-tests:
+ (readAllLines):
+
2013-09-04 Filip Pizlo <[email protected]>
jsc tests should have timeouts
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (155100 => 155101)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 06:50:05 UTC (rev 155100)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2013-09-05 07:18:58 UTC (rev 155101)
@@ -31,7 +31,6 @@
# as well as other tests: testapi on Mac and LayoutTests/fast/js.
use strict;
-use File::Slurp;
use FindBin;
use Getopt::Long qw(:config pass_through);
use List::Util qw(min max);
@@ -216,6 +215,20 @@
}
}
+sub readAllLines
+{
+ my ($filename) = @_;
+ my @array = ();
+ eval {
+ open FILE, $filename or die;
+ while (<FILE>) {
+ push @array, $_;
+ }
+ close FILE;
+ };
+ return @array;
+}
+
sub printThingsFound
{
my ($number, $label, $pluralLabel, $verb) = @_;
@@ -228,8 +241,8 @@
print " $verb.\n";
}
-my @fastJSFailList = eval { read_file($fastJSResultsDir . "/failed") };
-my @fastJSCrashList = eval { read_file($fastJSResultsDir . "/crashed") };
+my @fastJSFailList = readAllLines($fastJSResultsDir . "/failed");
+my @fastJSCrashList = readAllLines($fastJSResultsDir . "/crashed");
my $numJSFailures = @fastJSFailList;
my $numJSCrashes = @fastJSCrashList;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
