Diff
Modified: trunk/Source/WebCore/ChangeLog (155129 => 155130)
--- trunk/Source/WebCore/ChangeLog 2013-09-05 17:35:59 UTC (rev 155129)
+++ trunk/Source/WebCore/ChangeLog 2013-09-05 17:54:11 UTC (rev 155130)
@@ -1,3 +1,16 @@
+2013-09-05 Brent Fulgham <[email protected]>
+
+ [Windows] Unreviewed build/link improvement after r155127 to be
+ consistent about using debug-build support libraries.
+
+ Now that <rdar://problem/9898937> is resolved, we should be linking
+ to debug AVFoundationCF as well.
+
+ * page/CaptionUserPreferencesMediaAF.cpp: Link to AVFoundationCF_debug
+ when building with the DEBUG_ALL target.
+ * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Ditto.
+ * platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Ditto.
+
2013-09-04 Anders Carlsson <[email protected]>
Vector::releaseBuffer should return an OwnPtr
Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp (155129 => 155130)
--- trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2013-09-05 17:35:59 UTC (rev 155129)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2013-09-05 17:54:11 UTC (rev 155130)
@@ -65,7 +65,13 @@
#define SOFT_LINK_AVF_POINTER(Lib, Name, Type) SOFT_LINK_POINTER_OPTIONAL(Lib, Name, Type)
#define SOFT_LINK_AVF_FRAMEWORK_IMPORT(Lib, Fun, ReturnType, Arguments, Signature) SOFT_LINK(Lib, Fun, ReturnType, Arguments, Signature)
#else
+
+#ifdef DEBUG_ALL
+#define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_DEBUG_LIBRARY(Lib)
+#else
#define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_LIBRARY(Lib)
+#endif
+
#define SOFT_LINK_AVF(Lib, Name, Type) SOFT_LINK_DLL_IMPORT(Lib, Name, Type)
#define SOFT_LINK_AVF_POINTER(Lib, Name, Type) SOFT_LINK_VARIABLE_DLL_IMPORT_OPTIONAL(Lib, Name, Type)
#define SOFT_LINK_AVF_FRAMEWORK_IMPORT(Lib, Fun, ReturnType, Arguments, Signature) SOFT_LINK_DLL_IMPORT(Lib, Fun, ReturnType, __cdecl, Arguments, Signature)
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp (155129 => 155130)
--- trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp 2013-09-05 17:35:59 UTC (rev 155129)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp 2013-09-05 17:54:11 UTC (rev 155130)
@@ -42,7 +42,12 @@
#define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_FRAMEWORK_OPTIONAL(Lib)
#define SOFT_LINK_AVF_POINTER(Lib, Name, Type) SOFT_LINK_POINTER_OPTIONAL(Lib, Name, Type)
#else
+#ifdef DEBUG_ALL
+#define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_DEBUG_LIBRARY(Lib)
+#else
#define SOFT_LINK_AVF_FRAMEWORK(Lib) SOFT_LINK_LIBRARY(Lib)
+#endif
+
#define SOFT_LINK_AVF_POINTER(Lib, Name, Type) SOFT_LINK_VARIABLE_DLL_IMPORT_OPTIONAL(Lib, Name, Type)
#endif
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h (155129 => 155130)
--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h 2013-09-05 17:35:59 UTC (rev 155129)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h 2013-09-05 17:54:11 UTC (rev 155130)
@@ -28,8 +28,7 @@
// Soft-link against AVFoundationCF functions and variables required by MediaPlayerPrivateAVFoundationCF.cpp.
#ifdef DEBUG_ALL
-// FIXME: <rdar://problem/9898937> AVFoundationCF doesn't currently deliver a debug library.
-SOFT_LINK_LIBRARY(AVFoundationCF)
+SOFT_LINK_DEBUG_LIBRARY(AVFoundationCF)
#else
SOFT_LINK_LIBRARY(AVFoundationCF)
#endif
Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp (155129 => 155130)
--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp 2013-09-05 17:35:59 UTC (rev 155129)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp 2013-09-05 17:54:11 UTC (rev 155130)
@@ -1009,7 +1009,11 @@
bool MediaPlayerPrivateQuickTimeVisualContext::isAvailable()
{
+#ifdef DEBUG_ALL
+ return false;
+#else
return QTMovie::initializeQuickTime();
+#endif
}
MediaPlayer::SupportsType MediaPlayerPrivateQuickTimeVisualContext::supportsType(const String& type, const String& codecs, const KURL&)
