Title: [155196] trunk/Tools
- Revision
- 155196
- Author
- [email protected]
- Date
- 2013-09-06 11:11:41 -0700 (Fri, 06 Sep 2013)
Log Message
Lots of pixel tests are failing on first run, so tests cannot finish
https://bugs.webkit.org/show_bug.cgi?id=120755
Reviewed by Ryosuke Niwa.
For whatever reason, many reftests are color profile sensitive, and we only set
color profile to a known one for pixel tests, not for reftests.
Pixel testing mode is also enabled when retrying tests, so these failures used to
be essentially hidden - the tests were "flaky", but that was not reported loudly enough.
But now, so many tests fail that it makes run-webkit-tests stop early, and never retry.
This probably shouldn't happen, as reftests should not be color profile sensitive.
The fix is a stopgap measure to unblock EWS until a better fix can be investigated.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run): Roll out <http://trac.webkit.org/changeset/115601>.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (155195 => 155196)
--- trunk/Tools/ChangeLog 2013-09-06 17:33:44 UTC (rev 155195)
+++ trunk/Tools/ChangeLog 2013-09-06 18:11:41 UTC (rev 155196)
@@ -1,3 +1,23 @@
+2013-09-06 Alexey Proskuryakov <[email protected]>
+
+ Lots of pixel tests are failing on first run, so tests cannot finish
+ https://bugs.webkit.org/show_bug.cgi?id=120755
+
+ Reviewed by Ryosuke Niwa.
+
+ For whatever reason, many reftests are color profile sensitive, and we only set
+ color profile to a known one for pixel tests, not for reftests.
+
+ Pixel testing mode is also enabled when retrying tests, so these failures used to
+ be essentially hidden - the tests were "flaky", but that was not reported loudly enough.
+ But now, so many tests fail that it makes run-webkit-tests stop early, and never retry.
+
+ This probably shouldn't happen, as reftests should not be color profile sensitive.
+ The fix is a stopgap measure to unblock EWS until a better fix can be investigated.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager._set_up_run): Roll out <http://trac.webkit.org/changeset/115601>.
+
2013-09-06 Denis Nomiyama <[email protected]>
[GTK] AccessibilityUIElement::addNotificationListener() crashes on debug build
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (155195 => 155196)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2013-09-06 17:33:44 UTC (rev 155195)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2013-09-06 18:11:41 UTC (rev 155196)
@@ -149,9 +149,8 @@
# This must be started before we check the system dependencies,
# since the helper may do things to make the setup correct.
- if self._options.pixel_tests:
- self._printer.write_update("Starting pixel test helper ...")
- self._port.start_helper()
+ self._printer.write_update("Starting pixel test helper ...")
+ self._port.start_helper()
# Check that the system dependencies (themes, fonts, ...) are correct.
if not self._options.nocheck_sys_deps:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
