Title: [155235] trunk/Tools
Revision
155235
Author
[email protected]
Date
2013-09-06 21:40:50 -0700 (Fri, 06 Sep 2013)

Log Message

Unreviewed, rolling out r155196.
http://trac.webkit.org/changeset/155196
https://bugs.webkit.org/show_bug.cgi?id=120919

Broke 16 tests on build.webkit.org (Requested by rniwa on
#webkit).

Patch by Commit Queue <[email protected]> on 2013-09-06

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (155234 => 155235)


--- trunk/Tools/ChangeLog	2013-09-07 04:15:35 UTC (rev 155234)
+++ trunk/Tools/ChangeLog	2013-09-07 04:40:50 UTC (rev 155235)
@@ -1,3 +1,15 @@
+2013-09-06  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r155196.
+        http://trac.webkit.org/changeset/155196
+        https://bugs.webkit.org/show_bug.cgi?id=120919
+
+        Broke 16 tests on build.webkit.org (Requested by rniwa on
+        #webkit).
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        (Manager._set_up_run):
+
 2013-09-06  Filip Pizlo  <[email protected]>
 
         The 'failed' file should report collectionName/testName rather than just

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (155234 => 155235)


--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2013-09-07 04:15:35 UTC (rev 155234)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2013-09-07 04:40:50 UTC (rev 155235)
@@ -149,8 +149,9 @@
 
         # This must be started before we check the system dependencies,
         # since the helper may do things to make the setup correct.
-        self._printer.write_update("Starting pixel test helper ...")
-        self._port.start_helper()
+        if self._options.pixel_tests:
+            self._printer.write_update("Starting pixel test helper ...")
+            self._port.start_helper()
 
         # Check that the system dependencies (themes, fonts, ...) are correct.
         if not self._options.nocheck_sys_deps:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to