Diff
Modified: trunk/LayoutTests/ChangeLog (155336 => 155337)
--- trunk/LayoutTests/ChangeLog 2013-09-09 09:25:43 UTC (rev 155336)
+++ trunk/LayoutTests/ChangeLog 2013-09-09 09:39:34 UTC (rev 155337)
@@ -1,3 +1,15 @@
+2013-09-09 Krzysztof Czech <[email protected]>
+
+ [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
+ https://bugs.webkit.org/show_bug.cgi?id=121023
+
+ Reviewed by Mario Sanchez Prada.
+
+ Sharing progressbar.html specific mac test with efl and gtk.
+
+ * accessibility/progressbar-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/progressbar-expected.txt.
+ * accessibility/progressbar.html: Renamed from LayoutTests/platform/mac/accessibility/progressbar.html.
+
2013-09-08 Gurpreet Kaur <[email protected]>
defining line height affects height of text box
Copied: trunk/LayoutTests/accessibility/progressbar-expected.txt (from rev 155329, trunk/LayoutTests/platform/mac/accessibility/progressbar-expected.txt) (0 => 155337)
--- trunk/LayoutTests/accessibility/progressbar-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/progressbar-expected.txt 2013-09-09 09:39:34 UTC (rev 155337)
@@ -0,0 +1,16 @@
+X X
+This test makes sure that progress element can be accessed by Accessibility FW.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS obj.intValue is 7
+PASS obj.intValue is 0
+PASS obj.intValue is 7
+PASS obj.role is 'AXRole: AXProgressIndicator'
+PASS obj.intValue is 0
+PASS obj.role is 'AXRole: AXProgressIndicator'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/accessibility/progressbar.html (from rev 155329, trunk/LayoutTests/platform/mac/accessibility/progressbar.html) (0 => 155337)
--- trunk/LayoutTests/accessibility/progressbar.html (rev 0)
+++ trunk/LayoutTests/accessibility/progressbar.html 2013-09-09 09:39:34 UTC (rev 155337)
@@ -0,0 +1,54 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+<span tabindex="0" role="progressbar" id="progressbar1" aria-valuenow=7 aria-valuemin=0 aria-valuemax=10>X</span>
+<span tabindex="0" role="progressbar" id="progressbar2" aria-valuemax=10>X</span>
+
+<progress tabindex="0" id="progressbar3" value=7 max=10></progress>
+<progress tabindex="0" id="progressbar4"></progress>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This test makes sure that progress element can be accessed by Accessibility FW.");
+
+ if (window.accessibilityController) {
+
+ // ARIA determinate progressbar
+ document.getElementById("progressbar1").focus();
+ var obj = accessibilityController.focusedElement;
+
+ shouldBe("obj.intValue", "7");
+
+ // ARIA indeterminate progressbar
+ document.getElementById("progressbar2").focus();
+ var obj = accessibilityController.focusedElement;
+
+ shouldBe("obj.intValue", "0");
+
+ // determinate progress element
+ document.getElementById("progressbar3").focus();
+ var obj = accessibilityController.focusedElement;
+
+ shouldBe("obj.intValue", "7");
+ shouldBe("obj.role", "'AXRole: AXProgressIndicator'");
+
+ // indeterminate progress element
+ document.getElementById("progressbar4").focus();
+ var obj = accessibilityController.focusedElement;
+
+ shouldBe("obj.intValue", "0");
+ shouldBe("obj.role", "'AXRole: AXProgressIndicator'");
+ }
+
+</script>
+
+<script src=""
+</body>
+</html>
Deleted: trunk/LayoutTests/platform/mac/accessibility/progressbar-expected.txt (155336 => 155337)
--- trunk/LayoutTests/platform/mac/accessibility/progressbar-expected.txt 2013-09-09 09:25:43 UTC (rev 155336)
+++ trunk/LayoutTests/platform/mac/accessibility/progressbar-expected.txt 2013-09-09 09:39:34 UTC (rev 155337)
@@ -1,16 +0,0 @@
-X X
-This test makes sure that progress element can be accessed by Accessibility FW.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS obj.intValue is 7
-PASS obj.intValue is 0
-PASS obj.intValue is 7
-PASS obj.role is 'AXRole: AXProgressIndicator'
-PASS obj.intValue is 0
-PASS obj.role is 'AXRole: AXProgressIndicator'
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/platform/mac/accessibility/progressbar.html (155336 => 155337)
--- trunk/LayoutTests/platform/mac/accessibility/progressbar.html 2013-09-09 09:25:43 UTC (rev 155336)
+++ trunk/LayoutTests/platform/mac/accessibility/progressbar.html 2013-09-09 09:39:34 UTC (rev 155337)
@@ -1,54 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-<body id="body">
-
-<span tabindex="0" role="progressbar" id="progressbar1" aria-valuenow=7 aria-valuemin=0 aria-valuemax=10>X</span>
-<span tabindex="0" role="progressbar" id="progressbar2" aria-valuemax=10>X</span>
-
-<progress tabindex="0" id="progressbar3" value=7 max=10></progress>
-<progress tabindex="0" id="progressbar4"></progress>
-
-<p id="description"></p>
-<div id="console"></div>
-
-<script>
-
- description("This test makes sure that progress element can be accessed by Accessibility FW.");
-
- if (window.accessibilityController) {
-
- // ARIA determinate progressbar
- document.getElementById("progressbar1").focus();
- var obj = accessibilityController.focusedElement;
-
- shouldBe("obj.intValue", "7");
-
- // ARIA indeterminate progressbar
- document.getElementById("progressbar2").focus();
- var obj = accessibilityController.focusedElement;
-
- shouldBe("obj.intValue", "0");
-
- // determinate progress element
- document.getElementById("progressbar3").focus();
- var obj = accessibilityController.focusedElement;
-
- shouldBe("obj.intValue", "7");
- shouldBe("obj.role", "'AXRole: AXProgressIndicator'");
-
- // indeterminate progress element
- document.getElementById("progressbar4").focus();
- var obj = accessibilityController.focusedElement;
-
- shouldBe("obj.intValue", "0");
- shouldBe("obj.role", "'AXRole: AXProgressIndicator'");
- }
-
-</script>
-
-<script src=""
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (155336 => 155337)
--- trunk/Source/WebCore/ChangeLog 2013-09-09 09:25:43 UTC (rev 155336)
+++ trunk/Source/WebCore/ChangeLog 2013-09-09 09:39:34 UTC (rev 155337)
@@ -1,3 +1,17 @@
+2013-09-09 Krzysztof Czech <[email protected]>
+
+ [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
+ https://bugs.webkit.org/show_bug.cgi?id=121023
+
+ Reviewed by Mario Sanchez Prada.
+
+ Test: accessibility/progressbar.html
+
+ ProgressBar element should support ATK_VALUE interface.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (getInterfaceMaskFromObject):
+
2013-09-09 Claudio Saavedra <[email protected]>
[GTK] ghost cursor when mouse hovers over an image file in a tab
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (155336 => 155337)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-09-09 09:25:43 UTC (rev 155336)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-09-09 09:39:34 UTC (rev 155337)
@@ -1033,7 +1033,7 @@
interfaceMask |= 1 << WAI_DOCUMENT;
// Value
- if (role == SliderRole || role == SpinButtonRole || role == ScrollBarRole)
+ if (role == SliderRole || role == SpinButtonRole || role == ScrollBarRole || role == ProgressIndicatorRole)
interfaceMask |= 1 << WAI_VALUE;
#if ENABLE(INPUT_TYPE_COLOR)
Modified: trunk/Tools/ChangeLog (155336 => 155337)
--- trunk/Tools/ChangeLog 2013-09-09 09:25:43 UTC (rev 155336)
+++ trunk/Tools/ChangeLog 2013-09-09 09:39:34 UTC (rev 155337)
@@ -1,3 +1,17 @@
+2013-09-09 Krzysztof Czech <[email protected]>
+
+ [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
+ https://bugs.webkit.org/show_bug.cgi?id=121023
+
+ Reviewed by Mario Sanchez Prada.
+
+ Added mappings to ATK's ProgressBar element.
+
+ * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+ (roleToString):
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::roleToString):
+
2013-09-08 Filip Pizlo <[email protected]>
run-jsc-stress-tests should be more paranoid about calling make
Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (155336 => 155337)
--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-09-09 09:25:43 UTC (rev 155336)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-09-09 09:39:34 UTC (rev 155337)
@@ -152,6 +152,8 @@
return "AXParagraph";
case ATK_ROLE_PASSWORD_TEXT:
return "AXPasswordField";
+ case ATK_ROLE_PROGRESS_BAR:
+ return "AXProgressIndicator";
case ATK_ROLE_PUSH_BUTTON:
return "AXButton";
case ATK_ROLE_RADIO_BUTTON:
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (155336 => 155337)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-09-09 09:25:43 UTC (rev 155336)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-09-09 09:39:34 UTC (rev 155337)
@@ -241,6 +241,8 @@
return "AXParagraph";
case ATK_ROLE_PASSWORD_TEXT:
return "AXPasswordField";
+ case ATK_ROLE_PROGRESS_BAR:
+ return "AXProgressIndicator";
case ATK_ROLE_PUSH_BUTTON:
return "AXButton";
case ATK_ROLE_RADIO_BUTTON:
