Title: [155346] trunk/Source/WebCore
- Revision
- 155346
- Author
- [email protected]
- Date
- 2013-09-09 06:47:24 -0700 (Mon, 09 Sep 2013)
Log Message
Adding username to RTCIceServer
https://bugs.webkit.org/show_bug.cgi?id=120861
Patch by Thiago de Barros Lacerda <[email protected]> on 2013-09-09
Reviewed by Eric Carlson.
No new tests needed. Existing media stream tests already cover it
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::parseConfiguration):
* platform/mediastream/RTCConfiguration.h:
(WebCore::RTCIceServer::create):
(WebCore::RTCIceServer::username):
(WebCore::RTCIceServer::RTCIceServer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (155345 => 155346)
--- trunk/Source/WebCore/ChangeLog 2013-09-09 13:05:26 UTC (rev 155345)
+++ trunk/Source/WebCore/ChangeLog 2013-09-09 13:47:24 UTC (rev 155346)
@@ -1,3 +1,19 @@
+2013-09-09 Thiago de Barros Lacerda <[email protected]>
+
+ Adding username to RTCIceServer
+ https://bugs.webkit.org/show_bug.cgi?id=120861
+
+ Reviewed by Eric Carlson.
+
+ No new tests needed. Existing media stream tests already cover it
+
+ * Modules/mediastream/RTCPeerConnection.cpp:
+ (WebCore::RTCPeerConnection::parseConfiguration):
+ * platform/mediastream/RTCConfiguration.h:
+ (WebCore::RTCIceServer::create):
+ (WebCore::RTCIceServer::username):
+ (WebCore::RTCIceServer::RTCIceServer):
+
2013-09-09 Antti Koivisto <[email protected]>
Hide Document::renderer()
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (155345 => 155346)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2013-09-09 13:05:26 UTC (rev 155345)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2013-09-09 13:47:24 UTC (rev 155346)
@@ -93,7 +93,7 @@
return 0;
}
- String urlString, credential;
+ String urlString, credential, username;
ok = iceServer.get("url", urlString);
if (!ok) {
ec = TYPE_MISMATCH_ERR;
@@ -106,8 +106,9 @@
}
iceServer.get("credential", credential);
+ iceServer.get("username", username);
- rtcConfiguration->appendServer(RTCIceServer::create(url, credential));
+ rtcConfiguration->appendServer(RTCIceServer::create(url, credential, username));
}
return rtcConfiguration.release();
Modified: trunk/Source/WebCore/platform/mediastream/RTCConfiguration.h (155345 => 155346)
--- trunk/Source/WebCore/platform/mediastream/RTCConfiguration.h 2013-09-09 13:05:26 UTC (rev 155345)
+++ trunk/Source/WebCore/platform/mediastream/RTCConfiguration.h 2013-09-09 13:47:24 UTC (rev 155346)
@@ -43,24 +43,27 @@
class RTCIceServer : public RefCounted<RTCIceServer> {
public:
- static PassRefPtr<RTCIceServer> create(const KURL& uri, const String& credential)
+ static PassRefPtr<RTCIceServer> create(const KURL& uri, const String& credential, const String& username)
{
- return adoptRef(new RTCIceServer(uri, credential));
+ return adoptRef(new RTCIceServer(uri, credential, username));
}
virtual ~RTCIceServer() { }
const KURL& uri() { return m_uri; }
const String& credential() { return m_credential; }
+ const String& username() { return m_username; }
private:
- RTCIceServer(const KURL& uri, const String& credential)
+ RTCIceServer(const KURL& uri, const String& credential, const String& username)
: m_uri(uri)
, m_credential(credential)
+ , m_username(username)
{
}
KURL m_uri;
String m_credential;
+ String m_username;
};
class RTCConfiguration : public RefCounted<RTCConfiguration> {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
