Title: [156131] trunk/Source/WebCore
- Revision
- 156131
- Author
- [email protected]
- Date
- 2013-09-19 17:22:53 -0700 (Thu, 19 Sep 2013)
Log Message
Out-of-line InspectorValues create() methods.
<https://webkit.org/b/121639>
Reviewed by Joseph Pecoraro.
These functions are hardly performance-critical and are taking up
quite a lot of space.
Shrinks the WebCore binary by 70500 bytes.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (156130 => 156131)
--- trunk/Source/WebCore/ChangeLog 2013-09-19 23:19:56 UTC (rev 156130)
+++ trunk/Source/WebCore/ChangeLog 2013-09-20 00:22:53 UTC (rev 156131)
@@ -1,3 +1,15 @@
+2013-09-19 Andreas Kling <[email protected]>
+
+ Out-of-line InspectorValues create() methods.
+ <https://webkit.org/b/121639>
+
+ Reviewed by Joseph Pecoraro.
+
+ These functions are hardly performance-critical and are taking up
+ quite a lot of space.
+
+ Shrinks the WebCore binary by 70500 bytes.
+
2013-09-19 Alexey Proskuryakov <[email protected]>
Layout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is flaky
Modified: trunk/Source/WebCore/inspector/InspectorValues.cpp (156130 => 156131)
--- trunk/Source/WebCore/inspector/InspectorValues.cpp 2013-09-19 23:19:56 UTC (rev 156130)
+++ trunk/Source/WebCore/inspector/InspectorValues.cpp 2013-09-20 00:22:53 UTC (rev 156131)
@@ -793,4 +793,44 @@
return m_data[index];
}
+PassRefPtr<InspectorObject> InspectorObject::create()
+{
+ return adoptRef(new InspectorObject);
+}
+
+PassRefPtr<InspectorArray> InspectorArray::create()
+{
+ return adoptRef(new InspectorArray);
+}
+
+PassRefPtr<InspectorValue> InspectorValue::null()
+{
+ return adoptRef(new InspectorValue);
+}
+
+PassRefPtr<InspectorString> InspectorString::create(const String& value)
+{
+ return adoptRef(new InspectorString(value));
+}
+
+PassRefPtr<InspectorString> InspectorString::create(const char* value)
+{
+ return adoptRef(new InspectorString(value));
+}
+
+PassRefPtr<InspectorBasicValue> InspectorBasicValue::create(bool value)
+{
+ return adoptRef(new InspectorBasicValue(value));
+}
+
+PassRefPtr<InspectorBasicValue> InspectorBasicValue::create(int value)
+{
+ return adoptRef(new InspectorBasicValue(value));
+}
+
+PassRefPtr<InspectorBasicValue> InspectorBasicValue::create(double value)
+{
+ return adoptRef(new InspectorBasicValue(value));
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/inspector/InspectorValues.h (156130 => 156131)
--- trunk/Source/WebCore/inspector/InspectorValues.h 2013-09-19 23:19:56 UTC (rev 156130)
+++ trunk/Source/WebCore/inspector/InspectorValues.h 2013-09-20 00:22:53 UTC (rev 156131)
@@ -50,10 +50,7 @@
InspectorValue() : m_type(TypeNull) { }
virtual ~InspectorValue() { }
- static PassRefPtr<InspectorValue> null()
- {
- return adoptRef(new InspectorValue());
- }
+ static PassRefPtr<InspectorValue> null();
typedef enum {
TypeNull = 0,
@@ -96,21 +93,10 @@
class InspectorBasicValue : public InspectorValue {
public:
- static PassRefPtr<InspectorBasicValue> create(bool value)
- {
- return adoptRef(new InspectorBasicValue(value));
- }
+ static PassRefPtr<InspectorBasicValue> create(bool);
+ static PassRefPtr<InspectorBasicValue> create(int);
+ static PassRefPtr<InspectorBasicValue> create(double);
- static PassRefPtr<InspectorBasicValue> create(int value)
- {
- return adoptRef(new InspectorBasicValue(value));
- }
-
- static PassRefPtr<InspectorBasicValue> create(double value)
- {
- return adoptRef(new InspectorBasicValue(value));
- }
-
virtual bool asBoolean(bool* output) const;
virtual bool asNumber(double* output) const;
virtual bool asNumber(long* output) const;
@@ -133,16 +119,9 @@
class InspectorString : public InspectorValue {
public:
- static PassRefPtr<InspectorString> create(const String& value)
- {
- return adoptRef(new InspectorString(value));
- }
+ static PassRefPtr<InspectorString> create(const String&);
+ static PassRefPtr<InspectorString> create(const char*);
- static PassRefPtr<InspectorString> create(const char* value)
- {
- return adoptRef(new InspectorString(value));
- }
-
virtual bool asString(String* output) const;
virtual void writeJSON(StringBuilder* output) const;
@@ -213,10 +192,7 @@
class InspectorObject : public InspectorObjectBase {
public:
- static PassRefPtr<InspectorObject> create()
- {
- return adoptRef(new InspectorObject());
- }
+ static PassRefPtr<InspectorObject> create();
using InspectorObjectBase::asObject;
@@ -284,10 +260,7 @@
class InspectorArray : public InspectorArrayBase {
public:
- static PassRefPtr<InspectorArray> create()
- {
- return adoptRef(new InspectorArray());
- }
+ static PassRefPtr<InspectorArray> create();
using InspectorArrayBase::asArray;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
