Title: [156255] trunk/Source/WebCore
- Revision
- 156255
- Author
- [email protected]
- Date
- 2013-09-22 19:59:16 -0700 (Sun, 22 Sep 2013)
Log Message
Fix functions calling to RenderObject superclass to call RenderElement instead
https://bugs.webkit.org/show_bug.cgi?id=121773
Reviewed by Andreas Kling.
The class hierarchy has a new class. Superclass calls should be pointed there instead to
avoid future bugs.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::setSelectionState):
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleWillChange):
(WebCore::RenderLayerModelObject::styleDidChange):
* rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::styleDidChange):
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::styleWillChange):
(WebCore::RenderSVGModelObject::styleDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (156254 => 156255)
--- trunk/Source/WebCore/ChangeLog 2013-09-23 02:35:38 UTC (rev 156254)
+++ trunk/Source/WebCore/ChangeLog 2013-09-23 02:59:16 UTC (rev 156255)
@@ -1,5 +1,26 @@
2013-09-22 Antti Koivisto <[email protected]>
+ Fix functions calling to RenderObject superclass to call RenderElement instead
+ https://bugs.webkit.org/show_bug.cgi?id=121773
+
+ Reviewed by Andreas Kling.
+
+ The class hierarchy has a new class. Superclass calls should be pointed there instead to
+ avoid future bugs.
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::setSelectionState):
+ * rendering/RenderLayerModelObject.cpp:
+ (WebCore::RenderLayerModelObject::styleWillChange):
+ (WebCore::RenderLayerModelObject::styleDidChange):
+ * rendering/svg/RenderSVGGradientStop.cpp:
+ (WebCore::RenderSVGGradientStop::styleDidChange):
+ * rendering/svg/RenderSVGModelObject.cpp:
+ (WebCore::RenderSVGModelObject::styleWillChange):
+ (WebCore::RenderSVGModelObject::styleDidChange):
+
+2013-09-22 Antti Koivisto <[email protected]>
+
Remove RenderObjectChildList
https://bugs.webkit.org/show_bug.cgi?id=121771
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (156254 => 156255)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2013-09-23 02:35:38 UTC (rev 156254)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2013-09-23 02:59:16 UTC (rev 156255)
@@ -78,9 +78,9 @@
if ((state == SelectionStart && selectionState() == SelectionEnd)
|| (state == SelectionEnd && selectionState() == SelectionStart))
- RenderObject::setSelectionState(SelectionBoth);
+ RenderLayerModelObject::setSelectionState(SelectionBoth);
else
- RenderObject::setSelectionState(state);
+ RenderLayerModelObject::setSelectionState(state);
// FIXME: We should consider whether it is OK propagating to ancestor RenderInlines.
// This is a workaround for http://webkit.org/b/32123
Modified: trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp (156254 => 156255)
--- trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp 2013-09-23 02:35:38 UTC (rev 156254)
+++ trunk/Source/WebCore/rendering/RenderLayerModelObject.cpp 2013-09-23 02:59:16 UTC (rev 156255)
@@ -131,12 +131,12 @@
}
}
- RenderObject::styleWillChange(diff, newStyle);
+ RenderElement::styleWillChange(diff, newStyle);
}
void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
{
- RenderObject::styleDidChange(diff, oldStyle);
+ RenderElement::styleDidChange(diff, oldStyle);
updateFromStyle();
if (requiresLayer()) {
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp (156254 => 156255)
--- trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp 2013-09-23 02:35:38 UTC (rev 156254)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp 2013-09-23 02:59:16 UTC (rev 156255)
@@ -44,7 +44,7 @@
void RenderSVGGradientStop::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
{
- RenderObject::styleDidChange(diff, oldStyle);
+ RenderElement::styleDidChange(diff, oldStyle);
if (diff == StyleDifferenceEqual)
return;
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp (156254 => 156255)
--- trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp 2013-09-23 02:35:38 UTC (rev 156254)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp 2013-09-23 02:59:16 UTC (rev 156255)
@@ -105,12 +105,12 @@
if (newStyle->hasTransform())
setNeedsTransformUpdate();
}
- RenderObject::styleWillChange(diff, newStyle);
+ RenderElement::styleWillChange(diff, newStyle);
}
void RenderSVGModelObject::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
{
- RenderObject::styleDidChange(diff, oldStyle);
+ RenderElement::styleDidChange(diff, oldStyle);
SVGResourcesCache::clientStyleChanged(this, diff, style());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
