Title: [156286] trunk/Source/_javascript_Core
Revision
156286
Author
[email protected]
Date
2013-09-23 12:46:46 -0700 (Mon, 23 Sep 2013)

Log Message

CodeLoad performance regression

Reviewed by Filip Pizlo.

Temporarily remove the ExpressionInfo compression until we can
work out how to make it not clobber performance.
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::addExpressionInfo):
* bytecode/UnlinkedCodeBlock.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (156285 => 156286)


--- trunk/Source/_javascript_Core/ChangeLog	2013-09-23 19:32:15 UTC (rev 156285)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-09-23 19:46:46 UTC (rev 156286)
@@ -1,3 +1,17 @@
+2013-09-23  Oliver Hunt  <[email protected]>
+
+        CodeLoad performance regression
+
+        Reviewed by Filip Pizlo.
+
+        Temporarily remove the ExpressionInfo compression until we can
+        work out how to make it not clobber performance.
+
+        * bytecode/UnlinkedCodeBlock.cpp:
+        (JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
+        (JSC::UnlinkedCodeBlock::addExpressionInfo):
+        * bytecode/UnlinkedCodeBlock.h:
+
 2013-09-23  Patrick Gansterer  <[email protected]>
 
         Cleanup CMake files in _javascript_Core

Modified: trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp (156285 => 156286)


--- trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp	2013-09-23 19:32:15 UTC (rev 156285)
+++ trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp	2013-09-23 19:46:46 UTC (rev 156286)
@@ -263,7 +263,7 @@
         return;
     }
 
-    Vector<ExpressionRangeInfo>& expressionInfo = m_expressionInfo.data();
+    Vector<ExpressionRangeInfo>& expressionInfo = m_expressionInfo;
 
     int low = 0;
     int high = expressionInfo.size();
@@ -351,7 +351,7 @@
     }
     } // switch
 
-    m_expressionInfo.data().append(info);
+    m_expressionInfo.append(info);
 }
 
 void UnlinkedProgramCodeBlock::visitChildren(JSCell* cell, SlotVisitor& visitor)

Modified: trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h (156285 => 156286)


--- trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h	2013-09-23 19:32:15 UTC (rev 156285)
+++ trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h	2013-09-23 19:46:46 UTC (rev 156286)
@@ -541,7 +541,7 @@
 
 private:
     OwnPtr<RareData> m_rareData;
-    CompressibleVector<ExpressionRangeInfo> m_expressionInfo;
+    Vector<ExpressionRangeInfo> m_expressionInfo;
 
 protected:
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to