Title: [156273] trunk
- Revision
- 156273
- Author
- [email protected]
- Date
- 2013-09-23 08:47:44 -0700 (Mon, 23 Sep 2013)
Log Message
[EFL] accessibility/aria-invalid is failing
https://bugs.webkit.org/show_bug.cgi?id=111986
Patch by Krzysztof Czech <[email protected]> on 2013-09-23
Reviewed by Mario Sanchez Prada.
Tools:
Adds possibility to retrieve JS context.
This is part of the implementation of AccessibilityUIElement::addNotificationListener
from 119883 and 120421.
* DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener):
(addAccessibilityNotificationHandler):
(removeAccessibilityNotificationHandler):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
LayoutTests:
Test passes on both efk-wk2 and efl-wk1, because of the patches from bugs: 119883 and 120421.
* platform/efl-wk1/TestExpectations: Removed accessibility/aria-invalid.html
* platform/efl-wk2/TestExpectations: Removed accessibility/aria-invalid.html
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (156272 => 156273)
--- trunk/LayoutTests/ChangeLog 2013-09-23 15:40:29 UTC (rev 156272)
+++ trunk/LayoutTests/ChangeLog 2013-09-23 15:47:44 UTC (rev 156273)
@@ -1,5 +1,17 @@
2013-09-23 Krzysztof Czech <[email protected]>
+ [EFL] accessibility/aria-invalid is failing
+ https://bugs.webkit.org/show_bug.cgi?id=111986
+
+ Reviewed by Mario Sanchez Prada.
+
+ Test passes on both efk-wk2 and efl-wk1, because of the patches from bugs: 119883 and 120421.
+
+ * platform/efl-wk1/TestExpectations: Removed accessibility/aria-invalid.html
+ * platform/efl-wk2/TestExpectations: Removed accessibility/aria-invalid.html
+
+2013-09-23 Krzysztof Czech <[email protected]>
+
[EFL] accessibility/selection-states.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112007
Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (156272 => 156273)
--- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-09-23 15:40:29 UTC (rev 156272)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-09-23 15:47:44 UTC (rev 156273)
@@ -147,7 +147,6 @@
webkit.org/b/117574 editing/selection/selection-button-text.html [ ImageOnlyFailure ]
webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
-webkit.org/b/111986 accessibility/aria-invalid.html [ Failure ]
webkit.org/b/111987 accessibility/aria-link-supports-press.html [ Failure ]
webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (156272 => 156273)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-09-23 15:40:29 UTC (rev 156272)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-09-23 15:47:44 UTC (rev 156273)
@@ -158,7 +158,6 @@
# Missing EFL's accessibility functions
webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
-webkit.org/b/111986 accessibility/aria-invalid.html [ Failure ]
webkit.org/b/111987 accessibility/aria-link-supports-press.html [ Failure ]
webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
Modified: trunk/Tools/ChangeLog (156272 => 156273)
--- trunk/Tools/ChangeLog 2013-09-23 15:40:29 UTC (rev 156272)
+++ trunk/Tools/ChangeLog 2013-09-23 15:47:44 UTC (rev 156273)
@@ -1,3 +1,22 @@
+2013-09-23 Krzysztof Czech <[email protected]>
+
+ [EFL] accessibility/aria-invalid is failing
+ https://bugs.webkit.org/show_bug.cgi?id=111986
+
+ Reviewed by Mario Sanchez Prada.
+
+ Adds possibility to retrieve JS context.
+ This is part of the implementation of AccessibilityUIElement::addNotificationListener
+ from 119883 and 120421.
+
+ * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
+ (axObjectEventListener):
+ (addAccessibilityNotificationHandler):
+ (removeAccessibilityNotificationHandler):
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
+ (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
+ (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
+
2013-09-20 Mark Rowe <[email protected]>
<https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp (156272 => 156273)
--- trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp 2013-09-23 15:40:29 UTC (rev 156272)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp 2013-09-23 15:47:44 UTC (rev 156273)
@@ -128,6 +128,8 @@
#if PLATFORM(GTK)
JSGlobalContextRef jsContext = webkit_web_frame_get_global_context(mainFrame);
+#elif PLATFORM(EFL)
+ JSGlobalContextRef jsContext = DumpRenderTreeSupportEfl::globalContextRefForFrame(browser->mainFrame());
#else
JSContextRef jsContext = 0;
#endif
@@ -227,6 +229,8 @@
#if PLATFORM(GTK)
JSGlobalContextRef jsContext = webkit_web_frame_get_global_context(mainFrame);
+#elif PLATFORM(EFL)
+ JSGlobalContextRef jsContext = DumpRenderTreeSupportEfl::globalContextRefForFrame(browser->mainFrame());
#else
JSContextRef jsContext = 0;
#endif
@@ -259,6 +263,8 @@
#if PLATFORM(GTK)
JSGlobalContextRef jsContext = webkit_web_frame_get_global_context(mainFrame);
+#elif PLATFORM(EFL)
+ JSGlobalContextRef jsContext = DumpRenderTreeSupportEfl::globalContextRefForFrame(browser->mainFrame());
#else
JSGlobalContextRef jsContext = 0;
#endif
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp (156272 => 156273)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp 2013-09-23 15:40:29 UTC (rev 156272)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp 2013-09-23 15:47:44 UTC (rev 156273)
@@ -113,7 +113,7 @@
if (loggingAccessibilityEvents)
printAccessibilityEvent(accessible, signalName.get(), signalValue.get());
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
WKBundlePageRef page = InjectedBundle::shared().page()->page();
WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(page);
JSContextRef jsContext = WKBundleFrameGetJavaScriptContext(mainFrame);
@@ -174,7 +174,7 @@
m_notificationFunctionCallback = notificationFunctionCallback;
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
WKBundlePageRef page = InjectedBundle::shared().page()->page();
WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(page);
JSContextRef jsContext = WKBundleFrameGetJavaScriptContext(mainFrame);
@@ -205,7 +205,7 @@
void AccessibilityNotificationHandler::removeAccessibilityNotificationHandler()
{
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
WKBundlePageRef page = InjectedBundle::shared().page()->page();
WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(page);
JSContextRef jsContext = WKBundleFrameGetJavaScriptContext(mainFrame);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
