Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (156301 => 156302)
--- trunk/Source/_javascript_Core/ChangeLog 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-09-23 22:25:25 UTC (rev 156302)
@@ -1,3 +1,16 @@
+2013-09-23 Patrick Gansterer <[email protected]>
+
+ use NOMINMAX instead of #define min min
+ https://bugs.webkit.org/show_bug.cgi?id=73563
+
+ Reviewed by Brent Fulgham.
+
+ Use NOMINMAX instead of #define min/max as a cleaner
+ way of ensuring that Windows system header files don't
+ define min/max as macro in the first place.
+
+ * config.h:
+
2013-09-23 Filip Pizlo <[email protected]>
Never use ReturnPC for exception handling and quit using exception check indices as a lame replica of the CodeOrigin index
Modified: trunk/Source/_javascript_Core/config.h (156301 => 156302)
--- trunk/Source/_javascript_Core/config.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/_javascript_Core/config.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -43,11 +43,6 @@
#define WINVER 0x0502
#endif
-// If we don't define these, they get defined in windef.h.
-// We want to use std::min and std::max
-#define max max
-#define min min
-
#if !COMPILER(MSVC7_OR_LOWER) && !OS(WINCE)
// We need to define this before the first #include of stdlib.h or it won't contain rand_s.
#ifndef _CRT_RAND_S
Modified: trunk/Source/WTF/ChangeLog (156301 => 156302)
--- trunk/Source/WTF/ChangeLog 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WTF/ChangeLog 2013-09-23 22:25:25 UTC (rev 156302)
@@ -1,3 +1,16 @@
+2013-09-23 Patrick Gansterer <[email protected]>
+
+ use NOMINMAX instead of #define min min
+ https://bugs.webkit.org/show_bug.cgi?id=73563
+
+ Reviewed by Brent Fulgham.
+
+ Use NOMINMAX instead of #define min/max as a cleaner
+ way of ensuring that Windows system header files don't
+ define min/max as macro in the first place.
+
+ * config.h:
+
2013-09-23 Anders Carlsson <[email protected]>
Remove PassTraits.h
Modified: trunk/Source/WTF/config.h (156301 => 156302)
--- trunk/Source/WTF/config.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WTF/config.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -40,11 +40,6 @@
#define WINVER 0x0502
#endif
-// If we don't define these, they get defined in windef.h.
-// We want to use std::min and std::max
-#define max max
-#define min min
-
#if !COMPILER(MSVC7_OR_LOWER) && !OS(WINCE)
// We need to define this before the first #include of stdlib.h or it won't contain rand_s.
#ifndef _CRT_RAND_S
Modified: trunk/Source/WebCore/ChangeLog (156301 => 156302)
--- trunk/Source/WebCore/ChangeLog 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WebCore/ChangeLog 2013-09-23 22:25:25 UTC (rev 156302)
@@ -1,3 +1,17 @@
+2013-09-23 Patrick Gansterer <[email protected]>
+
+ use NOMINMAX instead of #define min min
+ https://bugs.webkit.org/show_bug.cgi?id=73563
+
+ Reviewed by Brent Fulgham.
+
+ Use NOMINMAX instead of #define min/max as a cleaner
+ way of ensuring that Windows system header files don't
+ define min/max as macro in the first place.
+
+ * WebCorePrefix.h:
+ * config.h:
+
2013-09-23 Simon Fraser <[email protected]>
REGRESSION (r155998): when zooming in, tiles are too small
Modified: trunk/Source/WebCore/WebCorePrefix.h (156301 => 156302)
--- trunk/Source/WebCore/WebCorePrefix.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WebCore/WebCorePrefix.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -53,13 +53,6 @@
#endif
#endif
-// If we don't define these, they get defined in windef.h.
-// We want to use std::min and std::max
-#ifdef __cplusplus
-#define max max
-#define min min
-#endif
-
#else
#include <pthread.h>
Modified: trunk/Source/WebCore/config.h (156301 => 156302)
--- trunk/Source/WebCore/config.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WebCore/config.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -56,15 +56,6 @@
#define WINVER 0x0502
#endif
-// If we don't define these, they get defined in windef.h.
-// We want to use std::min and std::max.
-#ifndef max
-#define max max
-#endif
-#ifndef min
-#define min min
-#endif
-
// CURL needs winsock, so don't prevent inclusion of it
#if !USE(CURL)
#ifndef _WINSOCKAPI_
Modified: trunk/Source/WebKit/win/ChangeLog (156301 => 156302)
--- trunk/Source/WebKit/win/ChangeLog 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WebKit/win/ChangeLog 2013-09-23 22:25:25 UTC (rev 156302)
@@ -1,3 +1,16 @@
+2013-09-23 Patrick Gansterer <[email protected]>
+
+ use NOMINMAX instead of #define min min
+ https://bugs.webkit.org/show_bug.cgi?id=73563
+
+ Reviewed by Brent Fulgham.
+
+ Use NOMINMAX instead of #define min/max as a cleaner
+ way of ensuring that Windows system header files don't
+ define min/max as macro in the first place.
+
+ * WebKitPrefix.h:
+
2013-09-22 Sam Weinig <[email protected]>
Try to fix the windows build (take 2).
Modified: trunk/Source/WebKit/win/WebKitPrefix.h (156301 => 156302)
--- trunk/Source/WebKit/win/WebKitPrefix.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WebKit/win/WebKitPrefix.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -34,15 +34,6 @@
#define WINVER 0x0502
#endif
-// If we don't define these, they get defined in windef.h.
-// We want to use std::min and std::max.
-#ifndef max
-#define max max
-#endif
-#ifndef min
-#define min min
-#endif
-
#ifndef _WINSOCKAPI_
#define _WINSOCKAPI_ // Prevent inclusion of winsock.h in windows.h
#endif
Modified: trunk/Source/WebKit2/ChangeLog (156301 => 156302)
--- trunk/Source/WebKit2/ChangeLog 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WebKit2/ChangeLog 2013-09-23 22:25:25 UTC (rev 156302)
@@ -1,3 +1,16 @@
+2013-09-23 Patrick Gansterer <[email protected]>
+
+ use NOMINMAX instead of #define min min
+ https://bugs.webkit.org/show_bug.cgi?id=73563
+
+ Reviewed by Brent Fulgham.
+
+ Use NOMINMAX instead of #define min/max as a cleaner
+ way of ensuring that Windows system header files don't
+ define min/max as macro in the first place.
+
+ * config.h:
+
2013-09-23 ChangSeok Oh <[email protected]>
[GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
Modified: trunk/Source/WebKit2/config.h (156301 => 156302)
--- trunk/Source/WebKit2/config.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Source/WebKit2/config.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -65,15 +65,6 @@
#define WINVER 0x0502
#endif
-/* If we don't define these, they get defined in windef.h. */
-/* We want to use std::min and std::max. */
-#ifndef max
-#define max max
-#endif
-#ifndef min
-#define min min
-#endif
-
#ifndef _WINSOCKAPI_
#define _WINSOCKAPI_ /* Prevent inclusion of winsock.h in windows.h */
#endif
Modified: trunk/Tools/ChangeLog (156301 => 156302)
--- trunk/Tools/ChangeLog 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Tools/ChangeLog 2013-09-23 22:25:25 UTC (rev 156302)
@@ -1,3 +1,21 @@
+2013-09-23 Patrick Gansterer <[email protected]>
+
+ use NOMINMAX instead of #define min min
+ https://bugs.webkit.org/show_bug.cgi?id=73563
+
+ Reviewed by Brent Fulgham.
+
+ Use NOMINMAX instead of #define min/max as a cleaner
+ way of ensuring that Windows system header files don't
+ define min/max as macro in the first place.
+
+ * DumpRenderTree/DumpRenderTreePrefix.h:
+ * DumpRenderTree/cg/ImageDiffCG.cpp:
+ * DumpRenderTree/config.h:
+ * DumpRenderTree/win/ImageDiffCairo.cpp:
+ * WebKitTestRunner/WebKitTestRunnerPrefix.h:
+ * WebKitTestRunner/config.h:
+
2013-09-23 Benjamin Poulain <[email protected]>
Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
Modified: trunk/Tools/DumpRenderTree/DumpRenderTreePrefix.h (156301 => 156302)
--- trunk/Tools/DumpRenderTree/DumpRenderTreePrefix.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Tools/DumpRenderTree/DumpRenderTreePrefix.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -31,12 +31,3 @@
#import <Foundation/Foundation.h>
#endif
-
-#if defined(WIN32) || defined(_WIN32)
-
-// If we don't define these, they get defined in windef.h.
-// We want to use std::min and std::max
-#define max max
-#define min min
-
-#endif
Modified: trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp (156301 => 156302)
--- trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp 2013-09-23 22:25:25 UTC (rev 156302)
@@ -24,11 +24,6 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#if defined(WIN32) || defined(_WIN32)
-#define max max
-#define min min
-#endif
-
// FIXME: We need to be able to include these defines from a config.h somewhere.
#define JS_EXPORT_PRIVATE
#define WTF_EXPORT_PRIVATE
Modified: trunk/Tools/DumpRenderTree/config.h (156301 => 156302)
--- trunk/Tools/DumpRenderTree/config.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Tools/DumpRenderTree/config.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -56,15 +56,6 @@
#endif // PLATFORM(MAC)
-#if OS(WINDOWS)
-// If we don't define these, they get defined in windef.h.
-// We want to use std::min and std::max
-#undef max
-#define max max
-#undef min
-#define min min
-#endif
-
#if PLATFORM(WIN)
#define WTF_USE_CF 1
#if PLATFORM(WIN_CAIRO)
Modified: trunk/Tools/DumpRenderTree/win/ImageDiffCairo.cpp (156301 => 156302)
--- trunk/Tools/DumpRenderTree/win/ImageDiffCairo.cpp 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Tools/DumpRenderTree/win/ImageDiffCairo.cpp 2013-09-23 22:25:25 UTC (rev 156302)
@@ -50,9 +50,6 @@
#if PLATFORM(WIN)
-#undef min
-#undef max
-
static inline float strtof(const char* inputString, char** endptr)
{
return strtod(inputString, endptr);
Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h (156301 => 156302)
--- trunk/Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -27,13 +27,6 @@
#include <Cocoa/Cocoa.h>
#endif
-#if defined(WIN32) || defined(_WIN32)
-// If we don't define these, they get defined in windef.h.
-// We want to use std::min and std::max
-#define max max
-#define min min
-#endif
-
#if defined(BUILDING_GTK__)
#include "autotoolsconfig.h"
#endif /* defined (BUILDING_GTK__) */
Modified: trunk/Tools/WebKitTestRunner/config.h (156301 => 156302)
--- trunk/Tools/WebKitTestRunner/config.h 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/Tools/WebKitTestRunner/config.h 2013-09-23 22:25:25 UTC (rev 156302)
@@ -46,15 +46,4 @@
#endif
#endif
-#if OS(WINDOWS)
-/* If we don't define these, they get defined in windef.h. */
-/* We want to use std::min and std::max. */
-#ifndef max
-#define max max
#endif
-#ifndef min
-#define min min
-#endif
-#endif
-
-#endif
Modified: trunk/WebKitLibraries/ChangeLog (156301 => 156302)
--- trunk/WebKitLibraries/ChangeLog 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/WebKitLibraries/ChangeLog 2013-09-23 22:25:25 UTC (rev 156302)
@@ -1,3 +1,16 @@
+2013-09-23 Patrick Gansterer <[email protected]>
+
+ use NOMINMAX instead of #define min min
+ https://bugs.webkit.org/show_bug.cgi?id=73563
+
+ Reviewed by Brent Fulgham.
+
+ Use NOMINMAX instead of #define min/max as a cleaner
+ way of ensuring that Windows system header files don't
+ define min/max as macro in the first place.
+
+ * win/tools/vsprops/common.props:
+
2013-09-20 Mark Rowe <[email protected]>
Fix link errors for external users when building WebKit with Xcode 5.
Modified: trunk/WebKitLibraries/win/tools/vsprops/common.props (156301 => 156302)
--- trunk/WebKitLibraries/win/tools/vsprops/common.props 2013-09-23 22:16:44 UTC (rev 156301)
+++ trunk/WebKitLibraries/win/tools/vsprops/common.props 2013-09-23 22:25:25 UTC (rev 156302)
@@ -33,7 +33,7 @@
<ItemDefinitionGroup>
<ClCompile>
<AdditionalOptions>/bigobj /GS %(AdditionalOptions)</AdditionalOptions>
- <PreprocessorDefinitions>_WINDOWS;WINVER=0x502;_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1;_HAS_EXCEPTIONS=0;BUILDING_$(ProjectName);WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+ <PreprocessorDefinitions>_WINDOWS;WINVER=0x502;_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1;_HAS_EXCEPTIONS=0;BUILDING_$(ProjectName);NOMINMAX;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<PreprocessorDefinitions Condition="$(Platform)=='Win32'">WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<PreprocessorDefinitions Condition="$(Platform)=='Win64'">x64</PreprocessorDefinitions>
<ExceptionHandling>false</ExceptionHandling>
