Title: [156380] trunk/Source/WebCore
- Revision
- 156380
- Author
- [email protected]
- Date
- 2013-09-24 18:18:49 -0700 (Tue, 24 Sep 2013)
Log Message
Remove a contradiction from SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121881
Reviewed by Andreas Kling.
The matching code for PseudoHover and PseudoActive is done on the current
selector pseudo type. The current selector match type must be CSSSelector::PseudoClass
in order to reach this code. Consequently, selector->m_match == CSSSelector::Tag can
never be true.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (156379 => 156380)
--- trunk/Source/WebCore/ChangeLog 2013-09-25 01:17:53 UTC (rev 156379)
+++ trunk/Source/WebCore/ChangeLog 2013-09-25 01:18:49 UTC (rev 156380)
@@ -1,3 +1,18 @@
+2013-09-24 Benjamin Poulain <[email protected]>
+
+ Remove a contradiction from SelectorChecker
+ https://bugs.webkit.org/show_bug.cgi?id=121881
+
+ Reviewed by Andreas Kling.
+
+ The matching code for PseudoHover and PseudoActive is done on the current
+ selector pseudo type. The current selector match type must be CSSSelector::PseudoClass
+ in order to reach this code. Consequently, selector->m_match == CSSSelector::Tag can
+ never be true.
+
+ * css/SelectorChecker.cpp:
+ (WebCore::SelectorChecker::checkOne):
+
2013-09-24 Gyuyoung Kim <[email protected]>
Add toWebKitCSS*Value functions to cast from CSSValue
Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (156379 => 156380)
--- trunk/Source/WebCore/css/SelectorChecker.cpp 2013-09-25 01:17:53 UTC (rev 156379)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2013-09-25 01:18:49 UTC (rev 156380)
@@ -624,7 +624,7 @@
case CSSSelector::PseudoHover:
// If we're in quirks mode, then hover should never match anchors with no
// href and *:hover should not match anything. This is important for sites like wsj.com.
- if (m_strictParsing || context.isSubSelector || (selector->m_match == CSSSelector::Tag && selector->tagQName() != anyQName() && !isHTMLAnchorElement(element)) || element->isLink()) {
+ if (m_strictParsing || context.isSubSelector || element->isLink()) {
if (m_mode == ResolvingStyle) {
if (context.elementStyle)
context.elementStyle->setAffectedByHover();
@@ -638,7 +638,7 @@
case CSSSelector::PseudoActive:
// If we're in quirks mode, then :active should never match anchors with no
// href and *:active should not match anything.
- if (m_strictParsing || context.isSubSelector || (selector->m_match == CSSSelector::Tag && selector->tagQName() != anyQName() && !isHTMLAnchorElement(element)) || element->isLink()) {
+ if (m_strictParsing || context.isSubSelector || element->isLink()) {
if (m_mode == ResolvingStyle) {
if (context.elementStyle)
context.elementStyle->setAffectedByActive();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
