Title: [156386] trunk
Revision
156386
Author
[email protected]
Date
2013-09-25 04:02:23 -0700 (Wed, 25 Sep 2013)

Log Message

[EFL] accessibility/loading-iframe-sends-notification.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112003

Patch by Krzysztof Czech <[email protected]> on 2013-09-25
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Enabled AXLayoutComplete on EFL platform.

* dom/Document.cpp:
(WebCore::Document::implicitClose):
* page/FrameView.cpp:
(WebCore::FrameView::layout):

Tools:

Enabled addNotificationListener and removeNotificationListener for EFL port.

* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::removeNotificationListener):

LayoutTests:

* platform/efl-wk1/TestExpectations: Removed loading-iframe-sends-notification.html.
* platform/efl-wk2/TestExpectations: Removed loading-iframe-sends-notification.html.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (156385 => 156386)


--- trunk/LayoutTests/ChangeLog	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/LayoutTests/ChangeLog	2013-09-25 11:02:23 UTC (rev 156386)
@@ -1,3 +1,13 @@
+2013-09-25  Krzysztof Czech  <[email protected]>
+
+        [EFL] accessibility/loading-iframe-sends-notification.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=112003
+
+        Reviewed by Mario Sanchez Prada.
+
+        * platform/efl-wk1/TestExpectations: Removed loading-iframe-sends-notification.html.
+        * platform/efl-wk2/TestExpectations: Removed loading-iframe-sends-notification.html.
+
 2013-09-24  Ryosuke Niwa  <[email protected]>
 
         Crash in Document::setFocusedElement

Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (156385 => 156386)


--- trunk/LayoutTests/platform/efl-wk1/TestExpectations	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations	2013-09-25 11:02:23 UTC (rev 156386)
@@ -157,7 +157,6 @@
 webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
 webkit.org/b/112000 accessibility/heading-level.html [ Failure ]
 webkit.org/b/112002 accessibility/inline-continuations.html [ Failure ]
-webkit.org/b/112003 accessibility/loading-iframe-sends-notification.html [ Failure ]
 webkit.org/b/112023 accessibility/loading-iframe-updates-axtree.html [ Failure ]
 webkit.org/b/112005 accessibility/onclick-handlers.html [ Failure ]
 webkit.org/b/112006 accessibility/secure-textfield-title-ui.html [ Failure ]

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (156385 => 156386)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-09-25 11:02:23 UTC (rev 156386)
@@ -168,7 +168,6 @@
 webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
 webkit.org/b/112000 accessibility/heading-level.html [ Failure ]
 webkit.org/b/112002 accessibility/inline-continuations.html [ Failure ]
-webkit.org/b/112003 accessibility/loading-iframe-sends-notification.html [ Failure ]
 webkit.org/b/112005 accessibility/onclick-handlers.html [ Failure ]
 webkit.org/b/112006 accessibility/secure-textfield-title-ui.html [ Failure ]
 webkit.org/b/112008 accessibility/spinbutton-value.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (156385 => 156386)


--- trunk/Source/WebCore/ChangeLog	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/Source/WebCore/ChangeLog	2013-09-25 11:02:23 UTC (rev 156386)
@@ -1,3 +1,17 @@
+2013-09-25  Krzysztof Czech  <[email protected]>
+
+        [EFL] accessibility/loading-iframe-sends-notification.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=112003
+
+        Reviewed by Mario Sanchez Prada.
+
+        Enabled AXLayoutComplete on EFL platform.
+
+        * dom/Document.cpp:
+        (WebCore::Document::implicitClose):
+        * page/FrameView.cpp:
+        (WebCore::FrameView::layout):
+
 2013-09-24  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r156379.

Modified: trunk/Source/WebCore/dom/Document.cpp (156385 => 156386)


--- trunk/Source/WebCore/dom/Document.cpp	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-09-25 11:02:23 UTC (rev 156386)
@@ -2484,7 +2484,7 @@
 
     m_processingLoadEvent = false;
 
-#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK)
+#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(EFL)
     if (f && hasLivingRenderTree() && AXObjectCache::accessibilityEnabled()) {
         // The AX cache may have been cleared at this point, but we need to make sure it contains an
         // AX object to send the notification to. getOrCreate will make sure that an valid AX object

Modified: trunk/Source/WebCore/page/FrameView.cpp (156385 => 156386)


--- trunk/Source/WebCore/page/FrameView.cpp	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/Source/WebCore/page/FrameView.cpp	2013-09-25 11:02:23 UTC (rev 156386)
@@ -1325,7 +1325,7 @@
     
     m_layoutCount++;
 
-#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK)
+#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(EFL)
     if (AXObjectCache* cache = root->document().existingAXObjectCache())
         cache->postNotification(root, AXObjectCache::AXLayoutComplete);
 #endif

Modified: trunk/Tools/ChangeLog (156385 => 156386)


--- trunk/Tools/ChangeLog	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/Tools/ChangeLog	2013-09-25 11:02:23 UTC (rev 156386)
@@ -1,3 +1,16 @@
+2013-09-25  Krzysztof Czech  <[email protected]>
+
+        [EFL] accessibility/loading-iframe-sends-notification.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=112003
+
+        Reviewed by Mario Sanchez Prada.
+
+        Enabled addNotificationListener and removeNotificationListener for EFL port.
+
+        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
+        (WTR::AccessibilityController::removeNotificationListener):
+
 2013-09-24  Filip Pizlo  <[email protected]>
 
         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp (156385 => 156386)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp	2013-09-25 11:02:23 UTC (rev 156386)
@@ -97,7 +97,7 @@
 
 // Unsupported methods on various platforms.
 // As they're implemented on other platforms this list should be modified.
-#if !PLATFORM(GTK) && !PLATFORM(MAC)
+#if !PLATFORM(GTK) && !PLATFORM(MAC) && !PLATFORM(EFL)
 bool AccessibilityController::addNotificationListener(JSValueRef) { return false; }
 bool AccessibilityController::removeNotificationListener() { return false; }
 #endif

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp (156385 => 156386)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp	2013-09-25 05:38:32 UTC (rev 156385)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp	2013-09-25 11:02:23 UTC (rev 156386)
@@ -128,7 +128,6 @@
     return AccessibilityUIElement::create(static_cast<AtkObject*>(root));
 }
 
-#if PLATFORM(GTK)
 bool AccessibilityController::addNotificationListener(JSValueRef functionCallback)
 {
     if (!functionCallback)
@@ -150,6 +149,5 @@
     m_globalNotificationHandler = 0;
     return false;
 }
-#endif
 
 } // namespace WTR
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to