Title: [156418] trunk/Tools
- Revision
- 156418
- Author
- par...@webkit.org
- Date
- 2013-09-25 12:22:24 -0700 (Wed, 25 Sep 2013)
Log Message
[WIN] Fix MSVC C4146 compiler warning
https://bugs.webkit.org/show_bug.cgi?id=121838
Reviewed by Brent Fulgham.
Fix some variables from unsinged to int to fix the compiler warning
"unary minus operator applied to unsigned type, result still unsigned".
* DumpRenderTree/WorkQueueItem.h:
(BackItem::BackItem):
(ForwardItem::ForwardItem):
* DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (156417 => 156418)
--- trunk/Tools/ChangeLog 2013-09-25 19:13:04 UTC (rev 156417)
+++ trunk/Tools/ChangeLog 2013-09-25 19:22:24 UTC (rev 156418)
@@ -1,3 +1,19 @@
+2013-09-25 Patrick Gansterer <par...@webkit.org>
+
+ [WIN] Fix MSVC C4146 compiler warning
+ https://bugs.webkit.org/show_bug.cgi?id=121838
+
+ Reviewed by Brent Fulgham.
+
+ Fix some variables from unsinged to int to fix the compiler warning
+ "unary minus operator applied to unsigned type, result still unsigned".
+
+ * DumpRenderTree/WorkQueueItem.h:
+ (BackItem::BackItem):
+ (ForwardItem::ForwardItem):
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (createWebViewAndOffscreenWindow):
+
2013-09-25 Zan Dobersek <zdober...@igalia.com>
[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
Modified: trunk/Tools/DumpRenderTree/WorkQueueItem.h (156417 => 156418)
--- trunk/Tools/DumpRenderTree/WorkQueueItem.h 2013-09-25 19:13:04 UTC (rev 156417)
+++ trunk/Tools/DumpRenderTree/WorkQueueItem.h 2013-09-25 19:22:24 UTC (rev 156418)
@@ -132,7 +132,7 @@
class BackItem : public BackForwardItem {
public:
- BackItem(unsigned howFar)
+ BackItem(int howFar)
: BackForwardItem(-howFar)
{
}
@@ -140,7 +140,7 @@
class ForwardItem : public BackForwardItem {
public:
- ForwardItem(unsigned howFar)
+ ForwardItem(int howFar)
: BackForwardItem(howFar)
{
}
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (156417 => 156418)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2013-09-25 19:13:04 UTC (rev 156417)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2013-09-25 19:22:24 UTC (rev 156418)
@@ -1201,8 +1201,8 @@
IWebView* createWebViewAndOffscreenWindow(HWND* webViewWindow)
{
- unsigned maxViewWidth = TestRunner::viewWidth;
- unsigned maxViewHeight = TestRunner::viewHeight;
+ int maxViewWidth = TestRunner::viewWidth;
+ int maxViewHeight = TestRunner::viewHeight;
HWND hostWindow = CreateWindowEx(WS_EX_TOOLWINDOW, kDumpRenderTreeClassName, TEXT("DumpRenderTree"), WS_POPUP,
-maxViewWidth, -maxViewHeight, maxViewWidth, maxViewHeight, 0, 0, GetModuleHandle(0), 0);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
