Title: [156520] trunk/Source/WebInspectorUI
- Revision
- 156520
- Author
- [email protected]
- Date
- 2013-09-26 17:27:50 -0700 (Thu, 26 Sep 2013)
Log Message
Web Inspector: dissociate old content views that are spliced from back/forward list
https://bugs.webkit.org/show_bug.cgi?id=121987
Patch by Brian J. Burg <[email protected]> on 2013-09-26
Reviewed by Timothy Hatcher.
There was a bug where old back/forward list entries were not being dissociated when
the newly-shown content view was already in the list. Instead, dissociation should be
skipped if the old list entry is not already in the list.
* UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (156519 => 156520)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-09-27 00:27:47 UTC (rev 156519)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-09-27 00:27:50 UTC (rev 156520)
@@ -1,3 +1,17 @@
+2013-09-26 Brian J. Burg <[email protected]>
+
+ Web Inspector: dissociate old content views that are spliced from back/forward list
+ https://bugs.webkit.org/show_bug.cgi?id=121987
+
+ Reviewed by Timothy Hatcher.
+
+ There was a bug where old back/forward list entries were not being dissociated when
+ the newly-shown content view was already in the list. Instead, dissociation should be
+ skipped if the old list entry is not already in the list.
+
+ * UserInterface/ContentViewContainer.js:
+ (WebInspector.ContentViewContainer.prototype.showContentView):
+
2013-09-26 Antoine Quint <[email protected]>
Web Inspector: Activity viewer not properly reset when reloading
Modified: trunk/Source/WebInspectorUI/UserInterface/ContentViewContainer.js (156519 => 156520)
--- trunk/Source/WebInspectorUI/UserInterface/ContentViewContainer.js 2013-09-27 00:27:47 UTC (rev 156519)
+++ trunk/Source/WebInspectorUI/UserInterface/ContentViewContainer.js 2013-09-27 00:27:50 UTC (rev 156520)
@@ -158,7 +158,7 @@
// Disassociate with the removed content views.
for (var i = 0; i < removedItems.length; ++i) {
// Skip disassociation if this content view is still in the back/forward list.
- if (this._backForwardList.contains(contentView))
+ if (this._backForwardList.contains(removedItems[i]))
continue;
this._disassociateFromContentView(removedItems[i]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
