Title: [156524] trunk/Source/WTF
Revision
156524
Author
[email protected]
Date
2013-09-26 18:51:32 -0700 (Thu, 26 Sep 2013)

Log Message

Use the move assignment operator when reinserting values in the hash map
https://bugs.webkit.org/show_bug.cgi?id=122003

Reviewed by Alexey Proskuryakov.

Using the move assignment operator ensures that the existing values will be destroyed correctly.

* wtf/HashTable.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (156523 => 156524)


--- trunk/Source/WTF/ChangeLog	2013-09-27 01:46:25 UTC (rev 156523)
+++ trunk/Source/WTF/ChangeLog	2013-09-27 01:51:32 UTC (rev 156524)
@@ -1,3 +1,14 @@
+2013-09-26  Anders Carlsson  <[email protected]>
+
+        Use the move assignment operator when reinserting values in the hash map
+        https://bugs.webkit.org/show_bug.cgi?id=122003
+
+        Reviewed by Alexey Proskuryakov.
+
+        Using the move assignment operator ensures that the existing values will be destroyed correctly.
+
+        * wtf/HashTable.h:
+
 2013-09-26  Brent Fulgham  <[email protected]>
 
         [Windows] Work around missing C++11 features of MSVC by providing an implementation for

Modified: trunk/Source/WTF/wtf/HashTable.h (156523 => 156524)


--- trunk/Source/WTF/wtf/HashTable.h	2013-09-27 01:46:25 UTC (rev 156523)
+++ trunk/Source/WTF/wtf/HashTable.h	2013-09-27 01:51:32 UTC (rev 156524)
@@ -931,7 +931,7 @@
 #endif
 
         Value* newEntry = lookupForWriting(Extractor::extract(entry)).first;
-        new (NotNull, newEntry) ValueType(std::move(entry));
+        *newEntry = std::move(entry);
 
         return newEntry;
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to