Diff
Modified: trunk/Source/WebCore/ChangeLog (156885 => 156886)
--- trunk/Source/WebCore/ChangeLog 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/ChangeLog 2013-10-04 12:23:15 UTC (rev 156886)
@@ -1,5 +1,42 @@
2013-10-04 Zan Dobersek <[email protected]>
+ [WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute
+ https://bugs.webkit.org/show_bug.cgi?id=122276
+
+ Reviewed by Darin Adler.
+
+ Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
+ interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
+ doesn't have any effect, but will keep the operations not configurable after the generator is modified
+ to preserve the original behavior. The attribute will be removed from each interface after checking
+ conformity with other browsers (in terms of configurability of operations of that interface) and the
+ WebKit's existing test suites.
+
+ This patch covers IDL interfaces under Source/WebCore/css/.
+
+ * css/CSSHostRule.idl:
+ * css/CSSMediaRule.idl:
+ * css/CSSPrimitiveValue.idl:
+ * css/CSSRuleList.idl:
+ * css/CSSStyleDeclaration.idl:
+ * css/CSSStyleSheet.idl:
+ * css/CSSSupportsRule.idl:
+ * css/CSSValueList.idl:
+ * css/DOMWindowCSS.idl:
+ * css/FontLoader.idl:
+ * css/MediaList.idl:
+ * css/MediaQueryList.idl:
+ * css/MediaQueryListListener.idl:
+ * css/StyleMedia.idl:
+ * css/StyleSheet.idl:
+ * css/StyleSheetList.idl:
+ * css/WebKitCSSFilterValue.idl:
+ * css/WebKitCSSKeyframesRule.idl:
+ * css/WebKitCSSMatrix.idl:
+ * css/WebKitCSSTransformValue.idl:
+
+2013-10-04 Zan Dobersek <[email protected]>
+
[WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122274
Modified: trunk/Source/WebCore/css/CSSHostRule.idl (156885 => 156886)
--- trunk/Source/WebCore/css/CSSHostRule.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/CSSHostRule.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -21,6 +21,7 @@
// Introduced in Shadow DOM spec:
[
Conditional=SHADOW_DOM,
+ OperationsNotDeletable
] interface CSSHostRule : CSSRule {
readonly attribute CSSRuleList cssRules;
Modified: trunk/Source/WebCore/css/CSSMediaRule.idl (156885 => 156886)
--- trunk/Source/WebCore/css/CSSMediaRule.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/CSSMediaRule.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -19,7 +19,9 @@
*/
// Introduced in DOM Level 2:
-interface CSSMediaRule : CSSRule {
+[
+ OperationsNotDeletable
+] interface CSSMediaRule : CSSRule {
readonly attribute MediaList media;
readonly attribute CSSRuleList cssRules;
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.idl (156885 => 156886)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -18,7 +18,8 @@
*/
[
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] interface CSSPrimitiveValue : CSSValue {
// UnitTypes
Modified: trunk/Source/WebCore/css/CSSRuleList.idl (156885 => 156886)
--- trunk/Source/WebCore/css/CSSRuleList.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/CSSRuleList.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -26,7 +26,8 @@
// Introduced in DOM Level 2:
[
CustomIsReachable,
- SkipVTableValidation
+ SkipVTableValidation,
+ OperationsNotDeletable
] interface CSSRuleList {
readonly attribute unsigned long length;
getter CSSRule item([Default=Undefined] optional unsigned long index);
Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.idl (156885 => 156886)
--- trunk/Source/WebCore/css/CSSStyleDeclaration.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/CSSStyleDeclaration.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -26,7 +26,8 @@
JSCustomGetOwnPropertySlotAndDescriptor,
CustomNamedSetter,
CustomEnumerateProperty,
- SkipVTableValidation
+ SkipVTableValidation,
+ OperationsNotDeletable
] interface CSSStyleDeclaration {
[TreatReturnedNullStringAs=Null, TreatNullAs=NullString, SetterRaisesException] attribute DOMString cssText;
Modified: trunk/Source/WebCore/css/CSSStyleSheet.idl (156885 => 156886)
--- trunk/Source/WebCore/css/CSSStyleSheet.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/CSSStyleSheet.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -19,7 +19,9 @@
*/
// Introduced in DOM Level 2:
-interface CSSStyleSheet : StyleSheet {
+[
+ OperationsNotDeletable
+] interface CSSStyleSheet : StyleSheet {
readonly attribute CSSRule ownerRule;
readonly attribute CSSRuleList cssRules;
Modified: trunk/Source/WebCore/css/CSSSupportsRule.idl (156885 => 156886)
--- trunk/Source/WebCore/css/CSSSupportsRule.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/CSSSupportsRule.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -28,7 +28,8 @@
[
NoInterfaceObject,
- Conditional=CSS3_CONDITIONAL_RULES
+ Conditional=CSS3_CONDITIONAL_RULES,
+ OperationsNotDeletable
] interface CSSSupportsRule : CSSRule {
readonly attribute CSSRuleList cssRules;
readonly attribute DOMString conditionText;
Modified: trunk/Source/WebCore/css/CSSValueList.idl (156885 => 156886)
--- trunk/Source/WebCore/css/CSSValueList.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/CSSValueList.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -25,7 +25,8 @@
// Introduced in DOM Level 2:
[
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] interface CSSValueList : CSSValue {
readonly attribute unsigned long length;
getter CSSValue item([Default=Undefined] optional unsigned long index);
Modified: trunk/Source/WebCore/css/DOMWindowCSS.idl (156885 => 156886)
--- trunk/Source/WebCore/css/DOMWindowCSS.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/DOMWindowCSS.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -30,7 +30,8 @@
[
NoInterfaceObject,
InterfaceName=CSS,
- Conditional=CSS3_CONDITIONAL_RULES
+ Conditional=CSS3_CONDITIONAL_RULES,
+ OperationsNotDeletable
] interface DOMWindowCSS {
boolean supports(DOMString property, DOMString value);
Modified: trunk/Source/WebCore/css/FontLoader.idl (156885 => 156886)
--- trunk/Source/WebCore/css/FontLoader.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/FontLoader.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -34,6 +34,7 @@
ActiveDOMObject,
EventTarget,
GenerateIsReachable=ImplDocument,
+ OperationsNotDeletable
] interface FontLoader {
attribute EventListener onloading;
Modified: trunk/Source/WebCore/css/MediaList.idl (156885 => 156886)
--- trunk/Source/WebCore/css/MediaList.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/MediaList.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -27,7 +27,8 @@
[
JSCustomHeader,
GenerateIsReachable,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] interface MediaList {
[TreatNullAs=NullString, TreatReturnedNullStringAs=Null, SetterRaisesException] attribute DOMString mediaText;
Modified: trunk/Source/WebCore/css/MediaQueryList.idl (156885 => 156886)
--- trunk/Source/WebCore/css/MediaQueryList.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/MediaQueryList.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -18,7 +18,8 @@
*/
[
NoInterfaceObject,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] interface MediaQueryList {
readonly attribute DOMString media;
readonly attribute boolean matches;
Modified: trunk/Source/WebCore/css/MediaQueryListListener.idl (156885 => 156886)
--- trunk/Source/WebCore/css/MediaQueryListListener.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/MediaQueryListListener.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -18,7 +18,8 @@
*/
[
- CallbackNeedsOperatorEqual
+ CallbackNeedsOperatorEqual,
+ OperationsNotDeletable
] callback interface MediaQueryListListener {
boolean queryChanged([Default=Undefined] optional MediaQueryList list);
};
Modified: trunk/Source/WebCore/css/StyleMedia.idl (156885 => 156886)
--- trunk/Source/WebCore/css/StyleMedia.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/StyleMedia.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -26,7 +26,8 @@
[
NoInterfaceObject,
- GenerateIsReachable=ImplFrame
+ GenerateIsReachable=ImplFrame,
+ OperationsNotDeletable
] interface StyleMedia {
readonly attribute DOMString type;
boolean matchMedium([Default=Undefined] optional DOMString mediaquery);
Modified: trunk/Source/WebCore/css/StyleSheet.idl (156885 => 156886)
--- trunk/Source/WebCore/css/StyleSheet.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/StyleSheet.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -25,6 +25,7 @@
GenerateIsReachable,
CustomToJSObject,
ObjCPolymorphic,
+ OperationsNotDeletable
] interface StyleSheet {
[TreatReturnedNullStringAs=Null] readonly attribute DOMString type;
attribute boolean disabled;
Modified: trunk/Source/WebCore/css/StyleSheetList.idl (156885 => 156886)
--- trunk/Source/WebCore/css/StyleSheetList.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/StyleSheetList.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -21,7 +21,8 @@
// Introduced in DOM Level 2:
[
GenerateIsReachable=ImplDocument,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] interface StyleSheetList {
readonly attribute unsigned long length;
getter StyleSheet item([Default=Undefined] optional unsigned long index);
Modified: trunk/Source/WebCore/css/WebKitCSSFilterValue.idl (156885 => 156886)
--- trunk/Source/WebCore/css/WebKitCSSFilterValue.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/WebKitCSSFilterValue.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -26,7 +26,8 @@
[
Conditional=CSS_FILTERS,
DoNotCheckConstants,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] interface WebKitCSSFilterValue : CSSValueList {
// OperationTypes
Modified: trunk/Source/WebCore/css/WebKitCSSKeyframesRule.idl (156885 => 156886)
--- trunk/Source/WebCore/css/WebKitCSSKeyframesRule.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/WebKitCSSKeyframesRule.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -27,7 +27,9 @@
*/
// Introduced in DOM Level ?:
-interface WebKitCSSKeyframesRule : CSSRule {
+[
+ OperationsNotDeletable
+] interface WebKitCSSKeyframesRule : CSSRule {
[TreatReturnedNullStringAs=Null, TreatNullAs=NullString] attribute DOMString name;
readonly attribute CSSRuleList cssRules;
Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.idl (156885 => 156886)
--- trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -27,6 +27,7 @@
[
Constructor([Default=NullString] optional DOMString cssValue),
ConstructorRaisesException,
+ OperationsNotDeletable
] interface WebKitCSSMatrix {
// These attributes are simple aliases for certain elements of the 4x4 matrix
Modified: trunk/Source/WebCore/css/WebKitCSSTransformValue.idl (156885 => 156886)
--- trunk/Source/WebCore/css/WebKitCSSTransformValue.idl 2013-10-04 11:59:23 UTC (rev 156885)
+++ trunk/Source/WebCore/css/WebKitCSSTransformValue.idl 2013-10-04 12:23:15 UTC (rev 156886)
@@ -28,7 +28,8 @@
[
DoNotCheckConstants,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] interface WebKitCSSTransformValue : CSSValueList {
// OperationTypes
