Title: [156907] trunk/Source/WebCore
Revision
156907
Author
[email protected]
Date
2013-10-04 13:22:34 -0700 (Fri, 04 Oct 2013)

Log Message

[WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122269

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/xml/.

* xml/DOMParser.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestException.idl:
* xml/XMLHttpRequestUpload.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathException.idl:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:
* xml/XSLTProcessor.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (156906 => 156907)


--- trunk/Source/WebCore/ChangeLog	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/ChangeLog	2013-10-04 20:22:34 UTC (rev 156907)
@@ -1,3 +1,31 @@
+2013-10-04  Zan Dobersek  <[email protected]>
+
+        [WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
+        https://bugs.webkit.org/show_bug.cgi?id=122269
+
+        Reviewed by Darin Adler.
+
+        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
+        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
+        doesn't have any effect, but will keep the operations not configurable after the generator is modified
+        to preserve the original behavior. The attribute will be removed from each interface after checking
+        conformity with other browsers (in terms of configurability of operations of that interface) and the
+        WebKit's existing test suites.
+
+        This patch covers IDL interfaces under Source/WebCore/xml/.
+
+        * xml/DOMParser.idl:
+        * xml/XMLHttpRequest.idl:
+        * xml/XMLHttpRequestException.idl:
+        * xml/XMLHttpRequestUpload.idl:
+        * xml/XMLSerializer.idl:
+        * xml/XPathEvaluator.idl:
+        * xml/XPathException.idl:
+        * xml/XPathExpression.idl:
+        * xml/XPathNSResolver.idl:
+        * xml/XPathResult.idl:
+        * xml/XSLTProcessor.idl:
+
 2013-10-04  Bear Travis  <[email protected]>
 
         [CSS Shapes] Shape Outside should relayout when set dynamically

Modified: trunk/Source/WebCore/xml/DOMParser.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/DOMParser.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/DOMParser.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -19,7 +19,8 @@
 
 [
     Constructor,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface DOMParser {
     [RaisesException] Document parseFromString([Default=Undefined] optional DOMString str,
                              [Default=Undefined] optional DOMString contentType);

Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XMLHttpRequest.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -42,7 +42,8 @@
     ConstructorCallWith=ScriptExecutionContext,
     JSCustomMarkFunction,
     EventTarget,
-    JSNoStaticTables
+    JSNoStaticTables,
+    OperationsNotDeletable
 ] interface XMLHttpRequest {
     // From XMLHttpRequestEventTarget
     // event handler attributes

Modified: trunk/Source/WebCore/xml/XMLHttpRequestException.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XMLHttpRequestException.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XMLHttpRequestException.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -29,7 +29,8 @@
 [
     JSNoStaticTables,
     DoNotCheckConstants,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] exception XMLHttpRequestException {
 
     readonly attribute unsigned short   code;

Modified: trunk/Source/WebCore/xml/XMLHttpRequestUpload.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XMLHttpRequestUpload.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XMLHttpRequestUpload.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -29,7 +29,8 @@
 [
     GenerateIsReachable=Impl,
     EventTarget,
-    JSNoStaticTables
+    JSNoStaticTables,
+    OperationsNotDeletable
 ] interface XMLHttpRequestUpload {
     // From XMLHttpRequestEventTarget
     // event handler attributes

Modified: trunk/Source/WebCore/xml/XMLSerializer.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XMLSerializer.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XMLSerializer.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -20,7 +20,8 @@
 
 [
     Constructor,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface XMLSerializer {
     [RaisesException] DOMString serializeToString([Default=Undefined] optional Node node);
 };

Modified: trunk/Source/WebCore/xml/XPathEvaluator.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XPathEvaluator.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XPathEvaluator.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -19,7 +19,8 @@
 
 [
     Constructor,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface XPathEvaluator {
     [RaisesException] XPathExpression createExpression([Default=Undefined] optional DOMString _expression_,
                                      [Default=Undefined] optional XPathNSResolver resolver);

Modified: trunk/Source/WebCore/xml/XPathException.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XPathException.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XPathException.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -28,7 +28,8 @@
 
 [
     DoNotCheckConstants,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] exception XPathException {
 
     readonly attribute unsigned short   code;

Modified: trunk/Source/WebCore/xml/XPathExpression.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XPathExpression.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XPathExpression.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -18,7 +18,8 @@
  * Boston, MA 02110-1301, USA.
  */
 [
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface XPathExpression {
     [ObjCLegacyUnnamedParameters, RaisesException] XPathResult evaluate([Default=Undefined] optional Node contextNode, 
                                         [Default=Undefined] optional unsigned short type, 

Modified: trunk/Source/WebCore/xml/XPathNSResolver.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XPathNSResolver.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XPathNSResolver.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -21,7 +21,8 @@
 [
     NoInterfaceObject,
     ObjCProtocol,
-    SkipVTableValidation
+    SkipVTableValidation,
+    OperationsNotDeletable
 ] interface XPathNSResolver {
     [TreatReturnedNullStringAs=Null] DOMString lookupNamespaceURI([Default=Undefined] optional DOMString prefix);
 };

Modified: trunk/Source/WebCore/xml/XPathResult.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XPathResult.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XPathResult.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -19,7 +19,8 @@
 
 [
     JSCustomMarkFunction,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface XPathResult {
     const unsigned short ANY_TYPE                       = 0;
     const unsigned short NUMBER_TYPE                    = 1;

Modified: trunk/Source/WebCore/xml/XSLTProcessor.idl (156906 => 156907)


--- trunk/Source/WebCore/xml/XSLTProcessor.idl	2013-10-04 19:36:12 UTC (rev 156906)
+++ trunk/Source/WebCore/xml/XSLTProcessor.idl	2013-10-04 20:22:34 UTC (rev 156907)
@@ -33,7 +33,8 @@
 [
     Conditional=XSLT,
     Constructor,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface XSLTProcessor {
     
     void importStylesheet([Default=Undefined] optional Node stylesheet);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to