- Revision
- 156909
- Author
- [email protected]
- Date
- 2013-10-04 13:33:41 -0700 (Fri, 04 Oct 2013)
Log Message
[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122275
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/fileapi/.
* fileapi/Blob.idl:
* fileapi/FileException.idl:
* fileapi/FileList.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (156908 => 156909)
--- trunk/Source/WebCore/ChangeLog 2013-10-04 20:31:17 UTC (rev 156908)
+++ trunk/Source/WebCore/ChangeLog 2013-10-04 20:33:41 UTC (rev 156909)
@@ -1,5 +1,27 @@
2013-10-04 Zan Dobersek <[email protected]>
+ [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
+ https://bugs.webkit.org/show_bug.cgi?id=122275
+
+ Reviewed by Darin Adler.
+
+ Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
+ interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
+ doesn't have any effect, but will keep the operations not configurable after the generator is modified
+ to preserve the original behavior. The attribute will be removed from each interface after checking
+ conformity with other browsers (in terms of configurability of operations of that interface) and the
+ WebKit's existing test suites.
+
+ This patch covers IDL interfaces under Source/WebCore/fileapi/.
+
+ * fileapi/Blob.idl:
+ * fileapi/FileException.idl:
+ * fileapi/FileList.idl:
+ * fileapi/FileReader.idl:
+ * fileapi/FileReaderSync.idl:
+
+2013-10-04 Zan Dobersek <[email protected]>
+
[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122271
Modified: trunk/Source/WebCore/fileapi/Blob.idl (156908 => 156909)
--- trunk/Source/WebCore/fileapi/Blob.idl 2013-10-04 20:31:17 UTC (rev 156908)
+++ trunk/Source/WebCore/fileapi/Blob.idl 2013-10-04 20:33:41 UTC (rev 156909)
@@ -34,7 +34,8 @@
CustomToJSObject,
JSNoStaticTables,
CustomConstructor,
- CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options)
+ CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options),
+ OperationsNotDeletable
] interface Blob {
readonly attribute unsigned long long size;
readonly attribute DOMString type;
Modified: trunk/Source/WebCore/fileapi/FileException.idl (156908 => 156909)
--- trunk/Source/WebCore/fileapi/FileException.idl 2013-10-04 20:31:17 UTC (rev 156908)
+++ trunk/Source/WebCore/fileapi/FileException.idl 2013-10-04 20:33:41 UTC (rev 156909)
@@ -33,7 +33,8 @@
Conditional=BLOB,
DoNotCheckConstants,
JSNoStaticTables,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] exception FileException {
readonly attribute unsigned short code;
Modified: trunk/Source/WebCore/fileapi/FileList.idl (156908 => 156909)
--- trunk/Source/WebCore/fileapi/FileList.idl 2013-10-04 20:31:17 UTC (rev 156908)
+++ trunk/Source/WebCore/fileapi/FileList.idl 2013-10-04 20:33:41 UTC (rev 156909)
@@ -25,7 +25,8 @@
[
JSNoStaticTables,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ OperationsNotDeletable
] interface FileList {
readonly attribute unsigned long length;
getter File item(unsigned long index);
Modified: trunk/Source/WebCore/fileapi/FileReader.idl (156908 => 156909)
--- trunk/Source/WebCore/fileapi/FileReader.idl 2013-10-04 20:31:17 UTC (rev 156908)
+++ trunk/Source/WebCore/fileapi/FileReader.idl 2013-10-04 20:33:41 UTC (rev 156909)
@@ -36,7 +36,8 @@
Constructor,
ConstructorCallWith=ScriptExecutionContext,
EventTarget,
- JSNoStaticTables
+ JSNoStaticTables,
+ OperationsNotDeletable
] interface FileReader {
// ready states
const unsigned short EMPTY = 0;
Modified: trunk/Source/WebCore/fileapi/FileReaderSync.idl (156908 => 156909)
--- trunk/Source/WebCore/fileapi/FileReaderSync.idl 2013-10-04 20:31:17 UTC (rev 156908)
+++ trunk/Source/WebCore/fileapi/FileReaderSync.idl 2013-10-04 20:33:41 UTC (rev 156909)
@@ -32,7 +32,8 @@
GlobalContext=WorkerGlobalScope,
Conditional=BLOB,
Constructor,
- JSNoStaticTables
+ JSNoStaticTables,
+ OperationsNotDeletable
] interface FileReaderSync {
[CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);
[CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);
