Title: [157178] trunk/Source/WebKit2
- Revision
- 157178
- Author
- [email protected]
- Date
- 2013-10-09 13:15:35 -0700 (Wed, 09 Oct 2013)
Log Message
Set view to active in ViewClientEfl after WebProcess has relaunched
https://bugs.webkit.org/show_bug.cgi?id=118650
Patch by Sergio Correia <[email protected]> on 2013-10-09
Reviewed by Noam Rosenthal.
Once WebProcess relaunches, the underlying scene from the view is recreated
and is not active by default, which means it will be in `background'. In
practice, from that point on we are going to get a blank screen, unless we
set it to active.
In the normal flow, the view is set to active during its initialization; this
patch sets it to active also in ViewClientEfl, in the webProcessDidRelaunch
callback.
* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::webProcessDidRelaunch): Added WKViewSetIsActive call.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (157177 => 157178)
--- trunk/Source/WebKit2/ChangeLog 2013-10-09 20:05:13 UTC (rev 157177)
+++ trunk/Source/WebKit2/ChangeLog 2013-10-09 20:15:35 UTC (rev 157178)
@@ -1,3 +1,22 @@
+2013-10-09 Sergio Correia <[email protected]>
+
+ Set view to active in ViewClientEfl after WebProcess has relaunched
+ https://bugs.webkit.org/show_bug.cgi?id=118650
+
+ Reviewed by Noam Rosenthal.
+
+ Once WebProcess relaunches, the underlying scene from the view is recreated
+ and is not active by default, which means it will be in `background'. In
+ practice, from that point on we are going to get a blank screen, unless we
+ set it to active.
+
+ In the normal flow, the view is set to active during its initialization; this
+ patch sets it to active also in ViewClientEfl, in the webProcessDidRelaunch
+ callback.
+
+ * UIProcess/efl/ViewClientEfl.cpp:
+ (WebKit::ViewClientEfl::webProcessDidRelaunch): Added WKViewSetIsActive call.
+
2013-10-09 Commit Queue <[email protected]>
Unreviewed, rolling out r157157.
Modified: trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp (157177 => 157178)
--- trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp 2013-10-09 20:05:13 UTC (rev 157177)
+++ trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp 2013-10-09 20:15:35 UTC (rev 157178)
@@ -90,6 +90,10 @@
void ViewClientEfl::webProcessDidRelaunch(WKViewRef viewRef, const void* clientInfo)
{
+ // WebProcess just relaunched and the underlying scene from the view is not set to active by default, which
+ // means from that point on we would only get a blank screen, hence we set it to active here to avoid that.
+ WKViewSetIsActive(viewRef, true);
+
if (const char* themePath = toEwkView(clientInfo)->themePath())
WKViewSetThemePath(viewRef, adoptWK(WKStringCreateWithUTF8CString(themePath)).get());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
