Diff
Modified: trunk/LayoutTests/ChangeLog (157182 => 157183)
--- trunk/LayoutTests/ChangeLog 2013-10-09 20:44:02 UTC (rev 157182)
+++ trunk/LayoutTests/ChangeLog 2013-10-09 21:00:02 UTC (rev 157183)
@@ -1,3 +1,18 @@
+2013-10-09 Chris Fleizach <[email protected]>
+
+ AX: VoiceOver double speaks all items in <li> nodes
+ https://bugs.webkit.org/show_bug.cgi?id=122564
+
+ Reviewed by Brent Fulgham.
+
+ Make a mac specific expectation for listitem-title on Mac.
+ Make a more directed test for Mac regarding listitem labeling.
+
+ * platform/mac/accessibility/lists-expected.txt:
+ * platform/mac/accessibility/listitem-title-expected.txt: Added.
+ * platform/mac/accessibility/native-list-item-should-not-expose-label-expected.txt: Added.
+ * platform/mac/accessibility/native-list-item-should-not-expose-label.html: Added.
+
2013-10-09 Gustavo Noronha Silva <[email protected]>
Unreviewed gardening. Many inspector protocol tests are timing out on the bots, unreproducible locally.
Added: trunk/LayoutTests/platform/mac/accessibility/listitem-title-expected.txt (0 => 157183)
--- trunk/LayoutTests/platform/mac/accessibility/listitem-title-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/listitem-title-expected.txt 2013-10-09 21:00:02 UTC (rev 157183)
@@ -0,0 +1,13 @@
+test1
+test2
+test1
+test2
+
+
+
+
+il in ul title: AXTitle:
+
+il in ol title: AXTitle:
+
+
Modified: trunk/LayoutTests/platform/mac/accessibility/lists-expected.txt (157182 => 157183)
--- trunk/LayoutTests/platform/mac/accessibility/lists-expected.txt 2013-10-09 20:44:02 UTC (rev 157182)
+++ trunk/LayoutTests/platform/mac/accessibility/lists-expected.txt 2013-10-09 21:00:02 UTC (rev 157183)
@@ -167,22 +167,22 @@
AXRoleDescription: group
AXChildren: <array of size 2>
AXHelp:
-AXParent: <AXGroup: 'test 1'>
+AXParent: <AXGroup>
AXSize: NSSize: {729, 18}
-AXTitle: test 1
+AXTitle:
AXDescription:
AXValue:
AXFocused: 0
AXEnabled: 1
-AXWindow: <AXGroup: 'test 1'>
+AXWindow: <AXGroup>
AXSelectedTextMarkerRange: (null)
-AXStartTextMarker: <AXGroup: 'test 1'>
-AXEndTextMarker: <AXGroup: 'test 1'>
+AXStartTextMarker: <AXGroup>
+AXEndTextMarker: <AXGroup>
AXVisited: 0
AXLinkedUIElements: (null)
AXSelected: 0
AXBlockQuoteLevel: 0
-AXTopLevelUIElement: <AXGroup: 'test 1'>
+AXTopLevelUIElement: <AXGroup>
AXLanguage:
AXDOMIdentifier:
AXDOMClassList: <array of size 0>
@@ -195,22 +195,22 @@
AXRoleDescription: group
AXChildren: <array of size 2>
AXHelp:
-AXParent: <AXGroup: 'test 2'>
+AXParent: <AXGroup>
AXSize: NSSize: {729, 18}
-AXTitle: test 2
+AXTitle:
AXDescription:
AXValue:
AXFocused: 0
AXEnabled: 1
-AXWindow: <AXGroup: 'test 2'>
+AXWindow: <AXGroup>
AXSelectedTextMarkerRange: (null)
-AXStartTextMarker: <AXGroup: 'test 2'>
-AXEndTextMarker: <AXGroup: 'test 2'>
+AXStartTextMarker: <AXGroup>
+AXEndTextMarker: <AXGroup>
AXVisited: 0
AXLinkedUIElements: (null)
AXSelected: 0
AXBlockQuoteLevel: 0
-AXTopLevelUIElement: <AXGroup: 'test 2'>
+AXTopLevelUIElement: <AXGroup>
AXLanguage:
AXDOMIdentifier:
AXDOMClassList: <array of size 0>
@@ -225,22 +225,22 @@
AXRoleDescription: group
AXChildren: <array of size 2>
AXHelp:
-AXParent: <AXGroup: 'test 1'>
+AXParent: <AXGroup>
AXSize: NSSize: {729, 18}
-AXTitle: test 1
+AXTitle:
AXDescription:
AXValue:
AXFocused: 0
AXEnabled: 1
-AXWindow: <AXGroup: 'test 1'>
+AXWindow: <AXGroup>
AXSelectedTextMarkerRange: (null)
-AXStartTextMarker: <AXGroup: 'test 1'>
-AXEndTextMarker: <AXGroup: 'test 1'>
+AXStartTextMarker: <AXGroup>
+AXEndTextMarker: <AXGroup>
AXVisited: 0
AXLinkedUIElements: (null)
AXSelected: 0
AXBlockQuoteLevel: 0
-AXTopLevelUIElement: <AXGroup: 'test 1'>
+AXTopLevelUIElement: <AXGroup>
AXLanguage:
AXDOMIdentifier:
AXDOMClassList: <array of size 0>
@@ -253,22 +253,22 @@
AXRoleDescription: group
AXChildren: <array of size 2>
AXHelp:
-AXParent: <AXGroup: 'test 2'>
+AXParent: <AXGroup>
AXSize: NSSize: {729, 18}
-AXTitle: test 2
+AXTitle:
AXDescription:
AXValue:
AXFocused: 0
AXEnabled: 1
-AXWindow: <AXGroup: 'test 2'>
+AXWindow: <AXGroup>
AXSelectedTextMarkerRange: (null)
-AXStartTextMarker: <AXGroup: 'test 2'>
-AXEndTextMarker: <AXGroup: 'test 2'>
+AXStartTextMarker: <AXGroup>
+AXEndTextMarker: <AXGroup>
AXVisited: 0
AXLinkedUIElements: (null)
AXSelected: 0
AXBlockQuoteLevel: 0
-AXTopLevelUIElement: <AXGroup: 'test 2'>
+AXTopLevelUIElement: <AXGroup>
AXLanguage:
AXDOMIdentifier:
AXDOMClassList: <array of size 0>
Added: trunk/LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label-expected.txt (0 => 157183)
--- trunk/LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label-expected.txt 2013-10-09 21:00:02 UTC (rev 157183)
@@ -0,0 +1,12 @@
+Some text. Like
+This tests that list items on MacOS do not expose labeling information. MacOS expects only leaf-node type elements to do that.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS listitem.description is 'AXDescription: '
+PASS listitem.title is 'AXTitle: '
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label.html (0 => 157183)
--- trunk/LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label.html 2013-10-09 21:00:02 UTC (rev 157183)
@@ -0,0 +1,34 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+<ul>
+ <li id="listitem">
+ Some text.
+ <a href="" role="button">Like</a>
+ </li>
+</ul>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that list items on MacOS do not expose labeling information. MacOS expects only leaf-node type elements to do that.");
+
+ if (window.accessibilityController) {
+
+ // Both the title and description should be empty for the list item.
+ var listitem = accessibilityController.accessibleElementById("listitem");
+ shouldBe("listitem.description", "'AXDescription: '");
+ shouldBe("listitem.title", "'AXTitle: '");
+ }
+
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (157182 => 157183)
--- trunk/Source/WebCore/ChangeLog 2013-10-09 20:44:02 UTC (rev 157182)
+++ trunk/Source/WebCore/ChangeLog 2013-10-09 21:00:02 UTC (rev 157183)
@@ -1,3 +1,15 @@
+2013-10-09 Chris Fleizach <[email protected]>
+
+ AX: VoiceOver double speaks all items in <li> nodes
+ https://bugs.webkit.org/show_bug.cgi?id=122564
+
+ Reviewed by Brent Fulgham.
+
+ Test: platform/mac/accessibility/native-list-item-should-not-expose-label.html
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::visibleText):
+
2013-10-09 Sergio Correia <[email protected]>
CoordinatedGraphics: Fix integer rounding when computing pixel alignment
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (157182 => 157183)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-10-09 20:44:02 UTC (rev 157182)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-10-09 21:00:02 UTC (rev 157183)
@@ -1293,7 +1293,10 @@
case ToggleButtonRole:
case CheckBoxRole:
case ListBoxOptionRole:
+ // MacOS does not expect native <li> elements to expose label information, it only expects leaf node elements to do that.
+#if !PLATFORM(MAC)
case ListItemRole:
+#endif
case MenuButtonRole:
case MenuItemRole:
case MenuItemCheckboxRole:
