Title: [157415] trunk/Source/WebCore
Revision
157415
Author
[email protected]
Date
2013-10-14 12:53:01 -0700 (Mon, 14 Oct 2013)

Log Message

REGRESSION(r157408): Crashes in RenderFullScreen::wrapRenderer().

Unreviewed crash fix for these two tests:

- fullscreen/full-screen-restrictions.html
- fullscreen/empty-anonymous-block-continuation-crash.html

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):

    Get the RenderArena from Document like we did before this patch.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (157414 => 157415)


--- trunk/Source/WebCore/ChangeLog	2013-10-14 19:35:32 UTC (rev 157414)
+++ trunk/Source/WebCore/ChangeLog	2013-10-14 19:53:01 UTC (rev 157415)
@@ -1,3 +1,17 @@
+2013-10-14  Andreas Kling  <[email protected]>
+
+        REGRESSION(r157408): Crashes in RenderFullScreen::wrapRenderer().
+
+        Unreviewed crash fix for these two tests:
+
+        - fullscreen/full-screen-restrictions.html
+        - fullscreen/empty-anonymous-block-continuation-crash.html
+
+        * rendering/RenderFullScreen.cpp:
+        (RenderFullScreen::wrapRenderer):
+
+            Get the RenderArena from Document like we did before this patch.
+
 2013-10-14  Hans Muller  <[email protected]>
 
         [CSS Shapes] Image valued shape-outside shapes should update the layout after the image has been loaded

Modified: trunk/Source/WebCore/rendering/RenderFullScreen.cpp (157414 => 157415)


--- trunk/Source/WebCore/rendering/RenderFullScreen.cpp	2013-10-14 19:35:32 UTC (rev 157414)
+++ trunk/Source/WebCore/rendering/RenderFullScreen.cpp	2013-10-14 19:53:01 UTC (rev 157415)
@@ -109,7 +109,7 @@
 
 RenderFullScreen* RenderFullScreen::wrapRenderer(RenderObject* object, RenderElement* parent, Document& document)
 {
-    RenderFullScreen* fullscreenRenderer = new (object->renderArena()) RenderFullScreen(document);
+    RenderFullScreen* fullscreenRenderer = new (*document.renderArena()) RenderFullScreen(document);
     fullscreenRenderer->setStyle(createFullScreenStyle());
     if (parent && !parent->isChildAllowed(fullscreenRenderer, fullscreenRenderer->style())) {
         fullscreenRenderer->destroy();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to