Diff
Modified: trunk/Source/WebCore/ChangeLog (157485 => 157486)
--- trunk/Source/WebCore/ChangeLog 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/ChangeLog 2013-10-16 04:21:39 UTC (rev 157486)
@@ -1,3 +1,33 @@
+2013-10-15 Alexey Proskuryakov <[email protected]>
+
+ GenerateIsReachable=ImplContext is confusing
+ https://bugs.webkit.org/show_bug.cgi?id=122864
+
+ Reviewed by Geoffrey Garen.
+
+ Renamed to ImplWebGLRenderingContext.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateImplementation):
+ * bindings/scripts/IDLAttributes.txt:
+ * html/canvas/EXTDrawBuffers.idl:
+ * html/canvas/EXTTextureFilterAnisotropic.idl:
+ * html/canvas/OESElementIndexUint.idl:
+ * html/canvas/OESStandardDerivatives.idl:
+ * html/canvas/OESTextureFloat.idl:
+ * html/canvas/OESTextureHalfFloat.idl:
+ * html/canvas/OESVertexArrayObject.idl:
+ * html/canvas/WebGLCompressedTextureATC.idl:
+ * html/canvas/WebGLCompressedTexturePVRTC.idl:
+ * html/canvas/WebGLCompressedTextureS3TC.idl:
+ * html/canvas/WebGLDebugRendererInfo.idl:
+ * html/canvas/WebGLDebugShaders.idl:
+ * html/canvas/WebGLDepthTexture.idl:
+ * html/canvas/WebGLLoseContext.idl:
+
+ * WebCore.xcodeproj/project.pbxproj: While at it, added OESElementIndexUint.idl
+ to Xcode project.
+
2013-10-15 Tim Horton <[email protected]>
Unreviewed build fix; I don't know how to export.
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (157485 => 157486)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2013-10-16 04:21:39 UTC (rev 157486)
@@ -12480,6 +12480,7 @@
E169825F1134636A00894115 /* ObjCRuntimeObject.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ObjCRuntimeObject.mm; sourceTree = "<group>"; };
E16A84F714C85CCC002977DF /* CSSBorderImage.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CSSBorderImage.cpp; sourceTree = "<group>"; };
E16A84F814C85CCC002977DF /* CSSBorderImage.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CSSBorderImage.h; sourceTree = "<group>"; };
+ E176580C180DF3A0005A96D1 /* OESElementIndexUint.idl */ = {isa = PBXFileReference; lastKnownFileType = text; name = OESElementIndexUint.idl; path = canvas/OESElementIndexUint.idl; sourceTree = "<group>"; };
E17B490B16A97269001C8839 /* TransitionEvent.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = TransitionEvent.idl; sourceTree = "<group>"; };
E17B491316A9B093001C8839 /* TransitionEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TransitionEvent.cpp; sourceTree = "<group>"; };
E17B491416A9B093001C8839 /* TransitionEvent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TransitionEvent.h; sourceTree = "<group>"; };
@@ -14609,6 +14610,7 @@
7728694D14F8882500F484DC /* EXTTextureFilterAnisotropic.idl */,
7E5D7A73161D3F8F00896C34 /* OESElementIndexUint.cpp */,
7E5D7A74161D3F8F00896C34 /* OESElementIndexUint.h */,
+ E176580C180DF3A0005A96D1 /* OESElementIndexUint.idl */,
9001773D12E0347800648462 /* OESStandardDerivatives.cpp */,
9001773E12E0347800648462 /* OESStandardDerivatives.h */,
9001773F12E0347800648462 /* OESStandardDerivatives.idl */,
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (157485 => 157486)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-10-16 04:21:39 UTC (rev 157486)
@@ -2603,7 +2603,7 @@
my $rootString;
if (GetGenerateIsReachable($interface) eq "Impl") {
$rootString = " ${implType}* root = &js${interfaceName}->impl();\n";
- } elsif (GetGenerateIsReachable($interface) eq "ImplContext") {
+ } elsif (GetGenerateIsReachable($interface) eq "ImplWebGLRenderingContext") {
$rootString = " WebGLRenderingContext* root = js${interfaceName}->impl().context();\n";
} elsif (GetGenerateIsReachable($interface) eq "ImplFrame") {
$rootString = " Frame* root = js${interfaceName}->impl().frame();\n";
Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (157485 => 157486)
--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2013-10-16 04:21:39 UTC (rev 157486)
@@ -57,7 +57,7 @@
EnabledBySetting=*
EnforceRange
EventTarget
-GenerateIsReachable=|Impl|ImplContext|ImplDocument|ImplElementRoot|ImplFrame|ImplOwnerNodeRoot
+GenerateIsReachable=|Impl|ImplWebGLRenderingContext|ImplDocument|ImplElementRoot|ImplFrame|ImplOwnerNodeRoot
GetterRaisesException
GlobalContext=DOMWindow|WorkerGlobalScope|SharedWorkerGlobalScope|DedicatedWorkerGlobalScope
Immutable
Modified: trunk/Source/WebCore/html/canvas/EXTDrawBuffers.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/EXTDrawBuffers.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/EXTDrawBuffers.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -28,7 +28,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants,
OperationsNotDeletable
] interface EXTDrawBuffers {
Modified: trunk/Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants
] interface EXTTextureFilterAnisotropic {
const unsigned int TEXTURE_MAX_ANISOTROPY_EXT = 0x84FE;
Modified: trunk/Source/WebCore/html/canvas/OESElementIndexUint.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/OESElementIndexUint.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/OESElementIndexUint.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,6 +26,6 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
] interface OESElementIndexUint {
};
Modified: trunk/Source/WebCore/html/canvas/OESStandardDerivatives.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/OESStandardDerivatives.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/OESStandardDerivatives.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants
] interface OESStandardDerivatives {
const unsigned int FRAGMENT_SHADER_DERIVATIVE_HINT_OES = 0x8B8B;
Modified: trunk/Source/WebCore/html/canvas/OESTextureFloat.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/OESTextureFloat.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/OESTextureFloat.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,6 +26,6 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
] interface OESTextureFloat {
};
Modified: trunk/Source/WebCore/html/canvas/OESTextureHalfFloat.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/OESTextureHalfFloat.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/OESTextureHalfFloat.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,6 +26,6 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
] interface OESTextureHalfFloat {
};
Modified: trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants,
OperationsNotDeletable
] interface OESVertexArrayObject {
Modified: trunk/Source/WebCore/html/canvas/WebGLCompressedTextureATC.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/WebGLCompressedTextureATC.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/WebGLCompressedTextureATC.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants
] interface WebGLCompressedTextureATC {
/* Compressed Texture Formats */
Modified: trunk/Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants
] interface WebGLCompressedTexturePVRTC {
/* Compressed Texture Formats */
Modified: trunk/Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants
] interface WebGLCompressedTextureS3TC {
/* Compressed Texture Formats */
Modified: trunk/Source/WebCore/html/canvas/WebGLDebugRendererInfo.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/WebGLDebugRendererInfo.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/WebGLDebugRendererInfo.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants
] interface WebGLDebugRendererInfo {
const unsigned int UNMASKED_VENDOR_WEBGL = 0x9245;
Modified: trunk/Source/WebCore/html/canvas/WebGLDebugShaders.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/WebGLDebugShaders.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/WebGLDebugShaders.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
OperationsNotDeletable
] interface WebGLDebugShaders {
[StrictTypeChecking, TreatReturnedNullStringAs=Null, RaisesException] DOMString getTranslatedShaderSource(WebGLShader shader);
Modified: trunk/Source/WebCore/html/canvas/WebGLDepthTexture.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/WebGLDepthTexture.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/WebGLDepthTexture.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
DoNotCheckConstants
] interface WebGLDepthTexture {
const unsigned int UNSIGNED_INT_24_8_WEBGL = 0x84FA;
Modified: trunk/Source/WebCore/html/canvas/WebGLLoseContext.idl (157485 => 157486)
--- trunk/Source/WebCore/html/canvas/WebGLLoseContext.idl 2013-10-16 04:13:06 UTC (rev 157485)
+++ trunk/Source/WebCore/html/canvas/WebGLLoseContext.idl 2013-10-16 04:21:39 UTC (rev 157486)
@@ -26,7 +26,7 @@
[
NoInterfaceObject,
Conditional=WEBGL,
- GenerateIsReachable=ImplContext,
+ GenerateIsReachable=ImplWebGLRenderingContext,
OperationsNotDeletable
] interface WebGLLoseContext {
[StrictTypeChecking] void loseContext();
