Title: [157597] trunk/Source
- Revision
- 157597
- Author
- [email protected]
- Date
- 2013-10-17 14:07:59 -0700 (Thu, 17 Oct 2013)
Log Message
Web Inspector: allow front-end to trigger the system beep sound to signal an error
https://bugs.webkit.org/show_bug.cgi?id=122955
Reviewed by Timothy Hatcher.
Source/WebCore:
New beep() method exposed on InspectorFrontendHost calling into WebCore's systemBeep().
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::beep):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
Source/WebInspectorUI:
Provide a stub method for the new InspectorFrontendHost.beep() method.
* UserInterface/InspectorFrontendHostStub.js:
(WebInspector.InspectorFrontendHostStub.prototype.beep):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (157596 => 157597)
--- trunk/Source/WebCore/ChangeLog 2013-10-17 21:03:42 UTC (rev 157596)
+++ trunk/Source/WebCore/ChangeLog 2013-10-17 21:07:59 UTC (rev 157597)
@@ -1,3 +1,17 @@
+2013-10-17 Antoine Quint <[email protected]>
+
+ Web Inspector: allow front-end to trigger the system beep sound to signal an error
+ https://bugs.webkit.org/show_bug.cgi?id=122955
+
+ Reviewed by Timothy Hatcher.
+
+ New beep() method exposed on InspectorFrontendHost calling into WebCore's systemBeep().
+
+ * inspector/InspectorFrontendHost.cpp:
+ (WebCore::InspectorFrontendHost::beep):
+ * inspector/InspectorFrontendHost.h:
+ * inspector/InspectorFrontendHost.idl:
+
2013-10-17 Anders Carlsson <[email protected]>
Remove PlatformCAAnimation::supportsValueFunction()
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (157596 => 157597)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2013-10-17 21:03:42 UTC (rev 157596)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2013-10-17 21:07:59 UTC (rev 157597)
@@ -52,6 +52,7 @@
#include "ResourceRequest.h"
#include "ResourceResponse.h"
#include "ScriptFunctionCall.h"
+#include "Sound.h"
#include "UserGestureIndicator.h"
#include <wtf/StdLibExtras.h>
@@ -322,6 +323,11 @@
return m_client && m_client->isUnderTest();
}
+void InspectorFrontendHost::beep()
+{
+ systemBeep();
+}
+
bool InspectorFrontendHost::canSaveAs()
{
return false;
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (157596 => 157597)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2013-10-17 21:03:42 UTC (rev 157596)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2013-10-17 21:07:59 UTC (rev 157597)
@@ -90,6 +90,8 @@
bool isUnderTest();
+ void beep();
+
bool canInspectWorkers();
bool canSaveAs();
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (157596 => 157597)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2013-10-17 21:03:42 UTC (rev 157596)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2013-10-17 21:07:59 UTC (rev 157597)
@@ -77,6 +77,8 @@
boolean isUnderTest();
+ void beep();
+
// Deprecated
boolean canInspectWorkers();
boolean canSaveAs();
Modified: trunk/Source/WebInspectorUI/ChangeLog (157596 => 157597)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-10-17 21:03:42 UTC (rev 157596)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-10-17 21:07:59 UTC (rev 157597)
@@ -1,3 +1,15 @@
+2013-10-17 Antoine Quint <[email protected]>
+
+ Web Inspector: allow front-end to trigger the system beep sound to signal an error
+ https://bugs.webkit.org/show_bug.cgi?id=122955
+
+ Reviewed by Timothy Hatcher.
+
+ Provide a stub method for the new InspectorFrontendHost.beep() method.
+
+ * UserInterface/InspectorFrontendHostStub.js:
+ (WebInspector.InspectorFrontendHostStub.prototype.beep):
+
2013-10-15 Antoine Quint <[email protected]>
Web Inspector: can't select text inside a text node
Modified: trunk/Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js (157596 => 157597)
--- trunk/Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js 2013-10-17 21:03:42 UTC (rev 157596)
+++ trunk/Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js 2013-10-17 21:07:59 UTC (rev 157597)
@@ -146,6 +146,10 @@
return (navigator.platform.match(/mac|win|linux/i) || ["other"])[0].toLowerCase();
},
+ beep: function()
+ {
+ },
+
// Private
_sendPendingMessagesToBackendIfNeeded: function()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
