Title: [157667] trunk/Source/WebCore
- Revision
- 157667
- Author
- [email protected]
- Date
- 2013-10-19 07:33:52 -0700 (Sat, 19 Oct 2013)
Log Message
libWebCoreTestSupport should have explicit exports
https://bugs.webkit.org/show_bug.cgi?id=123053
Reviewed by Oliver Hunt.
No new tests because there is no change in behavior.
* Configurations/WebCoreTestSupport.xcconfig:
* testing/js/WebCoreTestSupport.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (157666 => 157667)
--- trunk/Source/WebCore/ChangeLog 2013-10-19 14:26:49 UTC (rev 157666)
+++ trunk/Source/WebCore/ChangeLog 2013-10-19 14:33:52 UTC (rev 157667)
@@ -1,3 +1,15 @@
+2013-10-19 Filip Pizlo <[email protected]>
+
+ libWebCoreTestSupport should have explicit exports
+ https://bugs.webkit.org/show_bug.cgi?id=123053
+
+ Reviewed by Oliver Hunt.
+
+ No new tests because there is no change in behavior.
+
+ * Configurations/WebCoreTestSupport.xcconfig:
+ * testing/js/WebCoreTestSupport.h:
+
2013-10-18 Andreas Kling <[email protected]>
Start passing RenderStyle around with PassRef.
Modified: trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig (157666 => 157667)
--- trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig 2013-10-19 14:26:49 UTC (rev 157666)
+++ trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig 2013-10-19 14:33:52 UTC (rev 157667)
@@ -44,5 +44,6 @@
PRODUCT_NAME = WebCoreTestSupport;
EXECUTABLE_PREFIX = lib;
EXPORTED_SYMBOLS_FILE = ;
+GCC_SYMBOLS_PRIVATE_EXTERN = YES;
OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
SECTORDER_FLAGS = ;
Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.h (157666 => 157667)
--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.h 2013-10-19 14:26:49 UTC (rev 157666)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.h 2013-10-19 14:33:52 UTC (rev 157667)
@@ -28,10 +28,16 @@
typedef const struct OpaqueJSContext* JSContextRef;
+#if PLATFORM(MAC)
+#define TEST_SUPPORT_EXPORT WTF_EXPORT_PRIVATE
+#else
+#define TEST_SUPPORT_EXPORT
+#endif
+
namespace WebCoreTestSupport {
-void injectInternalsObject(JSContextRef);
-void resetInternalsObject(JSContextRef);
+void injectInternalsObject(JSContextRef) TEST_SUPPORT_EXPORT;
+void resetInternalsObject(JSContextRef) TEST_SUPPORT_EXPORT;
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
