Diff
Modified: trunk/Source/WebCore/ChangeLog (157699 => 157700)
--- trunk/Source/WebCore/ChangeLog 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebCore/ChangeLog 2013-10-20 14:14:35 UTC (rev 157700)
@@ -1,3 +1,19 @@
+2013-10-20 Thiago de Barros Lacerda <[email protected]>
+
+ Removing "unused parameter" compiling warnings from WebKit2 and WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=123075
+
+ Reviewed by Andreas Kling.
+
+ No new tests needed.
+
+ * Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
+ (WebCore::RTCDTMFToneChangeEvent::create):
+ * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+ (lineAtPositionForAtkBoundary):
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
+
2013-10-19 Andreas Kling <[email protected]>
Use PassRef for constructing StyleRules.
Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp (157699 => 157700)
--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -42,7 +42,7 @@
return adoptRef(new RTCDTMFToneChangeEvent(tone));
}
-PassRefPtr<RTCDTMFToneChangeEvent> RTCDTMFToneChangeEvent::create(const AtomicString& type, const RTCDTMFToneChangeEventInit& initializer)
+PassRefPtr<RTCDTMFToneChangeEvent> RTCDTMFToneChangeEvent::create(const AtomicString&, const RTCDTMFToneChangeEventInit& initializer)
{
ASSERT(type == eventNames().tonechangeEvent);
return adoptRef(new RTCDTMFToneChangeEvent(initializer));
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (157699 => 157700)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -950,6 +950,7 @@
static VisibleSelection lineAtPositionForAtkBoundary(const AccessibilityObject* coreObject, const VisiblePosition& position, AtkTextBoundary boundaryType)
{
+ UNUSED_PARAM(coreObject);
VisiblePosition startPosition;
VisiblePosition endPosition;
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (157699 => 157700)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -1008,6 +1008,7 @@
void MediaPlayerPrivateGStreamer::processTableOfContentsEntry(GstTocEntry* entry, GstTocEntry* parent)
{
+ UNUSED_PARAM(parent);
ASSERT(entry);
RefPtr<GenericCueData> cue = GenericCueData::create();
Modified: trunk/Source/WebKit2/ChangeLog (157699 => 157700)
--- trunk/Source/WebKit2/ChangeLog 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/ChangeLog 2013-10-20 14:14:35 UTC (rev 157700)
@@ -1,3 +1,41 @@
+2013-10-20 Thiago de Barros Lacerda <[email protected]>
+
+ Removing "unused parameter" compiling warnings from WebKit2 and WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=123075
+
+ Reviewed by Andreas Kling.
+
+ * NetworkProcess/NetworkProcessPlatformStrategies.cpp:
+ (WebKit::NetworkProcessPlatformStrategies::loadResourceSynchronously):
+ * UIProcess/API/C/WKContext.cpp:
+ (WKContextGetPluginSiteDataManager):
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetInspectorUsesWebKitUserInterface):
+ (WKPreferencesGetInspectorUsesWebKitUserInterface):
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::getPlugins):
+ * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+ (WKBundlePageSetFullScreenClient):
+ (WKBundlePageWillEnterFullScreen):
+ (WKBundlePageDidEnterFullScreen):
+ (WKBundlePageWillExitFullScreen):
+ (WKBundlePageDidExitFullScreen):
+ * WebProcess/MediaCache/WebMediaCacheManager.cpp:
+ (WebKit::WebMediaCacheManager::clearCacheForHostname):
+ * WebProcess/OriginData/WebOriginDataManager.cpp:
+ (WebKit::WebOriginDataManager::getOrigins):
+ (WebKit::WebOriginDataManager::deleteEntriesForOrigin):
+ (WebKit::WebOriginDataManager::deleteAllEntries):
+ (WebKit::WebOriginDataManager::startObservingChanges):
+ (WebKit::WebOriginDataManager::stopObservingChanges):
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::createPlugin):
+ (WebKit::WebFrameLoaderClient::recreatePlugin):
+ * WebProcess/WebPage/EventDispatcher.cpp:
+ (WebKit::EventDispatcher::wheelEvent):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::canPluginHandleResponse):
+
2013-10-19 Jer Noble <[email protected]>
Unreviewed roll out of r157695; broke Mac builds.
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.cpp (157699 => 157700)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -84,7 +84,7 @@
return 0;
}
-void NetworkProcessPlatformStrategies::loadResourceSynchronously(NetworkingContext*, unsigned long resourceLoadIdentifier, const ResourceRequest&, StoredCredentials, ClientCredentialPolicy, ResourceError&, ResourceResponse&, Vector<char>& data)
+void NetworkProcessPlatformStrategies::loadResourceSynchronously(NetworkingContext*, unsigned long, const ResourceRequest&, StoredCredentials, ClientCredentialPolicy, ResourceError&, ResourceResponse&, Vector<char>&)
{
ASSERT_NOT_REACHED();
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (157699 => 157700)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -266,6 +266,7 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
return toAPI(toImpl(contextRef)->pluginSiteDataManager());
#else
+ UNUSED_PARAM(contextRef);
return 0;
#endif
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (157699 => 157700)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -798,12 +798,12 @@
return toImpl(preferencesRef)->applicationChromeMode();
}
-void WKPreferencesSetInspectorUsesWebKitUserInterface(WKPreferencesRef preferencesRef, bool enabled)
+void WKPreferencesSetInspectorUsesWebKitUserInterface(WKPreferencesRef, bool)
{
// FIXME: Remove once WebKit nightlies don't need to support Safari 6 thru 7.
}
-bool WKPreferencesGetInspectorUsesWebKitUserInterface(WKPreferencesRef preferencesRef)
+bool WKPreferencesGetInspectorUsesWebKitUserInterface(WKPreferencesRef)
{
// FIXME: Remove once WebKit nightlies don't need to support Safari 6 thru 7.
return false;
Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (157699 => 157700)
--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -318,6 +318,8 @@
plugins.append(PDFPlugin::pluginInfo());
applicationPlugins.append(PDFPlugin::pluginInfo());
}
+#else
+ UNUSED_PARAM(applicationPlugins);
#endif
}
#endif // ENABLE(NETSCAPE_PLUGIN_API)
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp (157699 => 157700)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -101,6 +101,9 @@
{
#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
toImpl(pageRef)->initializeInjectedBundleFullScreenClient(wkClient);
+#else
+ UNUSED_PARAM(pageRef);
+ UNUSED_PARAM(wkClient);
#endif
}
@@ -108,6 +111,8 @@
{
#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
toImpl(pageRef)->fullScreenManager()->willEnterFullScreen();
+#else
+ UNUSED_PARAM(pageRef);
#endif
}
@@ -115,6 +120,8 @@
{
#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
toImpl(pageRef)->fullScreenManager()->didEnterFullScreen();
+#else
+ UNUSED_PARAM(pageRef);
#endif
}
@@ -122,6 +129,8 @@
{
#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
toImpl(pageRef)->fullScreenManager()->willExitFullScreen();
+#else
+ UNUSED_PARAM(pageRef);
#endif
}
@@ -129,6 +138,8 @@
{
#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
toImpl(pageRef)->fullScreenManager()->didExitFullScreen();
+#else
+ UNUSED_PARAM(pageRef);
#endif
}
Modified: trunk/Source/WebKit2/WebProcess/MediaCache/WebMediaCacheManager.cpp (157699 => 157700)
--- trunk/Source/WebKit2/WebProcess/MediaCache/WebMediaCacheManager.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/WebProcess/MediaCache/WebMediaCacheManager.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -61,6 +61,8 @@
{
#if ENABLE(VIDEO)
HTMLMediaElement::clearMediaCacheForSite(hostname);
+#else
+ UNUSED_PARAM(hostname);
#endif
}
Modified: trunk/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp (157699 => 157700)
--- trunk/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -51,7 +51,7 @@
m_childProcess->addMessageReceiver(Messages::WebOriginDataManager::messageReceiverName(), this);
}
-void WebOriginDataManager::getOrigins(WKOriginDataTypes types, uint64_t callbackID)
+void WebOriginDataManager::getOrigins(WKOriginDataTypes, uint64_t callbackID)
{
HashSet<RefPtr<SecurityOrigin>> origins;
@@ -76,7 +76,7 @@
m_childProcess->send(Messages::WebOriginDataManagerProxy::DidGetOrigins(identifiers, callbackID), 0);
}
-void WebOriginDataManager::deleteEntriesForOrigin(WKOriginDataTypes types, const SecurityOriginData& originData)
+void WebOriginDataManager::deleteEntriesForOrigin(WKOriginDataTypes, const SecurityOriginData& originData)
{
RefPtr<SecurityOrigin> origin = SecurityOrigin::create(originData.protocol, originData.host, originData.port);
if (!origin)
@@ -85,17 +85,17 @@
// FIXME: delete entries for origin
}
-void WebOriginDataManager::deleteAllEntries(WKOriginDataTypes types)
+void WebOriginDataManager::deleteAllEntries(WKOriginDataTypes)
{
// FIXME: delete entries
}
-void WebOriginDataManager::startObservingChanges(WKOriginDataTypes types)
+void WebOriginDataManager::startObservingChanges(WKOriginDataTypes)
{
// FIXME: start observing changes
}
-void WebOriginDataManager::stopObservingChanges(WKOriginDataTypes types)
+void WebOriginDataManager::stopObservingChanges(WKOriginDataTypes)
{
// FIXME: stop observing changes
}
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (157699 => 157700)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -1316,6 +1316,7 @@
return PluginView::create(pluginElement, plugin.release(), parameters);
#else
+ UNUSED_PARAM(pluginElement);
return 0;
#endif
}
@@ -1330,6 +1331,8 @@
String newMIMEType;
RefPtr<Plugin> plugin = m_frame->page()->createPlugin(m_frame, pluginView->pluginElement(), pluginView->initialParameters(), newMIMEType);
pluginView->recreateAndInitialize(plugin.release());
+#else
+ UNUSED_PARAM(widget);
#endif
}
Modified: trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp (157699 => 157700)
--- trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -104,6 +104,11 @@
return;
}
}
+#else
+ UNUSED_PARAM(canRubberBandsAtLeft);
+ UNUSED_PARAM(canRubberBandsAtRight);
+ UNUSED_PARAM(canRubberBandsAtTop);
+ UNUSED_PARAM(canRubberBandsAtBottom);
#endif
RunLoop::main()->dispatch(bind(&EventDispatcher::dispatchWheelEvent, this, pageID, wheelEvent));
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (157699 => 157700)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2013-10-20 11:06:05 UTC (rev 157699)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2013-10-20 14:14:35 UTC (rev 157700)
@@ -3631,6 +3631,7 @@
return pluginLoadPolicy != PluginModuleBlocked && pluginProcessToken;
#else
+ UNUSED_PARAM(response);
return false;
#endif
}
