Title: [157708] trunk/Source/_javascript_Core
- Revision
- 157708
- Author
- [email protected]
- Date
- 2013-10-20 22:14:53 -0700 (Sun, 20 Oct 2013)
Log Message
Unreviewed, cleanup a FIXME comment.
* jit/Repatch.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (157707 => 157708)
--- trunk/Source/_javascript_Core/ChangeLog 2013-10-21 04:48:29 UTC (rev 157707)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-10-21 05:14:53 UTC (rev 157708)
@@ -1,5 +1,11 @@
2013-10-20 Filip Pizlo <[email protected]>
+ Unreviewed, cleanup a FIXME comment.
+
+ * jit/Repatch.cpp:
+
+2013-10-20 Filip Pizlo <[email protected]>
+
StructureStubInfo's usedRegisters set should be able to track all registers, not just the ones that our JIT's view as temporaries
https://bugs.webkit.org/show_bug.cgi?id=123076
Modified: trunk/Source/_javascript_Core/jit/Repatch.cpp (157707 => 157708)
--- trunk/Source/_javascript_Core/jit/Repatch.cpp 2013-10-21 04:48:29 UTC (rev 157707)
+++ trunk/Source/_javascript_Core/jit/Repatch.cpp 2013-10-21 05:14:53 UTC (rev 157708)
@@ -48,12 +48,9 @@
// - tagMaskRegister
// - callFrameRegister **
//
-// The callFrameRegister is a double-FIXME:
-// - https://bugs.webkit.org/show_bug.cgi?id=123085
-// We're not yet done getting rid of past uses of callFrameRegister.
-// - https://bugs.webkit.org/show_bug.cgi?id=113621
-// Once the calling convention work is done, we won't need the callFrameRegister anymore
-// since we'll just use framePointerRegister.
+// We currently only use the callFrameRegister for closure call patching, and we're not going to
+// give the FTL closure call patching support until we switch to the C stack - but when we do that,
+// callFrameRegister will disappear.
static void repatchCall(CodeBlock* codeblock, CodeLocationCall call, FunctionPtr newCalleeFunction)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
