Title: [157857] trunk
- Revision
- 157857
- Author
- commit-qu...@webkit.org
- Date
- 2013-10-23 05:13:23 -0700 (Wed, 23 Oct 2013)
Log Message
[GTK] accessibility/self-referencing-aria-labelledby.html is failing
https://bugs.webkit.org/show_bug.cgi?id=121594
Patch by Krzysztof Wolanski <k.wolan...@samsung.com> on 2013-10-23
Reviewed by Mario Sanchez Prada.
Source/WebCore:
According to http://www.w3.org/TR/REC-html40/struct/objects.html#edef-IMG
description of image element should be determined by alt attribute, then
if it is empty by title attributte.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetDescription):
LayoutTests:
* platform/efl/TestExpectations:
accessibility/self-referencing-aria-labelledby.html is now passing
* platform/gtk/TestExpectations:
accessibility/self-referencing-aria-labelledby.html is now passing
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (157856 => 157857)
--- trunk/LayoutTests/ChangeLog 2013-10-23 10:55:43 UTC (rev 157856)
+++ trunk/LayoutTests/ChangeLog 2013-10-23 12:13:23 UTC (rev 157857)
@@ -1,3 +1,15 @@
+2013-10-23 Krzysztof Wolanski <k.wolan...@samsung.com>
+
+ [GTK] accessibility/self-referencing-aria-labelledby.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=121594
+
+ Reviewed by Mario Sanchez Prada.
+
+ * platform/efl/TestExpectations:
+ accessibility/self-referencing-aria-labelledby.html is now passing
+ * platform/gtk/TestExpectations:
+ accessibility/self-referencing-aria-labelledby.html is now passing
+
2013-10-22 Zoltan Horvath <zol...@webkit.org>
Refactor LineBreaker::nextSegmentBreak, add BreakingContext that holds all its state
Modified: trunk/LayoutTests/platform/efl/TestExpectations (157856 => 157857)
--- trunk/LayoutTests/platform/efl/TestExpectations 2013-10-23 10:55:43 UTC (rev 157856)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2013-10-23 12:13:23 UTC (rev 157857)
@@ -1423,7 +1423,6 @@
webkit.org/b/121684 accessibility/aria-describedby-on-input.html [ Failure ]
webkit.org/b/84045 accessibility/image-map1.html [ Failure ]
webkit.org/b/121593 accessibility/radio-button-title-label.html [ Failure ]
-webkit.org/b/121594 accessibility/self-referencing-aria-labelledby.html [ Failure ]
# Newly added test at r139111 is failing.
webkit.org/b/106439 editing/pasteboard/paste-noplugin.html [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (157856 => 157857)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-10-23 10:55:43 UTC (rev 157856)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-10-23 12:13:23 UTC (rev 157857)
@@ -1418,8 +1418,6 @@
webkit.org/b/121593 accessibility/radio-button-title-label.html [ Failure ]
-webkit.org/b/121594 accessibility/self-referencing-aria-labelledby.html [ Failure ]
-
webkit.org/b/121905 fast/images/exif-orientation.html [ Failure ]
webkit.org/b/122147 fast/css/drop-shadow-viewport-height.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (157856 => 157857)
--- trunk/Source/WebCore/ChangeLog 2013-10-23 10:55:43 UTC (rev 157856)
+++ trunk/Source/WebCore/ChangeLog 2013-10-23 12:13:23 UTC (rev 157857)
@@ -1,3 +1,17 @@
+2013-10-23 Krzysztof Wolanski <k.wolan...@samsung.com>
+
+ [GTK] accessibility/self-referencing-aria-labelledby.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=121594
+
+ Reviewed by Mario Sanchez Prada.
+
+ According to http://www.w3.org/TR/REC-html40/struct/objects.html#edef-IMG
+ description of image element should be determined by alt attribute, then
+ if it is empty by title attributte.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (webkitAccessibleGetDescription):
+
2013-10-15 Andreas Kling <akl...@apple.com>
Tighten animation-driven restyle to operate on Element only.
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (157856 => 157857)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-10-23 10:55:43 UTC (rev 157856)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-10-23 12:13:23 UTC (rev 157857)
@@ -172,7 +172,7 @@
Node* node = 0;
if (coreObject->isAccessibilityRenderObject())
node = coreObject->node();
- if (!node || !node->isHTMLElement() || coreObject->ariaRoleAttribute() != UnknownRole)
+ if (!node || !node->isHTMLElement() || coreObject->ariaRoleAttribute() != UnknownRole || coreObject->isImage())
return cacheAndReturnAtkProperty(object, AtkCachedAccessibleDescription, accessibilityDescription(coreObject));
// atk_table_get_summary returns an AtkObject. We have no summary object, so expose summary here.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
