Title: [157930] trunk/Source/_javascript_Core
- Revision
- 157930
- Author
- [email protected]
- Date
- 2013-10-24 09:06:50 -0700 (Thu, 24 Oct 2013)
Log Message
Uninitialized member causes crash when DFG JIT is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=123270
Patch by [email protected] <[email protected]> on 2013-10-24
Reviewed by Brent Fulgham.
The data member sizeOfLastScratchBuffer in the VM class is only initialized if DFG JIT is enabled, even though it's defined regardless.
This causes an early crash on Windows, which doesn't have DFG JIT enabled.
* runtime/VM.cpp:
(JSC::VM::VM): Initialize sizeOfLastScratchBuffer member regardless of whether DFG JIT is enabled.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (157929 => 157930)
--- trunk/Source/_javascript_Core/ChangeLog 2013-10-24 16:00:11 UTC (rev 157929)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-10-24 16:06:50 UTC (rev 157930)
@@ -1,3 +1,16 @@
+2013-10-24 [email protected] <[email protected]>
+
+ Uninitialized member causes crash when DFG JIT is not enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=123270
+
+ Reviewed by Brent Fulgham.
+
+ The data member sizeOfLastScratchBuffer in the VM class is only initialized if DFG JIT is enabled, even though it's defined regardless.
+ This causes an early crash on Windows, which doesn't have DFG JIT enabled.
+
+ * runtime/VM.cpp:
+ (JSC::VM::VM): Initialize sizeOfLastScratchBuffer member regardless of whether DFG JIT is enabled.
+
2013-10-24 Ryuan Choi <[email protected]>
[EFL] Build break with latest EFL 1.8 libraries.
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (157929 => 157930)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2013-10-24 16:00:11 UTC (rev 157929)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2013-10-24 16:06:50 UTC (rev 157930)
@@ -194,9 +194,7 @@
, interpreter(0)
, jsArrayClassInfo(JSArray::info())
, jsFinalObjectClassInfo(JSFinalObject::info())
-#if ENABLE(DFG_JIT)
, sizeOfLastScratchBuffer(0)
-#endif
, dynamicGlobalObject(0)
, m_enabledProfiler(0)
, m_regExpCache(new RegExpCache(this))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
