Title: [157949] trunk/LayoutTests
- Revision
- 157949
- Author
- [email protected]
- Date
- 2013-10-24 12:59:57 -0700 (Thu, 24 Oct 2013)
Log Message
dumpAsText() is unnecessarily called in spellchecking tests
https://bugs.webkit.org/show_bug.cgi?id=123266
Reviewed by Darin Adler.
dumpAsText is already called either by notifyDone (js-test-post.js) or
by finishJSTest() when asynchrononous spell checking is used.
* editing/spelling/spellcheck-async-mutation.html:
* editing/spelling/spellcheck-async.html:
* editing/spelling/spellcheck-attribute-expected.txt:
* editing/spelling/spellcheck-attribute.html:
* editing/spelling/spelling-insert-html.html:
* editing/spelling/spelling-unified-emulation.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (157948 => 157949)
--- trunk/LayoutTests/ChangeLog 2013-10-24 19:53:35 UTC (rev 157948)
+++ trunk/LayoutTests/ChangeLog 2013-10-24 19:59:57 UTC (rev 157949)
@@ -1,3 +1,20 @@
+2013-10-24 Grzegorz Czajkowski <[email protected]>
+
+ dumpAsText() is unnecessarily called in spellchecking tests
+ https://bugs.webkit.org/show_bug.cgi?id=123266
+
+ Reviewed by Darin Adler.
+
+ dumpAsText is already called either by notifyDone (js-test-post.js) or
+ by finishJSTest() when asynchrononous spell checking is used.
+
+ * editing/spelling/spellcheck-async-mutation.html:
+ * editing/spelling/spellcheck-async.html:
+ * editing/spelling/spellcheck-attribute-expected.txt:
+ * editing/spelling/spellcheck-attribute.html:
+ * editing/spelling/spelling-insert-html.html:
+ * editing/spelling/spelling-unified-emulation.html:
+
2013-10-24 Myles C. Maxfield <[email protected]>
Gaps between underlines in adjacent underlined text runs
Modified: trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html (157948 => 157949)
--- trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html 2013-10-24 19:53:35 UTC (rev 157948)
+++ trunk/LayoutTests/editing/spelling/spellcheck-async-mutation.html 2013-10-24 19:59:57 UTC (rev 157949)
@@ -29,9 +29,6 @@
var jsTestIsAsync = true;
-if (window.testRunner)
- testRunner.dumpAsText();
-
if (window.internals) {
internals.settings.setAsynchronousSpellCheckingEnabled(true);
internals.settings.setUnifiedTextCheckerEnabled(true);
Modified: trunk/LayoutTests/editing/spelling/spellcheck-async.html (157948 => 157949)
--- trunk/LayoutTests/editing/spelling/spellcheck-async.html 2013-10-24 19:53:35 UTC (rev 157948)
+++ trunk/LayoutTests/editing/spelling/spellcheck-async.html 2013-10-24 19:59:57 UTC (rev 157949)
@@ -21,9 +21,6 @@
jsTestIsAsync = true;
-if (window.testRunner)
- testRunner.dumpAsText();
-
if (window.internals) {
internals.settings.setAsynchronousSpellCheckingEnabled(true);
internals.settings.setUnifiedTextCheckerEnabled(true);
Modified: trunk/LayoutTests/editing/spelling/spellcheck-attribute-expected.txt (157948 => 157949)
--- trunk/LayoutTests/editing/spelling/spellcheck-attribute-expected.txt 2013-10-24 19:53:35 UTC (rev 157948)
+++ trunk/LayoutTests/editing/spelling/spellcheck-attribute-expected.txt 2013-10-24 19:59:57 UTC (rev 157949)
@@ -51,4 +51,7 @@
PASS internals.hasSpellingMarker(document, 0, 2) is true
id=test4_6 type=search spellcheck=false parent's spellcheck=false
PASS internals.hasSpellingMarker(document, 0, 2) is false
+PASS successfullyParsed is true
+TEST COMPLETE
+
Modified: trunk/LayoutTests/editing/spelling/spellcheck-attribute.html (157948 => 157949)
--- trunk/LayoutTests/editing/spelling/spellcheck-attribute.html 2013-10-24 19:53:35 UTC (rev 157948)
+++ trunk/LayoutTests/editing/spelling/spellcheck-attribute.html 2013-10-24 19:59:57 UTC (rev 157949)
@@ -94,10 +94,10 @@
testMarkerForMisspelledWord('test4_6', false);
if (window.testRunner) {
- testRunner.dumpAsText();
// Cleaning up for expeation text if running on DRT.
document.getElementById("testRoot").style.display = "none";
}
</script>
+<script src=""
</body>
</html>
Modified: trunk/LayoutTests/editing/spelling/spelling-insert-html.html (157948 => 157949)
--- trunk/LayoutTests/editing/spelling/spelling-insert-html.html 2013-10-24 19:53:35 UTC (rev 157948)
+++ trunk/LayoutTests/editing/spelling/spelling-insert-html.html 2013-10-24 19:59:57 UTC (rev 157949)
@@ -36,9 +36,6 @@
shouldBeEqualToString("markedText", "zz");
}
-if (window.testRunner)
- testRunner.dumpAsText();
-
</script>
<script src=""
</body>
Modified: trunk/LayoutTests/editing/spelling/spelling-unified-emulation.html (157948 => 157949)
--- trunk/LayoutTests/editing/spelling/spelling-unified-emulation.html 2013-10-24 19:53:35 UTC (rev 157948)
+++ trunk/LayoutTests/editing/spelling/spelling-unified-emulation.html 2013-10-24 19:59:57 UTC (rev 157949)
@@ -25,10 +25,6 @@
node.removeChild(node.firstChild);
}
-if (window.testRunner) {
- testRunner.dumpAsText();
-}
-
if (window.internals)
internals.settings.setUnifiedTextCheckerEnabled(true);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
