Diff
Modified: trunk/LayoutTests/ChangeLog (157996 => 157997)
--- trunk/LayoutTests/ChangeLog 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/ChangeLog 2013-10-25 09:50:07 UTC (rev 157997)
@@ -1,3 +1,26 @@
+2013-10-25 Manuel Rego Casasnovas <[email protected]>
+
+ [CSS Regions] Rename CSS classes and JS methods in vertical layout tests about selection
+ https://bugs.webkit.org/show_bug.cgi?id=123327
+
+ Reviewed by Mihnea Ovidenie.
+
+ For consistency with Blink we use Vertical instead of Vert in CSS
+ classes and JS methods related to the selection layout tests for CSS
+ Regions.
+
+ * fast/regions/resources/helper.js:
+ (selectContentByIdsVertical):
+ * fast/regions/resources/region-style.css:
+ * fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html:
+ * fast/regions/selection/selecting-text-ignoring-region-vert-lr.html:
+ * fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html:
+ * fast/regions/selection/selecting-text-ignoring-region-vert-rl.html:
+ * fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
+ * fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
+ * fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
+ * fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:
+
2013-10-25 Javier Fernandez <[email protected]>
Unreviewed GTK gardening. Several fast/regions/selection tests are failing in WK2.
Modified: trunk/LayoutTests/fast/regions/resources/helper.js (157996 => 157997)
--- trunk/LayoutTests/fast/regions/resources/helper.js 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/resources/helper.js 2013-10-25 09:50:07 UTC (rev 157997)
@@ -224,7 +224,7 @@
selectContentByRange(fromRect.left, fromRectVerticalCenter, toRect.right, toRectVerticalCenter);
}
-function selectContentByIdsVert(fromId, toId) {
+function selectContentByIdsVertical(fromId, toId) {
var fromRect = document.getElementById(fromId).getBoundingClientRect();
var toRect = document.getElementById(toId).getBoundingClientRect();
Modified: trunk/LayoutTests/fast/regions/resources/region-style.css (157996 => 157997)
--- trunk/LayoutTests/fast/regions/resources/region-style.css 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/resources/region-style.css 2013-10-25 09:50:07 UTC (rev 157997)
@@ -95,16 +95,16 @@
background-color: lightgrey;
}
-.descriptionVert {
+.descriptionVertical {
height: 600px;
}
-.bigBoxVert {
+.bigBoxVertical {
height: 300px;
width: 100px;
}
-.greyBigBoxVert {
+.greyBigBoxVertical {
height: 300px;
width: 100px;
background-color: lightgrey;
Modified: trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html (157996 => 157997)
--- trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html 2013-10-25 09:50:07 UTC (rev 157997)
@@ -36,22 +36,22 @@
onMouseUpLogSelection("selected-content");
</script>
</head>
-<body _onload_="selectContentByIdsVert('word1', 'word2');">
- <div id="region" class="greyBigBoxVert">
+<body _onload_="selectContentByIdsVertical('word1', 'word2');">
+ <div id="region" class="greyBigBoxVertical">
inside region inside region inside region inside region
inside region inside region inside region inside region
</div>
- <div id="outside-1" class="bigBoxVert">
+ <div id="outside-1" class="bigBoxVertical">
outside region outside region outside region outside region
<span id="word1" class="token">word1</span>
outside region outside region outside region outside region
</div>
- <div id="outside-2" class="bigBoxVert">
+ <div id="outside-2" class="bigBoxVertical">
outside region outside region outside region outside region
<span id="word2" class="token">word2</span>
outside region outside region outside region outside region
</div>
- <div id="description" class="descriptionVert">
+ <div id="description" class="descriptionVertical">
<h1><a href="" #122353 - [CSS Regions] Layout Test for selecting text ignoring region content</a></h1>
<p>This test checks the selection in 2 text wrapping a region. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "inside region" text is not highlighted and not included in the selected content (because of the content of the region is before the "outside region" element in the DOM).</p>
<dl>
Modified: trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-lr.html (157996 => 157997)
--- trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-lr.html 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-lr.html 2013-10-25 09:50:07 UTC (rev 157997)
@@ -16,25 +16,25 @@
onMouseUpLogSelection("selected-content");
</script>
</head>
-<body _onload_="selectContentByIdsVert('word1', 'word2');">
+<body _onload_="selectContentByIdsVertical('word1', 'word2');">
<div class="flowArticle">
inside region inside region inside region inside region
inside region inside region inside region inside region
</div>
- <div class="bigBoxVert float">
+ <div class="bigBoxVertical float">
outside region outside region outside region outside region
<span id="word1" class="token">word1</span>
outside region outside region outside region outside region
</div>
<div class="clear"></div>
- <div class="regionArticle greyBigBoxVert"></div>
- <div class="bigBoxVert float">
+ <div class="regionArticle greyBigBoxVertical"></div>
+ <div class="bigBoxVertical float">
outside region outside region outside region outside region
<span id="word2" class="token">word2</span>
outside region outside region outside region outside region
</div>
<div class="clear"></div>
- <div class="descriptionVert">
+ <div class="descriptionVertical">
<h1><a href="" #122353 - [CSS Regions] Layout Test for selecting text ignoring region content</a></h1>
<p>This test checks the selection in 2 text wrapping a region. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "inside region" text is not highlighted and not included in the selected content (because of the content of the region is before the "outside region" element in the DOM).</p>
<dl>
Modified: trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html (157996 => 157997)
--- trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html 2013-10-25 09:50:07 UTC (rev 157997)
@@ -36,22 +36,22 @@
onMouseUpLogSelection("selected-content");
</script>
</head>
-<body _onload_="selectContentByIdsVert('word1', 'word2');">
- <div id="region" class="greyBigBoxVert">
+<body _onload_="selectContentByIdsVertical('word1', 'word2');">
+ <div id="region" class="greyBigBoxVertical">
inside region inside region inside region inside region
inside region inside region inside region inside region
</div>
- <div id="outside-1" class="bigBoxVert">
+ <div id="outside-1" class="bigBoxVertical">
outside region outside region outside region outside region
<span id="word1" class="token">word1</span>
outside region outside region outside region outside region
</div>
- <div id="outside-2" class="bigBoxVert">
+ <div id="outside-2" class="bigBoxVertical">
outside region outside region outside region outside region
<span id="word2" class="token">word2</span>
outside region outside region outside region outside region
</div>
- <div id="description" class="descriptionVert">
+ <div id="description" class="descriptionVertical">
<h1><a href="" #122353 - [CSS Regions] Layout Test for selecting text ignoring region content</a></h1>
<p>This test checks the selection in 2 text wrapping a region. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "inside region" text is not highlighted and not included in the selected content (because of the content of the region is before the "outside region" element in the DOM).</p>
<dl>
Modified: trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-rl.html (157996 => 157997)
--- trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-rl.html 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-rl.html 2013-10-25 09:50:07 UTC (rev 157997)
@@ -16,25 +16,25 @@
onMouseUpLogSelection("selected-content");
</script>
</head>
-<body _onload_="selectContentByIdsVert('word1', 'word2');">
+<body _onload_="selectContentByIdsVertical('word1', 'word2');">
<div class="flowArticle">
inside region inside region inside region inside region
inside region inside region inside region inside region
</div>
- <div class="bigBoxVert float">
+ <div class="bigBoxVertical float">
outside region outside region outside region outside region
<span id="word1" class="token">word1</span>
outside region outside region outside region outside region
</div>
<div class="clear"></div>
- <div class="regionArticle greyBigBoxVert"></div>
- <div class="bigBoxVert float">
+ <div class="regionArticle greyBigBoxVertical"></div>
+ <div class="bigBoxVertical float">
outside region outside region outside region outside region
<span id="word2" class="token">word2</span>
outside region outside region outside region outside region
</div>
<div class="clear"></div>
- <div class="descriptionVert">
+ <div class="descriptionVertical">
<h1><a href="" #122353 - [CSS Regions] Layout Test for selecting text ignoring region content</a></h1>
<p>This test checks the selection in 2 text wrapping a region. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "inside region" text is not highlighted and not included in the selected content (because of the content of the region is before the "outside region" element in the DOM).</p>
<dl>
Modified: trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html (157996 => 157997)
--- trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html 2013-10-25 09:50:07 UTC (rev 157997)
@@ -32,22 +32,22 @@
onMouseUpLogSelection("selected-content");
</script>
</head>
-<body _onload_="selectContentByIdsVert('word1', 'word2');" style="margin-left: 0;">
- <div id="region-1" class="greyBigBoxVert">
+<body _onload_="selectContentByIdsVertical('word1', 'word2');" style="margin-left: 0;">
+ <div id="region-1" class="greyBigBoxVertical">
inside region inside region inside region inside region
<span id="word1" class="token">word1</span>
inside region inside region inside region inside region
</div>
- <div id="region-2" class="greyBigBoxVert">
+ <div id="region-2" class="greyBigBoxVertical">
inside region inside region inside region inside region
<span id="word2" class="token">word2</span>
inside region inside region inside region inside region
</div>
- <div id="outside" class="bigBoxVert">
+ <div id="outside" class="bigBoxVertical">
outside region outside region outside region outside region
outside region outside region outside region outside region
</div>
- <div id="description" class="descriptionVert">
+ <div id="description" class="descriptionVertical">
<h1><a href="" #121841 - [CSS Regions] Layout Test for selecting text in 2 regions</a></h1>
<p>This test checks the selection in 2 regions. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "outside region" text is not highlighted and not included in the selected content.</p>
<dl>
Modified: trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr.html (157996 => 157997)
--- trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr.html 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr.html 2013-10-25 09:50:07 UTC (rev 157997)
@@ -12,7 +12,7 @@
onMouseUpLogSelection("selected-content");
</script>
</head>
-<body _onload_="selectContentByIdsVert('word1', 'word2');" style="margin-left: 0;">
+<body _onload_="selectContentByIdsVertical('word1', 'word2');" style="margin-left: 0;">
<div class="flowArticle">
inside region inside region inside region inside region
<span id="word1" class="token">word1</span>
@@ -22,13 +22,13 @@
<span id="word2" class="token">word2</span>
inside region inside region inside region inside region
</div>
- <div class="regionArticle greyBigBoxVert"></div>
- <div class="bigBoxVert">
+ <div class="regionArticle greyBigBoxVertical"></div>
+ <div class="bigBoxVertical">
outside region outside region outside region outside region
outside region outside region outside region outside region
</div>
- <div class="regionArticle greyBigBoxVert"></div>
- <div class="descriptionVert">
+ <div class="regionArticle greyBigBoxVertical"></div>
+ <div class="descriptionVertical">
<h1><a href="" #121841 - [CSS Regions] Layout Test for selecting text in 2 regions</a></h1>
<p>This test checks the selection in 2 regions. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "outside region" text is not highlighted and not included in the selected content.</p>
<dl>
Modified: trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html (157996 => 157997)
--- trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html 2013-10-25 09:50:07 UTC (rev 157997)
@@ -32,22 +32,22 @@
onMouseUpLogSelection("selected-content");
</script>
</head>
-<body _onload_="selectContentByIdsVert('word1', 'word2');" style="margin-right: 0;">
- <div id="region-1" class="greyBigBoxVert">
+<body _onload_="selectContentByIdsVertical('word1', 'word2');" style="margin-right: 0;">
+ <div id="region-1" class="greyBigBoxVertical">
inside region inside region inside region inside region
<span id="word1" class="token">word1</span>
inside region inside region inside region inside region
</div>
- <div id="region-2" class="greyBigBoxVert">
+ <div id="region-2" class="greyBigBoxVertical">
inside region inside region inside region inside region
<span id="word2" class="token">word2</span>
inside region inside region inside region inside region
</div>
- <div id="outside" class="bigBoxVert">
+ <div id="outside" class="bigBoxVertical">
outside region outside region outside region outside region
outside region outside region outside region outside region
</div>
- <div id="description" class="descriptionVert">
+ <div id="description" class="descriptionVertical">
<h1><a href="" #121841 - [CSS Regions] Layout Test for selecting text in 2 regions</a></h1>
<p>This test checks the selection in 2 regions. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "outside region" text is not highlighted and not included in the selected content.</p>
<dl>
Modified: trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl.html (157996 => 157997)
--- trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl.html 2013-10-25 08:44:19 UTC (rev 157996)
+++ trunk/LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl.html 2013-10-25 09:50:07 UTC (rev 157997)
@@ -12,7 +12,7 @@
onMouseUpLogSelection("selected-content");
</script>
</head>
-<body _onload_="selectContentByIdsVert('word1', 'word2');" style="margin-right: 0;">
+<body _onload_="selectContentByIdsVertical('word1', 'word2');" style="margin-right: 0;">
<div class="flowArticle">
inside region inside region inside region inside region
<span id="word1" class="token">word1</span>
@@ -22,13 +22,13 @@
<span id="word2" class="token">word2</span>
inside region inside region inside region inside region
</div>
- <div class="regionArticle greyBigBoxVert"></div>
- <div class="bigBoxVert">
+ <div class="regionArticle greyBigBoxVertical"></div>
+ <div class="bigBoxVertical">
outside region outside region outside region outside region
outside region outside region outside region outside region
</div>
- <div class="regionArticle greyBigBoxVert"></div>
- <div class="descriptionVert">
+ <div class="regionArticle greyBigBoxVertical"></div>
+ <div class="descriptionVertical">
<h1><a href="" #121841 - [CSS Regions] Layout Test for selecting text in 2 regions</a></h1>
<p>This test checks the selection in 2 regions. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "outside region" text is not highlighted and not included in the selected content.</p>
<dl>
