Title: [158002] trunk
Revision
158002
Author
[email protected]
Date
2013-10-25 04:57:06 -0700 (Fri, 25 Oct 2013)

Log Message

[GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453

Patch by Anton Obzhirov <[email protected]> on 2013-10-25
Reviewed by Martin Robinson.

Source/WebKit2:

Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformCanHandleRequest):

Tools:

* Scripts/run-gtk-tests:
(TestRunner):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (158001 => 158002)


--- trunk/Source/WebKit2/ChangeLog	2013-10-25 11:49:08 UTC (rev 158001)
+++ trunk/Source/WebKit2/ChangeLog	2013-10-25 11:57:06 UTC (rev 158002)
@@ -1,3 +1,16 @@
+2013-10-25  Anton Obzhirov  <[email protected]>
+
+        [GTK] [WebKit2] CanHandleRequest API test fails
+        https://bugs.webkit.org/show_bug.cgi?id=88453
+
+        Reviewed by Martin Robinson.
+
+        Make WebPage::platformCanHandleRequest return false by default 
+        for unknown schemes.
+
+        * WebProcess/WebPage/gtk/WebPageGtk.cpp:
+        (WebKit::WebPage::platformCanHandleRequest):
+
 2013-10-25  Ryuan Choi  <[email protected]>
 
         [EFL][WK2] Build break after r157967 and r157972

Modified: trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp (158001 => 158002)


--- trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp	2013-10-25 11:49:08 UTC (rev 158001)
+++ trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp	2013-10-25 11:57:06 UTC (rev 158002)
@@ -141,7 +141,7 @@
 bool WebPage::platformCanHandleRequest(const ResourceRequest&)
 {
     notImplemented();
-    return true;
+    return false;
 }
 
 String WebPage::cachedSuggestedFilenameForURL(const URL&)

Modified: trunk/Tools/ChangeLog (158001 => 158002)


--- trunk/Tools/ChangeLog	2013-10-25 11:49:08 UTC (rev 158001)
+++ trunk/Tools/ChangeLog	2013-10-25 11:57:06 UTC (rev 158002)
@@ -1,3 +1,13 @@
+2013-10-25  Anton Obzhirov  <[email protected]>
+
+        [GTK] [WebKit2] CanHandleRequest API test fails
+        https://bugs.webkit.org/show_bug.cgi?id=88453
+
+        Reviewed by Martin Robinson.
+
+        * Scripts/run-gtk-tests:
+        (TestRunner):
+
 2013-10-25  Ryosuke Niwa  <[email protected]>
 
         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.

Modified: trunk/Tools/Scripts/run-gtk-tests (158001 => 158002)


--- trunk/Tools/Scripts/run-gtk-tests	2013-10-25 11:49:08 UTC (rev 158001)
+++ trunk/Tools/Scripts/run-gtk-tests	2013-10-25 11:57:06 UTC (rev 158002)
@@ -69,7 +69,6 @@
         SkippedTest("WebKit2APITests/TestResources", "/webkit2/WebKitWebView/resources", "Test is flaky in GTK Linux 32-bit Release bot", 82868),
         SkippedTest("WebKit2APITests/TestWebKitWebView", SkippedTest.ENTIRE_SUITE, "Test times out after r150890", 117689),
         SkippedTest("WebKit2APITests/TestContextMenu", SkippedTest.ENTIRE_SUITE, "Test times out after r150890", 117689),
-        SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.CanHandleRequest", "Test fails", 88453),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutFrames", "Test fails", 85037),
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to