Title: [158007] trunk/Source/WebCore
Revision
158007
Author
[email protected]
Date
2013-10-25 06:46:55 -0700 (Fri, 25 Oct 2013)

Log Message

REGRESSION(r157950): It made many tests assert on Windows, EFL, GTK
https://bugs.webkit.org/show_bug.cgi?id=123309

Reviewed by Andreas Kling.

Disable simple line layout on non-Mac plaforms for now.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (158006 => 158007)


--- trunk/Source/WebCore/ChangeLog	2013-10-25 13:20:47 UTC (rev 158006)
+++ trunk/Source/WebCore/ChangeLog	2013-10-25 13:46:55 UTC (rev 158007)
@@ -1,3 +1,15 @@
+2013-10-25  Antti Koivisto  <[email protected]>
+
+        REGRESSION(r157950): It made many tests assert on Windows, EFL, GTK
+        https://bugs.webkit.org/show_bug.cgi?id=123309
+
+        Reviewed by Andreas Kling.
+
+        Disable simple line layout on non-Mac plaforms for now.
+
+        * rendering/SimpleLineLayout.cpp:
+        (WebCore::SimpleLineLayout::canUseFor):
+
 2013-10-24  Andreas Kling  <[email protected]>
 
         SVG: applyResource() should take a RenderElement&.

Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (158006 => 158007)


--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2013-10-25 13:20:47 UTC (rev 158006)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2013-10-25 13:46:55 UTC (rev 158007)
@@ -54,6 +54,11 @@
 
 bool canUseFor(const RenderBlockFlow& flow)
 {
+#if !PLATFORM(MAC)
+    // FIXME: Non-mac platforms are hitting ASSERT(run.charactersLength() >= run.length())
+    // https://bugs.webkit.org/show_bug.cgi?id=123338
+    return false;
+#endif
     if (!flow.firstChild())
         return false;
     // This currently covers <blockflow>#text</blockflow> case.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to