[webkit-changes] [158040] trunk/Source/WebCore

Fri, 25 Oct 2013 13:33:51 -0700

Title: [158040] trunk/Source/WebCore
Revision
158040
Author
[email protected]
Date
2013-10-25 13:35:01 -0700 (Fri, 25 Oct 2013)

Log Message

[MSE] Fix runtime errors caused by mediasource IDL attributes.
https://bugs.webkit.org/show_bug.cgi?id=123352

Reviewed by Eric Carlson.

Due to http://webkit.org/b/123178, MediaSource classes must add a GenerateIsReachable
(and also a JSGenerateToJSObject) attribute to avoid runtime asserts and crashes.

* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBuffer.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/mediasource/WebKitMediaSource.idl:
* Modules/mediasource/WebKitSourceBufferList.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (158039 => 158040)


--- trunk/Source/WebCore/ChangeLog	2013-10-25 20:34:34 UTC (rev 158039)
+++ trunk/Source/WebCore/ChangeLog	2013-10-25 20:35:01 UTC (rev 158040)
@@ -1,3 +1,19 @@
+2013-10-25  Jer Noble  <[email protected]>
+
+        [MSE] Fix runtime errors caused by mediasource IDL attributes.
+        https://bugs.webkit.org/show_bug.cgi?id=123352
+
+        Reviewed by Eric Carlson.
+
+        Due to http://webkit.org/b/123178, MediaSource classes must add a GenerateIsReachable
+        (and also a JSGenerateToJSObject) attribute to avoid runtime asserts and crashes.
+
+        * Modules/mediasource/MediaSource.idl:
+        * Modules/mediasource/SourceBuffer.idl:
+        * Modules/mediasource/SourceBufferList.idl:
+        * Modules/mediasource/WebKitMediaSource.idl:
+        * Modules/mediasource/WebKitSourceBufferList.idl:
+
 2013-10-25  Jacky Jiang  <[email protected]>
 
         [BlackBerry] Browser crashed at PlatformGraphicsContext::addDrawLineForText() when trying to upload a video to youtube

Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.idl (158039 => 158040)


--- trunk/Source/WebCore/Modules/mediasource/MediaSource.idl	2013-10-25 20:34:34 UTC (rev 158039)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.idl	2013-10-25 20:35:01 UTC (rev 158040)
@@ -32,6 +32,7 @@
     Conditional=MEDIA_SOURCE,
     ActiveDOMObject,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
     Constructor,
     ConstructorCallWith=ScriptExecutionContext,

Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl (158039 => 158040)


--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl	2013-10-25 20:34:34 UTC (rev 158039)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl	2013-10-25 20:35:01 UTC (rev 158040)
@@ -33,6 +33,7 @@
     NoInterfaceObject,
     ActiveDOMObject,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
     OperationsNotDeletable
 ] interface SourceBuffer : EventTarget {

Modified: trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl (158039 => 158040)


--- trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl	2013-10-25 20:34:34 UTC (rev 158039)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl	2013-10-25 20:35:01 UTC (rev 158040)
@@ -32,7 +32,9 @@
     Conditional=MEDIA_SOURCE,
     NoInterfaceObject,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
+    GenerateIsReachable=Impl,
     CallWith=ScriptExecutionContext,
     OperationsNotDeletable
 ] interface SourceBufferList : EventTarget {

Modified: trunk/Source/WebCore/Modules/mediasource/WebKitMediaSource.idl (158039 => 158040)


--- trunk/Source/WebCore/Modules/mediasource/WebKitMediaSource.idl	2013-10-25 20:34:34 UTC (rev 158039)
+++ trunk/Source/WebCore/Modules/mediasource/WebKitMediaSource.idl	2013-10-25 20:35:01 UTC (rev 158040)
@@ -32,6 +32,7 @@
     Conditional=MEDIA_SOURCE,
     ActiveDOMObject,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
     Constructor,
     ConstructorCallWith=ScriptExecutionContext,

Modified: trunk/Source/WebCore/Modules/mediasource/WebKitSourceBufferList.idl (158039 => 158040)


--- trunk/Source/WebCore/Modules/mediasource/WebKitSourceBufferList.idl	2013-10-25 20:34:34 UTC (rev 158039)
+++ trunk/Source/WebCore/Modules/mediasource/WebKitSourceBufferList.idl	2013-10-25 20:35:01 UTC (rev 158040)
@@ -31,7 +31,9 @@
 [
     Conditional=MEDIA_SOURCE,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
+    GenerateIsReachable=Impl,
     OperationsNotDeletable
 ] interface WebKitSourceBufferList : EventTarget {
     readonly attribute unsigned long length;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to