Modified: trunk/Websites/test-results/ChangeLog (158054 => 158055)
--- trunk/Websites/test-results/ChangeLog 2013-10-25 21:54:00 UTC (rev 158054)
+++ trunk/Websites/test-results/ChangeLog 2013-10-25 21:57:40 UTC (rev 158055)
@@ -1,5 +1,24 @@
2013-10-25 Ryosuke Niwa <[email protected]>
+ Merge revision columns in flakiness dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=123360
+
+ Reviewed by Simon Fraser.
+
+ Merge revision numbers into one cell separated by /, and clearly label them as "latest revisions".
+ Also add colors for missing & audio failures so that they won't be an empty cell.
+
+ * public/index.html:
+ (TestResultsView._createTestResultHeader): Create a single th for the list of repository names.
+ (TestResultsView._createTestResultRow): Use single td for all revision numbers.
+ * public/js/build.js:
+ (.this.formattedRevision): Don't prefix revision numbers with '@' when we're not in the tooltip.
+ * public/main.css:
+ (.resultsTable .AUDIO a): Added.
+ (.resultsTable .MISSING a): Added.
+
+2013-10-25 Ryosuke Niwa <[email protected]>
+
One more build fix. Put each latest revision information in an actual td.
* public/index.html:
Modified: trunk/Websites/test-results/public/index.html (158054 => 158055)
--- trunk/Websites/test-results/public/index.html 2013-10-25 21:54:00 UTC (rev 158054)
+++ trunk/Websites/test-results/public/index.html 2013-10-25 21:57:40 UTC (rev 158055)
@@ -207,13 +207,19 @@
}
TestResultsView._createTestResultHeader = function (labelForFirstColumn, repositories) {
+ var latestResultsLabel = '';
+ if (repositories) {
+ latestResultsLabel = ['Latest results', element('br'),
+ repositories.map(function (repository) { return repository.name; }).join(' / ')];
+ }
+
return element('thead', [element('tr', [
element('th', [labelForFirstColumn]),
element('th', ['Bug']),
element('th', ['Expectations']),
- element('th', ['Slowest'])]
- .concat(repositories ? repositories.map(function (repository) { return element('th', [repository.name]); }) : [])
- .concat([element('th')]))]);
+ element('th', ['Slowest']),
+ element('th', latestResultsLabel),
+ element('th')])]);
}
TestResultsView._createBuildsAndComputeSlownessOfResults = function (builderId, results) {
@@ -274,15 +280,17 @@
else
slowestTime = '';
- var formattedRevisionCells = [];
+ var latestRevisions = [];
if (repositories) {
var build = sortedResults[0].build;
for (var i = 0; i < repositories.length; i++) {
var revisionInfo = build.formattedRevision(repositories[i].id);
+ if (latestRevisions.length)
+ latestRevisions.push(' / ');
if (revisionInfo.url)
- formattedRevisionCells.push(element('td', [element('a', {'href': revisionInfo.url}, [revisionInfo.label])]));
+ latestRevisions.push(element('a', {'href': revisionInfo.url}, [revisionInfo.label]));
else
- formattedRevisionCells.push(element('td', [revisionInfo.label]));
+ latestRevisions.push(revisionInfo.label);
}
}
@@ -291,7 +299,7 @@
element('td', {'class': 'modifiers'}, formattedModifiers),
element('td', {'class': 'expected'}, [sortedResults[0].expected]),
element('td', {'class': 'slowestTime'}, [slowestTime])]
- .concat(formattedRevisionCells)
+ .concat(element('td', latestRevisions))
.concat([element('td', cells)]));
}
Modified: trunk/Websites/test-results/public/js/build.js (158054 => 158055)
--- trunk/Websites/test-results/public/js/build.js 2013-10-25 21:54:00 UTC (rev 158054)
+++ trunk/Websites/test-results/public/js/build.js 2013-10-25 21:57:40 UTC (rev 158055)
@@ -45,11 +45,14 @@
var labelForThisRepository = shouldIncludeNameInLabel ? repositoryName : '';
if (previousRevision) {
- if (labelForThisRepository)
+ if (labelForThisRepository && shouldIncludeNameInLabel)
labelForThisRepository += ' ';
labelForThisRepository += revisionPrefix + previousRevision + '-' + revisionPrefix + currentRevision;
- } else
- labelForThisRepository += ' @' + revisionPrefix + currentRevision;
+ } else {
+ if (shouldIncludeNameInLabel)
+ labelForThisRepository += ' @';
+ labelForThisRepository += revisionPrefix + currentRevision;
+ }
var url;
if (repository) {
Modified: trunk/Websites/test-results/public/main.css (158054 => 158055)
--- trunk/Websites/test-results/public/main.css 2013-10-25 21:54:00 UTC (rev 158054)
+++ trunk/Websites/test-results/public/main.css 2013-10-25 21:57:40 UTC (rev 158055)
@@ -155,6 +155,14 @@
background-color: #fc3;
}
+.resultsTable .AUDIO a {
+ background-color: #3cf;
+}
+
+.resultsTable .MISSING a {
+ background-color: #666;
+}
+
.resultsTable .TEXT.PASS a {
background-color: #cf3;
}
