Title: [158114] trunk/Source/_javascript_Core
Revision
158114
Author
[email protected]
Date
2013-10-28 10:20:07 -0700 (Mon, 28 Oct 2013)

Log Message

The GetById->GetByOffset AI-based optimization should actually do things
https://bugs.webkit.org/show_bug.cgi?id=123299

Reviewed by Oliver Hunt.
        
20% speed-up on Octane/gbemu.

* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor): Actually finish filling in the Status by setting the state. Previously it would remain set to NoInformation, meaning that this whole method was a no-op.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (158113 => 158114)


--- trunk/Source/_javascript_Core/ChangeLog	2013-10-28 16:15:45 UTC (rev 158113)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-10-28 17:20:07 UTC (rev 158114)
@@ -1,3 +1,15 @@
+2013-10-24  Filip Pizlo  <[email protected]>
+
+        The GetById->GetByOffset AI-based optimization should actually do things
+        https://bugs.webkit.org/show_bug.cgi?id=123299
+
+        Reviewed by Oliver Hunt.
+        
+        20% speed-up on Octane/gbemu.
+
+        * bytecode/GetByIdStatus.cpp:
+        (JSC::GetByIdStatus::computeFor): Actually finish filling in the Status by setting the state. Previously it would remain set to NoInformation, meaning that this whole method was a no-op.
+
 2013-10-28  Carlos Garcia Campos  <[email protected]>
 
         Unreviewed. Fix make distcheck.

Modified: trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp (158113 => 158114)


--- trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp	2013-10-28 16:15:45 UTC (rev 158113)
+++ trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp	2013-10-28 17:20:07 UTC (rev 158114)
@@ -281,6 +281,7 @@
         specificValue = 0;
     result.m_structureSet.add(structure);
     result.m_specificValue = JSValue(specificValue);
+    result.m_state = Simple;
     return result;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to