Title: [158242] trunk/LayoutTests
Revision
158242
Author
[email protected]
Date
2013-10-29 17:58:22 -0700 (Tue, 29 Oct 2013)

Log Message

REGRESSION(r158198): editing/execCommand/insert-list-xml.xhtml fails
https://bugs.webkit.org/show_bug.cgi?id=123460

Reviewed by Ryosuke Niwa.

The original version of this test used a MathML document root,
and attempted to add HTML content to prove that a bad cast would
not be encountered when manipulating the MathML document via
_javascript_.

r158198 broke the test, because it enforced the requirements that
MathML nodes not generate renderers for non-MathML children.

This patch revises the test to use an SVG document, which does
permit child HTML nodes.

* TestExpectations: Remove temporary exclusion landed in
  r158216.
* editing/execCommand/insert-list-xml-expected.txt:
* editing/execCommand/insert-list-xml.xhtml:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (158241 => 158242)


--- trunk/LayoutTests/ChangeLog	2013-10-30 00:52:58 UTC (rev 158241)
+++ trunk/LayoutTests/ChangeLog	2013-10-30 00:58:22 UTC (rev 158242)
@@ -1,3 +1,26 @@
+2013-10-29  Brent Fulgham  <[email protected]>
+
+        REGRESSION(r158198): editing/execCommand/insert-list-xml.xhtml fails
+        https://bugs.webkit.org/show_bug.cgi?id=123460
+
+        Reviewed by Ryosuke Niwa.
+
+        The original version of this test used a MathML document root,
+        and attempted to add HTML content to prove that a bad cast would
+        not be encountered when manipulating the MathML document via
+        _javascript_.
+
+        r158198 broke the test, because it enforced the requirements that
+        MathML nodes not generate renderers for non-MathML children.
+
+        This patch revises the test to use an SVG document, which does
+        permit child HTML nodes.
+
+        * TestExpectations: Remove temporary exclusion landed in
+          r158216.
+        * editing/execCommand/insert-list-xml-expected.txt:
+        * editing/execCommand/insert-list-xml.xhtml:
+
 2013-10-29  Ryosuke Niwa  <[email protected]>
 
         Mountain Lion rebaseline after r158231.

Modified: trunk/LayoutTests/TestExpectations (158241 => 158242)


--- trunk/LayoutTests/TestExpectations	2013-10-30 00:52:58 UTC (rev 158241)
+++ trunk/LayoutTests/TestExpectations	2013-10-30 00:58:22 UTC (rev 158242)
@@ -75,5 +75,3 @@
 webkit.org/b/122679 security/crypto-subtle-gc.html [ Skip ]
 webkit.org/b/122679 security/crypto-subtle-gc-2.html [ Skip ]
 webkit.org/b/122679 security/crypto-subtle-gc-3.html [ Skip ]
-
-webkit.org/b/123460 editing/execCommand/insert-list-xml.xhtml [ Failure ]

Modified: trunk/LayoutTests/editing/execCommand/insert-list-xml.xhtml (158241 => 158242)


--- trunk/LayoutTests/editing/execCommand/insert-list-xml.xhtml	2013-10-30 00:52:58 UTC (rev 158241)
+++ trunk/LayoutTests/editing/execCommand/insert-list-xml.xhtml	2013-10-30 00:58:22 UTC (rev 158242)
@@ -1,6 +1,7 @@
-<mat:diff xmlns:mat="http://www.w3.org/1998/Math/MathML">
-  <html xmlns="http://www.w3.org/1999/xhtml">  
-    <head> 
+<?xml version="1.0" standalone="yes"?>
+<svg xmlns = "http://www.w3.org/2000/svg">
+  <foreignObject x="10" y="10" width="800" height="150">
+    <body xmlns="http://www.w3.org/1999/xhtml" _onload_="start();">
       <script type="text/_javascript_">
         if (window.testRunner)
             testRunner.dumpAsText();
@@ -22,10 +23,8 @@
             console.appendChild(li);
         }
       </script>
-    </head>
-    <body _onload_="start();">
       <div contenteditable="true" id="insertlisthere">.</div>
-    <ul id="console"></ul>
+      <ul id="console"></ul>
     </body>
-  </html>
-</mat:diff>
+  </foreignObject>
+</svg>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to