Title: [158352] trunk
- Revision
- 158352
- Author
- [email protected]
- Date
- 2013-10-31 01:38:28 -0700 (Thu, 31 Oct 2013)
Log Message
[EFL] accessibility/textbox-role-reports-selection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112017
Patch by Robert Plociennik <[email protected]> on 2013-10-31
Reviewed by Mario Sanchez Prada.
Source/WebCore:
getSelectionOffsetsForObject() now returns proper start/end offsets for
selections "touching" the object's front border.
No new tests, covered by existing ones.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject):
LayoutTests:
Removed failure expectations.
* platform/efl-wk1/TestExpectations: The test is no longer failing.
* platform/efl-wk2/TestExpectations: The test is no longer failing.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (158351 => 158352)
--- trunk/LayoutTests/ChangeLog 2013-10-31 07:11:07 UTC (rev 158351)
+++ trunk/LayoutTests/ChangeLog 2013-10-31 08:38:28 UTC (rev 158352)
@@ -1,3 +1,15 @@
+2013-10-31 Robert Plociennik <[email protected]>
+
+ [EFL] accessibility/textbox-role-reports-selection.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=112017
+
+ Reviewed by Mario Sanchez Prada.
+
+ Removed failure expectations.
+
+ * platform/efl-wk1/TestExpectations: The test is no longer failing.
+ * platform/efl-wk2/TestExpectations: The test is no longer failing.
+
2013-10-30 Ryosuke Niwa <[email protected]>
Add two crash expectations per bug 123555.
Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (158351 => 158352)
--- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-10-31 07:11:07 UTC (rev 158351)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-10-31 08:38:28 UTC (rev 158352)
@@ -164,7 +164,6 @@
webkit.org/b/112012 accessibility/svg-bounds.html [ Failure ]
webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ]
webkit.org/b/112015 accessibility/textarea-line-for-index.html [ Failure ]
-webkit.org/b/112017 accessibility/textbox-role-reports-selection.html [ Failure ]
webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ]
webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
webkit.org/b/112021 accessibility/visible-elements.html [ Failure Crash ]
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (158351 => 158352)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-10-31 07:11:07 UTC (rev 158351)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-10-31 08:38:28 UTC (rev 158352)
@@ -164,7 +164,6 @@
webkit.org/b/112012 accessibility/svg-bounds.html [ Failure ]
webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ]
webkit.org/b/112015 accessibility/textarea-line-for-index.html [ Failure ]
-webkit.org/b/112017 accessibility/textbox-role-reports-selection.html [ Failure ]
webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ]
webkit.org/b/112019 accessibility/title-ui-element-correctness.html [ Failure ]
webkit.org/b/112021 accessibility/visible-elements.html [ Failure Crash ]
Modified: trunk/Source/WebCore/ChangeLog (158351 => 158352)
--- trunk/Source/WebCore/ChangeLog 2013-10-31 07:11:07 UTC (rev 158351)
+++ trunk/Source/WebCore/ChangeLog 2013-10-31 08:38:28 UTC (rev 158352)
@@ -1,3 +1,18 @@
+2013-10-31 Robert Plociennik <[email protected]>
+
+ [EFL] accessibility/textbox-role-reports-selection.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=112017
+
+ Reviewed by Mario Sanchez Prada.
+
+ getSelectionOffsetsForObject() now returns proper start/end offsets for
+ selections "touching" the object's front border.
+
+ No new tests, covered by existing ones.
+
+ * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+ (getSelectionOffsetsForObject):
+
2013-10-31 Ryuan Choi <[email protected]>
[EFL][GLES] OpenGL should be optional
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (158351 => 158352)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-10-31 07:11:07 UTC (rev 158351)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp 2013-10-31 08:38:28 UTC (rev 158352)
@@ -518,7 +518,7 @@
// Early return with proper values if the selection falls entirely out of the object.
if (!selectionBelongsToObject(coreObject, selection)) {
- startOffset = comparePositions(selection.start(), firstValidPosition) < 0 ? 0 : accessibilityObjectLength(coreObject);
+ startOffset = comparePositions(selection.start(), firstValidPosition) <= 0 ? 0 : accessibilityObjectLength(coreObject);
endOffset = startOffset;
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
