Title: [158375] trunk/Source/WebCore
- Revision
- 158375
- Author
- [email protected]
- Date
- 2013-10-31 11:26:21 -0700 (Thu, 31 Oct 2013)
Log Message
Repro scrolling crash with scrollbars that use setPresentationValue on the
scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=123549
-and corresponding-
<rdar://problem/15246606>
Reviewed by Darin Adler.
Speculative fix. I think if we retain the ScrollbarPainters, we should avoid this
crash.
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (158374 => 158375)
--- trunk/Source/WebCore/ChangeLog 2013-10-31 18:18:44 UTC (rev 158374)
+++ trunk/Source/WebCore/ChangeLog 2013-10-31 18:26:21 UTC (rev 158375)
@@ -1,3 +1,18 @@
+2013-10-31 Beth Dakin <[email protected]>
+
+ Repro scrolling crash with scrollbars that use setPresentationValue on the
+ scrolling thread
+ https://bugs.webkit.org/show_bug.cgi?id=123549
+ -and corresponding-
+ <rdar://problem/15246606>
+
+ Reviewed by Darin Adler.
+
+ Speculative fix. I think if we retain the ScrollbarPainters, we should avoid this
+ crash.
+
+ * page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
+
2013-10-31 Philippe Normand <[email protected]>
Unreviewed, MediaStream build fix after r158365.
Modified: trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.h (158374 => 158375)
--- trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.h 2013-10-31 18:18:44 UTC (rev 158374)
+++ trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.h 2013-10-31 18:26:21 UTC (rev 158375)
@@ -85,8 +85,8 @@
RetainPtr<CALayer> m_counterScrollingLayer;
RetainPtr<CALayer> m_headerLayer;
RetainPtr<CALayer> m_footerLayer;
- ScrollbarPainter m_verticalScrollbarPainter;
- ScrollbarPainter m_horizontalScrollbarPainter;
+ RetainPtr<ScrollbarPainter> m_verticalScrollbarPainter;
+ RetainPtr<ScrollbarPainter> m_horizontalScrollbarPainter;
IntPoint m_probableMainThreadScrollPosition;
bool m_lastScrollHadUnfilledPixels;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
