Title: [158379] trunk/Source/WebCore
- Revision
- 158379
- Author
- [email protected]
- Date
- 2013-10-31 11:47:00 -0700 (Thu, 31 Oct 2013)
Log Message
Decorated text sometimes does not draw its decorations
https://bugs.webkit.org/show_bug.cgi?id=123539
Patch by Myles C. Maxfield <[email protected]> on 2013-10-31
Reviewed by Antti Koivisto.
Decorated text should opt-out of the simple line layout, because
SimpleLineLayout::paintFlow doesn't draw decorations
Fixes fast/css3-text/css3-text-decoration/text-decoration-color.html
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (158378 => 158379)
--- trunk/Source/WebCore/ChangeLog 2013-10-31 18:40:14 UTC (rev 158378)
+++ trunk/Source/WebCore/ChangeLog 2013-10-31 18:47:00 UTC (rev 158379)
@@ -1,3 +1,18 @@
+2013-10-31 Myles C. Maxfield <[email protected]>
+
+ Decorated text sometimes does not draw its decorations
+ https://bugs.webkit.org/show_bug.cgi?id=123539
+
+ Reviewed by Antti Koivisto.
+
+ Decorated text should opt-out of the simple line layout, because
+ SimpleLineLayout::paintFlow doesn't draw decorations
+
+ Fixes fast/css3-text/css3-text-decoration/text-decoration-color.html
+
+ * rendering/SimpleLineLayout.cpp:
+ (WebCore::SimpleLineLayout::canUseFor):
+
2013-10-31 Joseph Pecoraro <[email protected]>
Web Inspector: Remove last member variable uses of InspectorState from Agents
Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (158378 => 158379)
--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp 2013-10-31 18:40:14 UTC (rev 158378)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp 2013-10-31 18:47:00 UTC (rev 158379)
@@ -94,6 +94,8 @@
return false;
}
const RenderStyle& style = flow.style();
+ if (style.textDecorationsInEffect() != TextDecorationNone)
+ return false;
if (style.textAlign() == JUSTIFY)
return false;
// Non-visible overflow should be pretty easy to support.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
